web/video.js
1
0
Fork 0
mirror of https://github.com/videojs/video.js.git synced 2025-01-10 23:30:03 +02:00
Code Releases Activity
86d29cdc66
video.js/test/unit/tracks
History
mister-ben a10d25861d
fix: removes duplicate id in text track settings (#8755) 
## Description
Prevents a duplicate id in text track settings.
Fixes #8754

## Specific Changes proposed
The text edge settings were erroneously duplicating the id generated for
the background colour. Changes to a unique name.
Adds a general test for duplicate ids.

## Requirements Checklist
- [x] Feature implemented / Bug fixed
- [ ] If necessary, more likely in a feature request than a bug fix
- [x] Change has been verified in an actual browser (Chrome, Firefox,
IE)
  - [x] Unit Tests updated or fixed
  - [ ] Docs/guides updated
- [ ] Example created ([starter template on
JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0))
- [x] Has no DOM changes which impact accessiblilty or trigger warnings
(e.g. Chrome issues tab)
  - [x] Has no changes to JSDoc which cause `npm run docs:api` to error
- [ ] Reviewed by Two Core Contributors
2024-06-01 23:11:52 +02:00
..
audio-track-list.test.js fix: fix audio and video track selection (#5890) 2019-03-25 12:02:33 -04:00
audio-track.test.js Fix several typos in docs and comments (#8110) 2023-03-22 15:00:01 +01:00
audio-tracks.test.js test: memory leak fixes in tests (#5861) 2019-03-18 15:49:48 -04:00
html-track-element-list.test.js fix: prevent dispose error and text track duplicate listeners (#6984) 2021-01-21 17:02:15 -05:00
html-track-element.test.js fix: prevent dispose error and text track duplicate listeners (#6984) 2021-01-21 17:02:15 -05:00
text-track-controls.test.js test(text-track-controls): fix failing test caused by incompatibility between PRs (#7686) 2022-03-21 14:20:18 -04:00
text-track-cue-list.test.js fix(vjsstandard): update to 8.0.2 and fixup linting (#5413) 2018-09-28 14:58:15 -04:00
text-track-display.test.js fix: make compatible with chrome 53 (#8354) 2023-07-12 19:43:17 +02:00
text-track-list-converter.test.js fix: prevent dispose error and text track duplicate listeners (#6984) 2021-01-21 17:02:15 -05:00
text-track-list.test.js test: memory leak fixes in tests (#5861) 2019-03-18 15:49:48 -04:00
text-track-select.test.js fix: Ensure aria-labelledby values in track settings are valid (#8711) 2024-05-06 09:58:47 -07:00
text-track-settings.test.js fix: removes duplicate id in text track settings (#8755) 2024-06-01 23:11:52 +02:00
text-track.test.js fix: Check for VTTCue (#8370) 2023-07-20 11:38:15 -05:00
text-tracks.test.js Fix several typos in docs and comments (#8110) 2023-03-22 15:00:01 +01:00
track-baseline.js feat(track): make label property mutable and fire a labelchange event when the label is changed (#6928) 2020-11-10 18:11:53 -05:00
track-list.test.js feat(track): make label property mutable and fire a labelchange event when the label is changed (#6928) 2020-11-10 18:11:53 -05:00
track.test.js feat(track): make label property mutable and fire a labelchange event when the label is changed (#6928) 2020-11-10 18:11:53 -05:00
video-track-list.test.js fix: fix audio and video track selection (#5890) 2019-03-25 12:02:33 -04:00
video-track.test.js test: memory leak fixes in tests (#5861) 2019-03-18 15:49:48 -04:00
video-tracks.test.js test: memory leak fixes in tests (#5861) 2019-03-18 15:49:48 -04:00