Commit Graph
8 Commits
Author SHA1 Message Date
Michał Janiszewski 0ff2e1180d Throw std::runtime_exception instead of a pointer to new one
cf. https://isocpp.org/wiki/faq/exceptions#what-to-throw
2018-10-31 07:27:54 +01:00
Michał Janiszewski 7be9aa4868 Prevent shadowing of function arguments by local vars 2018-10-29 16:56:14 +01:00
Michał Janiszewski 9822a8f2df Catch exceptions by const-ref, not by value 2018-10-29 16:41:54 +01:00
Michał Janiszewski 53d75684ee Prevent shadowing of global variable in function argument 2018-10-29 16:34:03 +01:00
Michał Janiszewski 27953bd758 Add missing include guards 2018-10-29 16:30:50 +01:00
Michał Janiszewski f5ebc763b4 Add override keyword where applicable 2017-02-17 14:39:16 +01:00
Michał Janiszewski e28f64efd2 Fix compilation with clang 4
See https://www.securecoding.cert.org/confluence/display/cplusplus/EXP58-CPP.+Pass+an+object+of+the+correct+type+to+va_start
for details
2017-02-17 10:00:26 +01:00
Michał Janiszewski bece1e5b1f fixed possible nullptr dereference
* Fixed a switch() statement in InfoBoxHeroData::getValueText that
  could result in nullptr dereference. If 'type' was HERO_MANA and
  'hero' was nullptr, a fallthrough would occur to HERO_EXPERIENCE,
  where 'hero' would we be dereferenced.
* Fixed line endings.
2014-04-25 14:31:11 +02:00