Ivan Savenko
cb82c6a4f6
Fix calculation of new secondary skill level. Fixes bug with removal
2025-05-16 17:21:39 +03:00
Ivan Savenko
456525109e
Replaced undescriptive bool true/false with more clear enum for
...
absolute/relative change via netpacks
2025-05-16 17:21:39 +03:00
Ivan Savenko
630f911cc9
Merge pull request #5713 from IvanSavenko/gamecallback_remove
...
Game callback rework (part 1?)
2025-05-16 17:19:37 +03:00
Ivan Savenko
6dd25d6a67
Merge pull request #5716 from kdmcser/zip_maps
...
fix crash when map is packaged in a zip mod
2025-05-16 17:19:24 +03:00
Ivan Savenko
e87bbf210e
Merge pull request #5714 from IvanSavenko/spellbook_fix
...
Fix crash on playing spellbook pageflip video
2025-05-16 17:18:29 +03:00
kdmcser
5e4912d056
fix crash when map is packaged in a zip mod
2025-05-16 01:14:12 +08:00
Ivan Savenko
3aa2771e92
Fix crash on playing spellbook pageflip video
...
Was reported on Discord.
- Fixes corrupted name of spellbook page flip video
- Fixes possible crash on deleting invalid video instance
2025-05-15 17:55:17 +03:00
Ivan Savenko
a13806a0df
Fix build
2025-05-15 16:58:16 +03:00
Ivan Savenko
ce77914b7e
Merge pull request #5711 from IvanSavenko/commander_leveling
...
Fix commander levelups
2025-05-15 13:35:13 +03:00
Ivan Savenko
1909975e03
Merge pull request #5712 from vcmi/dependabot/github_actions/DavidAnson/markdownlint-cli2-action-20
...
Bump DavidAnson/markdownlint-cli2-action from 19 to 20
2025-05-15 13:34:50 +03:00
Ivan Savenko
6aadcf43d3
Fix tests
2025-05-15 13:04:47 +03:00
Ivan Savenko
cedb577b5c
Update example.markdownlint-cli2.jsonc
2025-05-15 12:10:29 +03:00
dependabot[bot]
29fc817579
Bump DavidAnson/markdownlint-cli2-action from 19 to 20
...
Bumps [DavidAnson/markdownlint-cli2-action](https://github.com/davidanson/markdownlint-cli2-action ) from 19 to 20.
- [Release notes](https://github.com/davidanson/markdownlint-cli2-action/releases )
- [Commits](https://github.com/davidanson/markdownlint-cli2-action/compare/v19...v20 )
---
updated-dependencies:
- dependency-name: DavidAnson/markdownlint-cli2-action
dependency-version: '20'
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-05-15 04:21:54 +00:00
Ivan Savenko
b09152d62a
Fix commander levelups
...
- Fixes commander not receiving experience if stack experience is off
- Fixes commander not leveling up when hero fill his secondary skills
2025-05-14 21:51:32 +03:00
Ivan Savenko
4d4da0454f
map objects hierarchy now uses IGameInfoCallback
2025-05-14 18:33:20 +03:00
Ivan Savenko
6f20235d07
Merge CPrivilegedInfoCallback into CGameInfoCallback
2025-05-14 13:42:20 +03:00
Ivan Savenko
b37a3dc63c
Lighthouse / flaggable objects now has dedicated bonus system node
...
this alows to remove multiple hacks from lighthouse logic
2025-05-14 13:42:19 +03:00
Ivan Savenko
716da918f8
Completely remove IGameCallback class
...
- CClient now inherits directly from CPrivilegedInfoCallback, like
IGameCallback did before. However CClient no longer needs dummy
implementation of IGameEventCallback
- CGObjectInstance hierarchy now uses CPrivilegedInfoCallback for
callback. Actual events can only be emitted in calls that receive
IGameEventCallback pointer, e.g. heroVisit
- CGameHandler now inherits directly from both CPrivilegedInfoCallback
and IGameEventCallback as it did before via IGameCallback
2025-05-14 13:39:41 +03:00
Ivan Savenko
f7d08a7288
Merge pull request #5700 from IvanSavenko/gamestate_pack_visitor
...
Remove CPack::applyGs method in favor of GameStatePackVisitor class
2025-05-14 11:53:15 +03:00
Ivan Savenko
1165dadfd4
Merge pull request #5701 from IvanSavenko/bonus_docs
...
Update documentation for bonuses and fix creature type limiter
2025-05-14 11:53:05 +03:00
Ivan Savenko
c62e1d289e
Merge pull request #5706 from IvanSavenko/antagarich
...
Fix missing messages on events without guards on .vmap's (e.g. Antagarich Burning)
2025-05-14 11:52:52 +03:00
Ivan Savenko
a13ab8f013
Merge pull request #5707 from IvanSavenko/dwelling_fix
...
Fixes for handling of oversized map dwellings
2025-05-14 11:52:40 +03:00
Ivan Savenko
d25db82bf8
Merge pull request #5710 from IvanSavenko/docs_fix
...
Fix documentation on configurable map objects
2025-05-14 11:52:30 +03:00
Ivan Savenko
f26dca2026
Merge pull request #5708 from kdmcser/limit_fix
...
OppositeLimiter fix and boat creation fix when loading map
2025-05-14 11:52:15 +03:00
Ivan Savenko
ed2b9e77e4
Fix documentation on configurable map objects
2025-05-13 18:12:43 +03:00
Ivan Savenko
9a30ce27af
Merge pull request #5705 from IvanSavenko/callback_split
...
Reorganize callback-related code
2025-05-13 15:21:39 +03:00
Ivan Savenko
1f15a7faa4
Fix build
2025-05-12 22:07:10 +03:00
Ivan Savenko
2c17c2d5b7
Rework CCallback <-> CClient interaction
...
- callback is now part of lib instead of weird class that is shared by
client and AI while being part of client
- callback interacts with client class via minimal interface class
- removed no longer used unlockGsWhileWaiting field
2025-05-12 22:07:10 +03:00
Ivan Savenko
35644da2b7
Reogranize callback-related classes on 1 file = 1 class basis
2025-05-12 22:07:09 +03:00
kdmcser
1c4d78c3fa
fix boat instanceName not set bug in loading map
2025-05-13 01:04:27 +08:00
kdmcser
c464e953e2
Merge branch 'develop' into limit_fix
2025-05-13 00:59:25 +08:00
kdmcser
ab46a16322
fix OppositeSideLimiter treat UNFLAGGABLE as opposite of NEUTRAL
2025-05-13 00:58:10 +08:00
Ivan Savenko
cb70cc48d6
Fixes for handling of oversized map dwellings
...
- Marked large version of H3 Unicorn's Glade as not usable for random
dwelling replacement
- Shifted oversized dwellings - that have at most 2x2 as blocked tile,
but have non-blocked tile column will now be placed correctly
- This fixes incorrect random dwelling replacement of the only oversized
H3 dwelling - Portal of Glory
- Game will now detect & report invalid dwelling templates from mods
- Updated docs to clarify dwellings format
2025-05-12 18:01:46 +03:00
Ivan Savenko
79591ac587
Fix missing messages on events without guards on .vmap's
2025-05-12 15:42:59 +03:00
Ivan Savenko
29207c0b0f
Merge pull request #5702 from IvanSavenko/sonar
...
Fix issues detected by Sonar
2025-05-12 14:54:39 +03:00
Ivan Savenko
0a74992268
Fix formatting
2025-05-11 19:58:49 +03:00
Ivan Savenko
4b30336d03
Fix issues detected by Sonar
2025-05-11 19:50:57 +03:00
kdmcser
7543fee02c
fix OppositeSideLimiter error
2025-05-12 00:46:06 +08:00
Ivan Savenko
990f766254
Update & expand docs on bonus limiters & updaters
2025-05-10 19:16:51 +03:00
Ivan Savenko
519fbae43c
Add example of typical bonus system graph to docs
2025-05-10 19:13:47 +03:00
Ivan Savenko
a188934e12
Add basic description of battlefield layout
2025-05-10 19:12:59 +03:00
Ivan Savenko
9bf5cf42f3
Move guides to separate directory to make them easier to find
2025-05-10 19:11:30 +03:00
Ivan Savenko
3d170bb1f4
Fix creature type limiter not considering upgrades of upgrades
2025-05-10 19:09:08 +03:00
Ivan Savenko
86b832be67
Remove CPack::applyGs method in favor of GameStatePackVisitor class
2025-05-10 17:51:35 +03:00
Ivan Savenko
cb5295b9ec
Merge pull request #5690 from IvanSavenko/rewardable_improve
...
Extend functionality of rewardable objects
2025-05-09 18:47:56 +03:00
Ivan Savenko
754bc16e82
Fix .md formatting
2025-05-09 18:45:28 +03:00
Ivan Savenko
ed6725db0f
Update schemas
2025-05-09 17:31:25 +03:00
Ivan Savenko
cf69440e9a
Update docs
2025-05-09 17:26:35 +03:00
Ivan Savenko
6859ab7c36
Fix discovered issues, remove not implemented ideas
2025-05-09 17:26:23 +03:00
Ivan Savenko
de134326e0
Merge pull request #5693 from kdmcser/crash_fix
...
fix crash when loading game in battle
2025-05-08 15:44:06 +03:00