1
0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2026-06-03 18:35:08 +02:00
Commit Graph

1195 Commits

Author SHA1 Message Date
Nelson Ghezzi aa66fe75e4 OS and Process resource detectors (#1788)
* WIP: OS and Process resource detectors

* Completed documentation headers

* Added empty test files for OS and Process resource functions

* Split long line

* Added resource.WithOS function test

* Added resource.WithProcess* functions tests

* Renamed osDetector and WithOS function to better reflect they only add the os.type attribute

* Updated changelog

* WIP: possible use of wrappers for getting attribute values

* Refined implementation of wrapper functions providing os/runtime/user information

* Added PR number to new changelog entries

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Fix wrong function name in documentation header

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Fixed wording in WithProcessOwner documentation header

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Updated osTypeDetector

* Replaced ToUpper with ToLower to match the current convention.
* Used runtimeOS provider to get the OS name.

* Adapted WithOSType test to mock runtime providers

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2021-04-23 08:28:13 -07:00
Li Zhijian 7374d67961 Fix Links documents (#1835)
Signed-off-by: Hu Shuai <hus.fnst@cn.fujitsu.com>

Co-authored-by: Hu Shuai <hus.fnst@cn.fujitsu.com>
2021-04-23 08:04:59 -07:00
Tyler Yahn 856f5b8401 Add feature request issue template (#1831)
* Add feature request issue template

* Update .github/ISSUE_TEMPLATE/feature_request.md

Co-authored-by: Sam Xie <xsambundy@gmail.com>

Co-authored-by: Sam Xie <xsambundy@gmail.com>
2021-04-22 08:35:59 -07:00
Tyler Yahn 0fdc3d78a2 Remove bundler from Jaeger exporter (#1830)
* Remove bundler from Jaeger exporter

* Update dependencies

* Add changes to changelog

* Add PR number to changelog
2021-04-22 10:47:27 -04:00
Tyler Yahn 738ef11e31 Fix flaky global ErrorHandler delegation test (#1829)
* Resolve flaky global ErrorHandler delegation test

Remove multi-goroutine approach and just test what needs to be tested.

* Assert instead of require where appropriate
2021-04-21 15:17:02 -04:00
Sai Nadendla e43d9c00bc Update Default Value for Jaeger Exporter Endpoint (#1824)
* Update Default Value for OTEL_EXPORTER_JAEGER_ENDPOINT Env Var

* update comments

* fix documentation

* update CHANGELOG

* add missing tab

* fix lint issue

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
2021-04-21 15:02:06 -04:00
Dhruv Vora 0032bd6499 Fix default merging of resource attributes from environment variable (#1785)
* updated controller to merge default resource with environment resource

* updated TracerProvider to merge default resource with environment resource

* Added Changelog entry

* Added resource.Environment(), modified resource.Default() for environment vairable and WithResource() configuration for TracerProvider and Controller

* Update CHANGELOG.md

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

* Moved environment detector to defaultResource initialization, added test cases

* Changes to default resource initialization

* made changes to the test cases

* added merging of resource with environment resource

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
2021-04-21 14:53:12 -04:00
Tyler Yahn 96c5e4baac Add SpanProcessor example for Span annotation on start (#1733)
* Add SpanProcessor example for Span annotation on start

* Remove New* func to make more concise

* Add doc for AttrsFunc

* Move overview comment to top

* Update based on feedback

* Remove AttrsFunc type

* Use OnEnd to print instead of separate exporter

* Move the tracer declaration
2021-04-21 14:40:52 -04:00
Tyler Yahn 543c8144b9 Remove the WithSDKOptions from the Jaeger exporter (#1825)
* Remove the WithSDKOptions from the Jaeger exporter

* Lint

* Setup SDK in Jaeger example
2021-04-20 16:48:34 -07:00
Iris Song 66389ad617 Update function docs in sdk.go (#1826)
* Made copy of attribute.KeyValue

* Add comments and test

* move test to sdk/metric

* Update CHANGELOG.md

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

* Add label order assertions for final results

* Update CHANGELOG PR number

* Revert code changes and update docs

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2021-04-20 14:29:13 -07:00
Gustavo Silva Paiva 70bc9eb391 Adds support for timeout on the otlp/gRPC exporter (#1821)
* initial support for timeout on otlp grpc exporter

* fix tests

* run make

* update changelog

* update changelog

* apply suggestions

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2021-04-20 10:02:02 -07:00
Tyler Yahn 081cc61d98 Update Jaeger exporter convenience functions (#1822)
* Update Jaeger exporter convenience functions

* Update changelog PR numbers

* Update CHANGELOG.md

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

* Revert removed raw exporter test

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
2021-04-20 09:31:59 -07:00
Tyler Yahn 1b9f16d3af Remove the WithDisabled option from Jaeger exporter (#1806)
* Remove the WithDisabled option from Jaeger exporter

* Update PR number
2021-04-19 09:09:19 -07:00
dependabot[bot] 6867faa096 Bump actions/cache from v2.1.4 to v2.1.5 (#1818)
Bumps [actions/cache](https://github.com/actions/cache) from v2.1.4 to v2.1.5.
- [Release notes](https://github.com/actions/cache/releases)
- [Commits](https://github.com/actions/cache/compare/v2.1.4...1a9e2138d905efd099035b49d8b7a3888c653ca8)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2021-04-19 07:35:12 -07:00
Tyler Yahn a2bf04dc36 Build context pipeline in Jaeger upload process (#1809) 2021-04-19 07:27:22 -07:00
Tyler Yahn 2de86f23c3 Remove locking from Jaeger exporter shutdown/export (#1807) 2021-04-17 12:24:11 -07:00
Tyler Yahn 4f9fec29da Add ExportSpans benchmark to Jaeger exporter (#1805) 2021-04-17 11:17:01 -07:00
Tyler Yahn d9566abea9 Fix OTLP testing flake: signal connection from mock collector (#1816)
* Wrap TCP listener

The mock collector listener now signals when it receives a connection
instead of waiting an arbitrary time an hoping the event happens.

* Only close the listener C chan once

* Apply PR feedback

* Backwards compatible support for closed listener check

* Cleanup
2021-04-17 09:26:06 -07:00
Gustavo Silva Paiva a2cecb6e80 add support for env var configuration to otlp/gRPC (#1811)
* move options to `otlpconfig` internal package

* add support for env configs on otel/gRPC

* remove duplicate code

* refactor options

* format imports

* move marshal option to oltphttp

* clone tls configs and tests grpc certificates

* add more context to http errors

* add todo

* add entry to changelog

* update changelog with pr number

* apply suggestions

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2021-04-16 14:52:24 -07:00
Tyler Yahn d616df61f5 Fix flaky OTLP exporter reconnect test (#1814)
* Fix flaky OTLP exporter reconnect test

The tests that check the OTLP exporter will reconnect wait for the
reconnect loop to complete, in theory. However, they do not yield the
active goroutine scheduling. The reconnect loop is in its own goroutine
meaning it is unlikely for that loop to be re-entered, especially on
slow systems. This updates the tests call runtime.Gosched when waiting
for the reconnect loop and yield the scheduling to other goroutines.

* Add changes to changelog

* Use time.After instead of Timer

* Remove changelog entry
2021-04-14 18:52:58 -07:00
Aaron Clawson b09df84a24 Changes stdout to expose the *sdktrace.TracerProvider (#1800)
* Changes stdout to expose the actual tracerProvider

This enables flushing and stopping the exporter.

* updated changelog

* Update CHANGELOG.md

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2021-04-14 08:51:41 -07:00
Tyler Yahn 0489060896 Remove options field from Jaeger exporter (#1808)
The initialization options of the exporter are not used after the
Exporter is created. Stop saving them in a field.
2021-04-14 08:23:44 -07:00
Tyler Yahn 6db20e008d Remove the abandoned Process struct in Jaeger exporter (#1804)
* Remove the abandoned Process struct in Jaeger exporter

Use of this struct was removed in #1776.

* Update changelog
2021-04-13 10:08:04 -07:00
Szymon Łągiewka 086abf342d docs: use test example to document prometheus.InstallNewPipeline (#1796)
* docs: update InstallNewPipeline example comment

* docs: update changelog after PR submit

* fix: wrap issue number in parens

* docs: use test example to document prometheus.InstallNewPipeline

* fix: update CHANGELOG to reflect PR state

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2021-04-13 09:03:18 -07:00
dependabot[bot] d0cea04b35 Bump google.golang.org/api from 0.43.0 to 0.44.0 in /exporters/trace/jaeger (#1792)
* Bump google.golang.org/api in /exporters/trace/jaeger

Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.43.0 to 0.44.0.
- [Release notes](https://github.com/googleapis/google-api-go-client/releases)
- [Changelog](https://github.com/googleapis/google-api-go-client/blob/master/CHANGES.md)
- [Commits](https://github.com/googleapis/google-api-go-client/compare/v0.43.0...v0.44.0)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2021-04-12 09:16:02 -07:00
Huy Vo 99c477feb8 Fixed typo for default service name in Jaeger Exporter (#1797)
* Fix typo in jaeger exporter

* Update changelog

* Add PR number to changelog

* Move entry in changelog to Fixed

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2021-04-12 08:49:55 -07:00
dependabot[bot] 95fd8f5092 Bump google.golang.org/grpc from 1.36.1 to 1.37.0 in /exporters/otlp (#1791)
* Bump google.golang.org/grpc from 1.36.1 to 1.37.0 in /exporters/otlp

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.36.1 to 1.37.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.36.1...v1.37.0)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2021-04-12 08:42:48 -07:00
sicong.huang 9b25164481 Zipkin Exporter: Use default resouce's serviceName as default serivce name (#1777) (#1786)
Signed-off-by: lastchiliarch <lastchiliarch@163.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2021-04-12 08:36:21 -07:00
Alik Khilazhev 4d141e4752 Add k8s.node.name and k8s.node.uid to semconv (#1789)
* Add k8s.node.name and k8s.node.uid to semconv

According to the specification[1] they should exist.

[1] https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/resource/semantic_conventions/k8s.md#node

* Update changelog

* Update semconv/resource.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update semconv/resource.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update CHANGELOG.md

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update semconv/resource.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2021-04-12 08:21:13 -07:00
Guangwen Feng 5c99a34cd8 Fix golint issue caused by incorrect comment (#1795)
Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
2021-04-12 08:10:00 -07:00
Sai Nadendla c5d006c07a Update Jaeger environment variables (#1752)
* Update Jaeger Environment Variables

* Update CHANGELOG

* Add Jaeger environment vars envAgentHost, envAgentPort; remove envDisabled

* Fix broken test due to setting nonexistant env var

* fix function name

* add default values for agent hostPort

* remove agentEndpoint arg

* add agent host/port options

* update client params

* add envOr function
2021-04-09 09:56:26 -07:00
Sergei Semenchuk 584328080a add NewExportPipeline and InstallNewPipeline for otlp (#1373)
* add NewExportPipeline and InstallNewPipeline for otlp

Signed-off-by: binjip978 <binjip978@gmail.com>

* remove resource, AlwaysSample, Timeout, etc

* remove withSpanProcessor

Signed-off-by: binjip978 <binjip978@gmail.com>

* move changelog entry to unreleased

Signed-off-by: binjip978 <binjip978@gmail.com>

* merged with combined push/pull metrics controller

Signed-off-by: binjip978 <binjip978@gmail.com>

* remove SetMeterProvider

* Update CHANGELOG.md

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

* Update CHANGELOG.md

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update exporters/otlp/otlp.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2021-04-08 11:11:22 -07:00
Matej Gera 7d8e6bd781 Zipkin Exporter: Adjust span transformation to comply with the spec (#1688)
* Adjust instrumentation lib name / version key

* Adjust array attribute serialization

* Adjust span status mapping

- remove `otel.status_description`; use `error` instead for description
- do not report status code if unset
- do not report description if OK or unset
- omit tags if no tag has been mapped
- adjust tests

* Set remote endpoint according to the spec

- See
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk_exporters/zipkin.md#remote-endpoint

* Fix remaining tests

* Update CHANGELOG

* Add some more tests

* Address PR feedback

- Simplify deletion of redundant error code
- Simplify endpoint rank determination

* More tests for remote endpoint
2021-04-07 13:33:15 -04:00
Tyler Yahn 2817c09174 Merge sdk/export/trace into sdk/trace (#1778)
* Merge sdk/export/trace into sdk/trace

* Update package move

* Add changes to changelog

* Add PR number to changelog
2021-04-07 08:03:43 -07:00
Bruno Rafael c61e654cd4 Refactor prometheus exporter tests to match file headers as well (#1470)
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2021-04-06 16:40:12 -07:00
IrisTuntun 23422c56df Remove process config for Jaeger exporter (#1776)
* remove process config for Jaeger exporter

* remove process config for Jaeger exporter

* Add CHANGELOG.md back

* Add CHANGLOG.md changes back

* fill in PR number in CHANGELOG

* Update CHANGELOG.md

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2021-04-06 15:03:32 -07:00
Cynthia Du 0d49b592ec Add test to check bsp ignores OnEnd and ForceFlush post Shutdown` (#1772)
* Add test to check bsp ignores OnEnd and ForceFlush post shutdown

* Add to CHANGELOG

* Check for err return value

* Stop test execution if there's error with shutting down bsp

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Use assert to check there's no error calling bsp.ForceFlush()

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Import require

* Add error message for assertion on be.len()

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2021-04-06 14:54:26 -07:00
Tyler Yahn e9aaa04b8f Record links/events attribute drops independently (#1771)
* Record links/events attribute drops independently

* Update PR number

* Remove unneeded span.droppedAttributeCount
2021-04-06 07:51:15 -07:00
humivo 5bbfc22cbc Make ExportSpans for Jaeger Exporter honor deadline (#1773)
* Make ExportSpans for Jaeger honor deadline

* Make variable name more descriptive

* new commit

* Revert "new commit"

This reverts commit 06e24cc38d.

* Change PR number in changelog

* Take out separate goroutine and add back TODO

* Check error string

* Fix error assert

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2021-04-05 13:33:16 -07:00
Tyler Yahn 0786fe3250 Add Bug report issue templates (#1775) 2021-04-05 12:30:09 -07:00
Matej Gera 3c7facee73 Add ExportTimeout option to batch span processor (#1755)
* Add ExportTimeout option

* Adjust tests

* Update CHANGELOG

* Beef up the exporter timeout test

* Beef up exporter test - attempt #2

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2021-04-05 10:38:03 -07:00
Anthony Mirabella c6b92d5b20 Make TraceFlags spec-compliant (#1770)
* Make TraceFlags spec-compliant

* Remove `trace.FlagsDebug` and `trace.FlagsDeferred`
  * These are used only by the B3 propagator and will be handled there in the `context.Context`
* Make `trace.TraceFlags` a defined type, aliasing `byte`
* Move `IsSampled` method from `trace.SpanContext` to `trace.TraceFlags`
* Add `Sampled(bool)` method to `trace.TraceFlags`
* Implement `Stringer` and `json.Marshaler` for `trace.TraceFlags`

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>

* Rename `TraceFlags.Sampled()` to `TraceFlags.WithSampled()` for consistency

* Restore `SpanContext.IsSampled()` method.

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
2021-04-05 10:21:42 -07:00
dependabot[bot] ee687ca5c8 Bump github.com/itchyny/gojq from 0.12.2 to 0.12.3 in /internal/tools (#1774)
Bumps [github.com/itchyny/gojq](https://github.com/itchyny/gojq) from 0.12.2 to 0.12.3.
- [Release notes](https://github.com/itchyny/gojq/releases)
- [Changelog](https://github.com/itchyny/gojq/blob/main/CHANGELOG.md)
- [Commits](https://github.com/itchyny/gojq/compare/v0.12.2...v0.12.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-05 08:54:30 -07:00
Gustavo Silva Paiva 52a24774da add support for configuring tls certs via env var to otlp/HTTP (#1769) 2021-04-02 17:53:40 -04:00
Tyler Yahn 35cfbc7e87 Update precedence of event name in Jaeger exporter (#1768)
* Update precedence of event name in Jaeger exporter

The OTel specification states that the event needs to be recorded as a
log with its name set to a tag having the "event" key. That key needs to
be overridden when there is an attribute with the same key. This updates
to implement this.

Resolves #1767

* Add changes to changelog

* Update PR number in changelog

* lint
2021-04-02 07:15:20 -07:00
Jack Wink 33699d242d Adds semantic conventions for exceptions (#1492)
Adds support for the opentelemetry exceptions semantic conventions. In
short, this has RecordError produce an exception event with exception
attributes instead of using the error event and error attributes.

While golang does not have exceptions, the spec itself does not
differentiate between errors and exceptions for recording purposes.
RecordError was kept as the method name, both for backwards
compatibility and to reduce confusion (the method signature takes in a
golang error object). The spec appears to allow this, as it suggests the
method is optional and signature may reflect whatever is most appropriate
for the language implementing it.

It may seem non-intuitive to log an exception event from a method called
RecordError, but it's beneficial to have consistent behavior across all
opentelemetry SDKs. Downstream projects like the opentelemetry-collector
can build off of the published API and not special case behaviors from
individual languages.
2021-04-01 13:07:46 -07:00
humivo 928e3c38e6 Modify ForceFlush to abort after timeout/cancellation (#1757)
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2021-04-01 10:42:19 -07:00
IrisTuntun 3947cab4be Fix testCollectorEndpoint typo and add tag assertions in jaeger_test (#1753)
* Fix testCollectorEndpoint typo and add tag assertions in jaeger_test

* add PR number for CHANGLOG

* add tag and sevicename assetions in TestExporter_ExportSpan

* update assert.Equal to assert.Len and revert CHANGLOG

* update assert.Len to require.Len
2021-04-01 12:41:52 -04:00
Austin Parker ecc635dc1d add website docs (#1747) 2021-04-01 12:36:51 -04:00
Tyler Yahn 07a8d195e2 Fix Jaeger span status reporting and unify tag keys (#1761)
* Fix Jaeger span status reporting and unify tag keys

Move all tag key strings to be consts defined in a unified location.

Fix the status code and message tag keys to conform with the
specification.

Do not set the span status message if it is not set to conform with the
specification.

* Add changes to changelog

* Update CHANGELOG.md

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

* Fix misspell

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
2021-04-01 09:27:37 -07:00