Daniel Mieg
50ba60f078
Docu improvements ( #2547 )
...
* Add line breaks
* Introduce line breaks
2021-01-27 18:24:21 +01:00
Daniel Mieg
cf69206a58
Docu updates ( #2545 )
...
* Docu updates
* Remove empty lines
* Add quotes
* Change to list
2021-01-27 17:18:28 +01:00
Kevin Stiehl
9ad0dec224
add access_token alias to all gh secrets ( #2543 )
2021-01-27 12:58:47 +01:00
Thorsten Duda
35c2eeaa5b
Temporary fix ppiper/cf-cli version ( #2541 )
...
* Temporary fix ppiper/cf-cli version
* update unit tests
2021-01-27 10:52:40 +01:00
Dominik Lendle
52722c298a
Bug Fixes for abaputils class + unit tests ( #2525 )
...
* Bug Fixes
* remove command.Command
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
2021-01-26 20:23:59 +01:00
Jesse Awan
ea203a2c69
fix(protecode): handle sha256 in upload artifacts ( #2532 )
...
* add sha256 check to protecodeExecuteScan
* remove trailing spaces
* add Unit-Test for getTarName
* Apply suggestions from code review
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2021-01-26 09:59:10 +01:00
Srinikitha Kondreddy
efe3ab36f8
Support for secretfile type neo credential for deployment ( #2537 )
...
* Use Oauth bearer token credentials to deploy to neo
* Add test case
* Add test file
* Fix code climate issues
* Add code review changes
2021-01-26 09:29:44 +01:00
Marcus Holl
ee7279c8fc
Add helper for finding uninitialized config ( #2534 )
...
Add helper for finding uninitialized config
2021-01-25 12:58:43 +01:00
Oliver Nocon
7bdbed3d65
feat: provide reporting re-use package ( #2536 )
...
* initial version of reporting
* added tests
* Update reporting.go
2021-01-25 11:09:03 +01:00
Mayur Belur Mohan
fe72b295d6
IntegrationArtifactDeploy Command ( #2526 )
...
* UpdateIntegrationArtifactConfiguration Command
* Fixes for codeclimate Check
* CommonStepsTest changes
* CodeReview Changes
* Git Patch
* Git Patch undo
* Code Review Comments
* code review fixes
* improve the error handling
* codeclimate fixes
* remove json parsing
* Error handling changes
* TestCase coverage fixes
* Refactoring Commands
* IntegrationArtifactDeploy Command
* Regenerate metadata_generated
* codereview fixes
* Code Review Fixes
* Code Review Fixes
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
2021-01-22 15:55:50 +01:00
Sven Merk
3e0a2835fd
Improve HTTP test to cover more retry capabilities ( #2528 )
...
* FF disable fulltextsearch
# Conflicts:
# pkg/fortify/fortify.go
# pkg/fortify/fortify_test.go
* Improve test on HTTP retry capabilities
* Improve HTTP retry test
2021-01-22 09:56:56 +01:00
Sven Merk
f149292374
[fix]fortifyExecuteScan: disable fulltextsearch ( #2527 )
...
* FF disable fulltextsearch
# Conflicts:
# pkg/fortify/fortify.go
# pkg/fortify/fortify_test.go
* Completely avoid interacting with fulltextsearch
* Remove also from version lookup
2021-01-21 16:20:46 +01:00
Giridhar Shenoy
205bbc1bed
fix(detect): scan paths to better handle signature scan and dependency scan paths ( #2508 )
...
* changes to detectExec before master merge
* changes for detectExecuteScan
* self generated code added
* fix syntax errors and update docu
* added unit tests for fail and Group
* fix failOn bug
* add Groups as string array
* add Groups as string array
* tests and validation for groups, failOn
* Updated docs and added more tests
* documentation md files should not be changed
* Handle merge conflicts from PR 1845
* fix merge errors
* remove duplicate groups, merge error
* adding buildCode and buildTool as params
* switching build options
* building maven modules
* parameter correction
* parameter correction
* gnerate with new build parameter
* adding comments
* removing piper lib master and modifying goUtils to download 1.5.7 release
* first cleaning then installing
* multi module maven built
* multi module maven built removing unwanted code
* multi module maven built moving inside switch
* testing
* modifying the default use case to also call maven build
* modifying the default use case to also call maven build wih --
* corrected maven build command
* corrected maven build command with %v
* skipping test runs
* testing for MTA project with single pom
* adding absolute path to m2 path
* clean up
* adding switch for mta and maven and removing env from containers
* commiting changes for new detect step
* correting log message
* code clean up
* unit tests changes to detectExecute
* basic tests for new change
* restoring piperGoUtils to download correct piper binary
* code clean up
* code clean up
* revert to clean version
* add unmap parameter to detect
* Added Additional parameters for BlackDuck scan
* Added detect tools paramater
* fix detect.yaml to accept correct data type
* fix codeclimate issue in detect.yaml
Co-authored-by: Keshav <anil.keshav@sap.com>
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2021-01-21 14:57:00 +01:00
Kevin Stiehl
4a92d1a96a
[Vault] Mixin Vault Parameters for default config ( #2523 )
...
* load vault filters for custom defaults
* add tests
2021-01-20 14:59:47 +01:00
Marcus Holl
9e8e5da394
[refactoring] Make room for other upload action: move package ( #2518 )
...
* [refactoring] Make room for other upload action: move package
In the near future we will have more upload actions, like
SOLMAN, RFC. Here we prepare the package structure for that.
* don't use aliasing
* rename entities (no leading CTS)
2021-01-18 13:20:30 +01:00
Daniel Mieg
273012ddfc
Fix marshalling a boolean ( #2521 )
2021-01-18 11:14:55 +01:00
Sven Merk
205d59c1ed
Remove obsolete parameter ( #2515 )
...
* Remove obsolete parameter
* Update pkg/fortify/fortify_test.go
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
* Update fortify_test.go
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2021-01-15 13:55:13 +01:00
Marcus Holl
f22ff9a4d5
Remove cm client as prerequisite since we are expecting always a docker environment ( #2511 )
2021-01-14 09:35:31 +01:00
Marcus Holl
c8c1315d0c
transport request upload cts / the step ( #2416 )
...
fiori cts upload piper-go step
2021-01-13 16:14:56 +01:00
Marcus Holl
f9af1841e4
[docu] remove outated hint for not supported CTS upload ( #2506 )
2021-01-13 15:13:38 +01:00
Oliver Feldmann
741b49140e
Move pull image parameters to general section ( #2478 )
...
* Move pull image parameters to general section
* Allow no nesting override
* Test dockerPullImage can be set to true
As the default is false, we need to make sure it can still be set to true.
2021-01-13 10:48:48 +01:00
Oliver Feldmann
ce9b958410
Document SendRequest error case ( #2507 )
...
* Document error case
* Improve docu text
2021-01-12 15:26:45 +01:00
Marcus Holl
84bb028ffd
fix typo for transportRequestUploadFile ( #2499 )
2021-01-12 15:15:30 +01:00
mayurmohan
f4469c3427
DeployIntegrationArtifact Command ( #2474 )
...
DeployIntegrationArtifact Command
Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
Co-authored-by: Marcus Holl <marcus.holl@sap.com>
2021-01-12 12:17:42 +01:00
Christopher Fenner
6dd006f0a0
fix(cpe): fix issue in custom type determination ( #2505 )
2021-01-12 11:36:25 +01:00
Marcus Holl
65d22eb42a
Mta extension credentials handling ( #2430 )
...
Mta extension credentials handling
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2021-01-12 09:39:04 +01:00
Marcus Holl
93330d5ed2
Prepare credentials for forwarding as environment variables to piper go ( #2432 )
...
Prepare credentials for forwarding as environment variables to piper go
2021-01-12 09:17:34 +01:00
Christopher Fenner
834dd1a1de
fix(CPE): correct handling of complex (json) data in writeToDisk ( #2500 )
...
* correct handling of JSON data
* fix typo
* Update commonPipelineEnvironment.groovy
2021-01-11 12:58:12 +01:00
Oliver Nocon
006aaab50d
fix(handlePipelineStepError): correct handling of failed steps ( #2498 )
...
* WIP: debug incorrect error message
* Update piperExecuteBin.groovy
* Update piperExecuteBin.groovy
* Update handlePipelineStepErrors.groovy
* Update piperExecuteBin.groovy
* Update handlePipelineStepErrors.groovy
* Update piperExecuteBin.groovy
* Update piperExecuteBin.groovy
* Update piperExecuteBin.groovy
* Update piperExecuteBin.groovy
* Update handlePipelineStepErrors.groovy
* Update handlePipelineStepErrors.groovy
* Update commonPipelineEnvironment.groovy
* Update piperExecuteBin.groovy
* Update handlePipelineStepErrors.groovy
* Update handlePipelineStepErrors.groovy
* Update handlePipelineStepErrors.groovy
* Update handlePipelineStepErrors.groovy
* Update handlePipelineStepErrors.groovy
* Update piperExecuteBin.groovy
* Update piperExecuteBin.groovy
* Update piperExecuteBin.groovy
* Update commonPipelineEnvironment.groovy
* Update handlePipelineStepErrors.groovy
* Update handlePipelineStepErrors.groovy
* Update piperExecuteBin.groovy
* Update vars/piperExecuteBin.groovy
* Update vars/handlePipelineStepErrors.groovy
* Update handlePipelineStepErrors.groovy
* Apply suggestions from code review
* correct test case
* change test case
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
Co-authored-by: Christopher Fenner <Christopher.Fenner@sap.com>
2021-01-11 10:49:33 +01:00
Oliver Nocon
ab3362849a
feat(kubernetesDeploy): allow disabling --force
( #2495 )
...
fixes #1731
2021-01-07 16:52:16 +01:00
Oliver Nocon
5f5450449e
fix(piperExecuteBin): define variable ( #2497 )
2021-01-07 12:24:48 +01:00
Marcus Holl
a6b2cb9c83
Tell us what was changed. ( #2492 )
...
With the current approach we get a failure when the generated
content triggers a change. But we cannot see what was changed.
With this commit we can see the diff. In case there is not diff
we will not see anything, so there is in that case no real change
in the behaviour. But in case there is a change we will see that
change.
Without that we have to reproduce locally, which means additional
efforts.
2021-01-04 13:23:30 +01:00
Marcus Holl
6d5a30683b
[refactor] Relocate npmExecutorMock so that it can be used from pkg ( #2472 )
...
From the current location inside "cmd" the npmExecutorMock cannot
be used from any coding inside "pkg".
When we would like to re-use the npm functionality we have also to
provide tests and this requires having a mock.
In order to be able to use the mock from pkg we move the mock from
"cmd" to "pkg" into package "npm".
With the shift from package "cmd" to "npm" a lot of fields in the mock
has been made public.
2021-01-04 12:46:14 +01:00
Marcus Holl
9172fcae04
Don't expose auth header to log ( #2334 )
...
Do not expose auth header to log
2021-01-04 10:06:28 +01:00
Oliver Nocon
59f32cf042
feature(vault) retrieve github token from Vault ( #2484 )
2020-12-22 17:57:11 +01:00
Oliver Nocon
4bd155d1ed
feature(protecodeExecuteScan) proper Vault support ( #2483 )
2020-12-22 17:43:57 +01:00
lndrschlz
b101106a05
chore: hide warn level if verbose not configured ( #2466 )
2020-12-22 14:33:11 +01:00
Fabian Reh
40a594f5fa
Add section about signing commits in git. ( #2488 )
...
* Add section about signing commits in git.
Signed-off-by: Fabian Reh <fabian.reh@sap.com>
* Fixes headings
Signed-off-by: Fabian Reh <fabian.reh@sap.com>
2020-12-22 10:09:35 +01:00
Fabian Reh
d8d4f83fb4
Unit test enhancement ( #2471 )
...
* Fixes parallelization in generated code
* Fixes test_code_generated.golden
* generate go code
Signed-off-by: Fabian Reh <fabian.reh@sap.com>
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-12-22 09:30:54 +01:00
Hans Schulz
e9a7590c5c
Add cfTrace parameter ( #2248 )
...
* add cfTrace parameter
* make cfTrace toggle creation of log file
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-12-21 17:46:52 +01:00
Oliver Nocon
7de42230e0
add step to create a GitHub issue ( #2481 )
...
* add step to create a GirHub issue
* add groovy library step
* Update githubcreateissue.yaml
Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com>
2020-12-21 17:13:16 +01:00
Oliver Nocon
cf7ca8f791
add step to create a GitHub comment ( #2479 )
...
* add step to create a GitHub comment
* add docs
* mandatory parameters
* add command
* Update githubCommentIssue.go
* add groovy library step
Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com>
2020-12-21 16:21:07 +01:00
Stephan Aßmus
cb069148d2
WS: Provide missing aliases ( #2485 )
2020-12-21 13:16:38 +01:00
Marcus Holl
cdb784aaf4
fiori cts upload ( #2390 )
...
fiori cts upload
Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
2020-12-21 09:05:49 +01:00
Marcus Holl
a84692ea97
Remove strange 'Hello', most likly troubleshoot leftover ( #2475 )
...
in case this is really important it should be logged and not
emitted to stdout.
2020-12-18 11:15:15 +01:00
tiloKo
dbef910e83
Update abapAddonAssemblyKitCheckPV.go ( #2468 )
...
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
2020-12-16 11:19:48 +01:00
Peter Persiel
fe6a0b057e
Replace naming of software product with add-on product ( #2450 )
...
Co-authored-by: Dominik Lendle <59923031+dominiklendle@users.noreply.github.com>
2020-12-16 10:11:41 +01:00
Marcus Holl
f9fc642c0e
http client: tell us which resource was not found ( #2410 )
...
Up to now we get a message 'Requested resource could not be found' which is not very
helpul during troubleshooting based on the log. With this change we tell the reader
which resource could not be resolved.
2020-12-16 08:55:22 +01:00
Srinikitha Kondreddy
d9a1355220
Fix typo ( #2436 )
2020-12-14 15:02:49 +01:00
Peter Persiel
e1935fe3dc
link multitenant application in ABAP Environment ( #2451 )
...
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
2020-12-14 14:35:51 +01:00