jenkins/sap-jenkins-library
1
0
Fork 0
mirror of https://github.com/SAP/jenkins-library.git synced 2026-06-19 22:58:55 +02:00
Code Issues Releases Activity
1,215 Commits 186 Branches 558 Tags
bca5b8ccf1fd25fed2ca79cf79f4e01bdbd4d0f1
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Marcus HollandGitHub ddaa941b25 Merge pull request #473 from marcusholl/pr/fixDocuGeneratorFormatting 
fix docu generator formatting
 2019-01-29 17:52:39 +01:00
Marcus Holl 50edac02ca First char after docu asterisk is pruned 
... with a blank after the asterisk the docu looks more beautifyfull.
 2019-01-29 17:30:26 +01:00
Marcus Holl 8fb7c85e99 keep leading blanks in order to render 'git diff! Note' statements 2019-01-29 17:30:25 +01:00
Marcus HollandChristoph Szymanski ee58859cd9 Doc: Fix transportRequestCreate docu (transportRequestId) (#467) 2019-01-28 10:25:36 +01:00
Marcus HollandGitHub 3d4e429b3c Merge pull request #455 from marcusholl/pr/betterReadableRuleNames 
[refactoring] better readable rule names
 2019-01-24 08:22:10 +01:00
Marcus Holl 32a708c836 Merge remote-tracking branch 'github/master' into HEAD 2019-01-24 08:15:35 +01:00
Marcus HollandGitHub 8eecb47187 Merge pull request #419 from marcusholl/pr/piper-api 
Pr/piper api
 2019-01-24 08:12:42 +01:00
Marcus Holl 50fea23d2f Merge remote-tracking branch 'github/master' into HEAD 2019-01-24 08:04:55 +01:00
Marcus HollandGitHub 7f78eb1595 Merge pull request #461 from marcusholl/pr/fixGenerateDocuAnnotation 
Put GenerateDocumentation annotation inside groovy file
 2019-01-24 07:59:22 +01:00
Marcus Holl 5c4843aeaf Put GenerateDocumentation annotation inside groovy file 
... since java files are not compiled on Jenkins causing compilation
failures since the annotation cannot be found.
 2019-01-23 16:19:34 +01:00
Marcus HollandGitHub c366829499 Merge pull request #452 from marcusholl/pr/escapeEnvValuesForDockerExecute 
Pr/escape env values for docker execute
 2019-01-23 15:55:44 +01:00
Marcus HollandGitHub bad044731a Merge pull request #1 from fwilhe/pr/piper-api 
Mark classes used by s4sdk as API
 2019-01-23 15:03:23 +01:00
Marcus Holl ddc796b85d Better readable rule names: readJsonRule 2019-01-23 14:54:52 +01:00
Marcus Holl 9e56ebc724 Better readable rule names: dockerExecuteRule 2019-01-23 14:54:52 +01:00
Marcus Holl f81b83169a Better readable rule names: readFileRule 2019-01-23 14:54:52 +01:00
Marcus Holl e4c3228e25 Better readable rule names: writeJsonRule 2019-01-23 14:54:51 +01:00
Marcus Holl 7ba695e767 Better readable rule names: readJsonRule 2019-01-23 14:54:51 +01:00
Marcus Holl da1969e089 Better readable rule names: writeFileRule 2019-01-23 14:54:51 +01:00
Marcus Holl afa8889e9d Better readable rule names: errorRule 2019-01-23 14:54:51 +01:00
Marcus Holl 5c0abfdff8 Better readable rule names: readYamlRule 2019-01-23 14:54:51 +01:00
Marcus Holl 4e01b94458 Better readable rule names: dockerExecuteRule 2019-01-23 14:54:50 +01:00
Marcus Holl b486f32dc1 Better readable rule names: stepRule 2019-01-23 14:54:50 +01:00
Marcus Holl 9b1397e998 Better readable rule names: loggingRule 2019-01-23 14:54:50 +01:00
Marcus Holl 994e1f1692 Better readable rule names: shellRule 2019-01-23 14:54:49 +01:00
Marcus Holl 9bf38f9a76 Merge remote-tracking branch 'github/master' into HEAD 2019-01-23 14:26:30 +01:00
Marcus Holl 2330bfdcf4 Merge remote-tracking branch 'github/master' into HEAD 2019-01-23 12:34:25 +01:00
Marcus Holl c8c96f11e3 Escape blanks when contained in env values for docker 2019-01-18 15:48:58 +01:00
Marcus Holl dd8e09c527 Streamline flow control 
in order to avoid to have to escape at two locations in the code.
 2019-01-18 15:48:58 +01:00
Marcus HollandGitHub fe54b90af8 Merge pull request #446 from marcusholl/pr/organizeImports 
Remove unneeded imports for ConfigurationMerger, ConfigurationLoader
 2019-01-18 10:15:46 +01:00
Marcus Holl 303122c899 Remove unneeded imports for ConfigurationMerger, ConfigurationLoader 2019-01-18 09:36:16 +01:00
Marcus HollandChristoph Szymanski 49317ea852 Dock Introduce google group as communication channel (#435) 2019-01-18 09:34:03 +01:00
Marcus HollandGitHub bd86864c86 Merge pull request #422 from marcusholl/pr/generateDocuDuringBuild 
generate docu during build
 2019-01-18 09:07:45 +01:00
Marcus Holl c14567bf06 adjust location of createDocu script 2019-01-18 09:03:31 +01:00
Marcus Holl 6f59627551 Create file containing classpath into build dir 
and not into project root. With this appraoch the root folder get not
filled with temporary content.
 2019-01-18 08:57:54 +01:00
Marcus Holl e48cfa7a77 adapt generateDocu script for travis 2019-01-18 08:57:54 +01:00
Marcus Holl 760137058c Evaluate @GenerateDocumentation annotation. 2019-01-18 08:57:54 +01:00
Marcus Holl d681b42c00 Introduce @GenerateDocumentation annotation 2019-01-18 08:57:54 +01:00
Marcus Holl f81dc7b147 docu script classpath contains the built classes folder 
we do not have only groovy script, but also java files inside src folder.
Hence we should rely on the target/classes folder in order to see also the
compiled java classes, and not only the groovy scripts.
 2019-01-18 08:57:54 +01:00
Marcus Holl daaac272d6 Remove commented coding line 2019-01-18 08:57:54 +01:00
Marcus Holl c6500a7516 Relocate script files for generting documention 2019-01-18 08:57:54 +01:00
Marcus Holl 96d5184651 Remove hand crafted step descrption 2019-01-18 08:57:54 +01:00
Marcus Holl 7ac70e4c51 Streamline naming of parameter sections 2019-01-18 08:57:54 +01:00
Marcus Holl 89370b7a93 better text for step configuration section 2019-01-18 08:57:54 +01:00
Marcus Holl 669d91bcdd Provide more than one step via cli 
elements 2 until end are considered to be step names.

the first two elements denotes the folder containing the steps (vars) and
the folder containing the docu markdown files.
 2019-01-18 08:57:54 +01:00
Marcus Holl ab83e9f7b8 Generate docu during travis build (for checkChangeInDevelopment) 2019-01-18 08:57:54 +01:00
Marcus Holl 1ef91ce8a3 Parameters now generated during build 2019-01-18 08:57:54 +01:00
Marcus Holl d9c536e25a [fix] Required parameter is not labeled as required in case there is a default 
Otherwise the meaning of required is confusing.
 2019-01-18 08:57:54 +01:00
Marcus Holl d140a20bb4 [fix] script can only be passed via parameters 2019-01-18 08:57:54 +01:00
Marcus HollandChristoph Szymanski db5022a4ff New Scenario Step: SAP UI5 on SAP Cloud Platform (#388) 
This scenario builds a UI5 app and deploys it to SAP Cloud Platform (neo).
 2019-01-15 13:32:01 +01:00
Marcus HollandGitHub e7c73cabf9 Merge pull request #412 from marcusholl/pr/adjustMtaBuildTestToShellCallRule 
Adapt mta build test to JenkinsShellCallRule
 2018-12-19 13:26:56 +01:00
Marcus Holl d6372d5d96 Merge remote-tracking branch 'github/master' into HEAD 2018-12-19 13:18:00 +01:00
Marcus HollandGitHub ddd0cf8aae Merge pull request #418 from SAP/1084565-patch-1 
Typo in documentation
 2018-12-19 10:09:24 +01:00
Marcus Holl 05e4824268 Adapt paragraph dealing with API in readme. 2018-12-19 09:01:40 +01:00
Marcus Holl 6e0faa37ce Mark widely used method of ConfigurationHelper as API 
Just as basis for a discussion. Before merging we should check if there is any need to adjust the
methods first before declaring it as API so that they should remain stable.
 2018-12-17 09:25:03 +01:00
Marcus Holl a678429f42 Introduce API annotation. 2018-12-17 09:25:03 +01:00
Marcus HollandGitHub 5a142ec41f Merge pull request #384 from marcusholl/pr/moreLoggingAndFailfastInMtaBuild 
More logging and be failfast around mtaYamlFile
 2018-12-12 12:29:02 +01:00
Marcus Holl 0751eda1ee Merge remote-tracking branch 'github/master' into HEAD 2018-12-12 12:24:26 +01:00
Marcus Holl 45170e979e Adapt mta build test test JenkinsShellCallRule 
a lot of code can be replaced by configuring the JenkinsShellCallRule accordingly. At the time when
this test was provided there was not JenkinsShellCallRule ...
 2018-12-12 12:14:14 +01:00
Marcus HollandGitHub 06767438db Merge pull request #411 from marcusholl/JSCR-equals 
Implement hashCode/equals/toString for JenkinsShellCallRule
 2018-12-12 12:10:30 +01:00
Marcus Holl bf881bfc13 Merge remote-tracking branch 'github/master' into HEAD 2018-12-12 12:05:24 +01:00
Marcus Holl 51afc894e5 Implement hashCode/equals/toString for JenkinsShellCallRule 
* toString is helpful for troubleshooting during developing tests
* equals/hashCode are required in case somebody would like to register
  some responses again (e.g. register something valid almost all the time, and
  register something more specific for a certain test).
 2018-12-10 16:23:24 +01:00
Marcus HollandGitHub 5a6200f52c Merge pull request #379 from marcusholl/pr/removeReturnValueFromDocuForCheckChangeInDevelopment 
Remove return value from docu for step checkChangeInDevelopment
 2018-12-07 13:15:00 +01:00
Marcus Holl cc971190c9 Merge remote-tracking branch 'github/master' into HEAD 2018-12-07 13:04:51 +01:00
Marcus Holl 987584a28f Remove return value from docu for step checkChangeInDevelopment 2018-12-07 13:04:40 +01:00
Marcus HollandGitHub 0d2277cec7 Merge pull request #382 from marcusholl/pr/logMtaBuildCall 
Log mta call which get executed.
 2018-12-07 13:02:15 +01:00
Marcus Holl 6491cccc2d Merge remote-tracking branch 'github/master' into HEAD 2018-12-07 12:32:00 +01:00
Marcus HollandGitHub c5f97f63cf Merge pull request #408 from marcusholl/pr/updateMailRecipients 
Update mail recipients
 2018-12-07 12:30:36 +01:00
Marcus Holl f82267a680 Update mail recipients 2018-12-07 09:02:31 +01:00
Marcus HollandGitHub 42875a3840 Merge pull request #378 from marcusholl/pr/removeReturnValueFromDocuSimpleCases 
remove return value from docu simple cases
 2018-12-06 16:25:29 +01:00
Marcus Holl b64a98ab5e Merge remote-tracking branch 'github/master' into HEAD 2018-12-06 16:13:44 +01:00
Marcus HollandGitHub e731ddb82c Merge pull request #383 from marcusholl/pr/streamlineCodeInMtaBuild 
Streamline code: Inline variable in mtaBuild step
 2018-12-06 16:12:59 +01:00
Marcus Holl 2ccb9df408 Merge remote-tracking branch 'github/master' into HEAD 2018-12-06 15:58:35 +01:00
Marcus HollandGitHub 6560fcb31b Merge pull request #393 from marcusholl/pr/improveDocuGenerator 
Pr/improve docu generator
 2018-12-05 10:12:49 +01:00
Marcus HollandGitHub 64d7e88567 Merge pull request #405 from marcusholl/pr/noRedundancyWithStepName 
Use class name as STEP_NAME
 2018-12-03 13:27:47 +01:00
Marcus Holl 2b726d95b5 Merge remote-tracking branch 'github/master' into HEAD 2018-12-03 13:23:15 +01:00
Marcus HollandGitHub d13427d1d5 Merge pull request #404 from marcusholl/pr/fixOsSpecificRegexInTest 
[fix] Make regex in test Operating System independent.
 2018-11-29 10:06:38 +01:00
Marcus Holl b7468a7ae4 Step name is not a string literal anymore 
Having the step name always the same like the file name, which is in turn the class name is
redundant.
 2018-11-29 09:54:05 +01:00
Marcus Holl dc780b1248 [fix] Make regex in test Operating System independent. 
We searched for the slash, but on win like operating system we have of course a backslash.
 2018-11-28 11:52:37 +01:00
Marcus Holl 36a282a8f2 docu generator: script:this case code 2018-11-23 14:43:04 +01:00
Marcus Holl c9359b63a1 Support mandatory flag when generating docu 2018-11-23 14:43:04 +01:00
Marcus Holl b921aa8d2a [fix] load defaults 2018-11-23 09:21:14 +01:00
Marcus Holl ddbdc034fc Handle annotations without docu generator on call method 2018-11-20 16:53:00 +01:00
Marcus Holl 6333530c9d Insert newlines before param config layers table 2018-11-20 16:53:00 +01:00
Marcus Holl a84d91f6bf More logging and be failfast around mtaYamlFile 
- don't log a message and continue when it is clear that we cannot succeed
    together with error raised later during attempt not parse a non-existing
    file
  - More log output in order to clarify what happens with mta.yaml
 2018-11-13 09:23:26 +01:00
Marcus Holl 69058d0f80 Streamline code: Inline variable in mtaBuild step 2018-11-13 08:44:53 +01:00
Marcus Holl d1500dce00 Log mta call which get executed. 2018-11-13 08:40:45 +01:00
Marcus HollandGitHub 9c27fbadf1 Merge pull request #372 from marcusholl/pr/neoDeployDeprecatedOldConfigFramework 
neoDeploy deprecated old config framework
 2018-11-12 15:48:24 +01:00
Marcus Holl 5c4007180c Merge remote-tracking branch 'github/master' into HEAD 2018-11-12 13:11:54 +01:00
Marcus HollandGitHub 6833a1cf84 Merge pull request #375 from marcusholl/pr/switchOffGetBooleanCheck 
Disable check for Boolean.getBoolean()
 2018-11-12 12:31:37 +01:00
Marcus Holl cc52cbd274 Merge remote-tracking branch 'github/master' into HEAD 2018-11-12 12:17:22 +01:00
Marcus HollandGitHub 1663cee93a Merge pull request #298 from marcusholl/pr/transportRequestIDAlsoViaCPE 
transport request id also via cpe
 2018-11-12 10:19:41 +01:00
Marcus Holl 06aacffb56 Merge remote-tracking branch 'github/master' into HEAD 2018-11-12 09:39:12 +01:00
Marcus Holl 7446b1e93d Remove return value from step documentation 
In the meantime the steps do not have a return value anymore.
 2018-11-09 16:09:29 +01:00
Marcus Holl 79fc8b1b85 Improve naming step -> script 
We cannot say if it is a step, but it is a script, this is essential.
 2018-11-09 15:45:31 +01:00
Marcus Holl 6252b18e49 Remove cps annotation 
since otherwise we get executed not all the code. It returns too early.
 2018-11-09 15:45:31 +01:00
Marcus Holl 0bbbb56002 Do not hand over reference to step itself 
needs to be the reference as it is available by script
 2018-11-09 15:45:23 +01:00
Marcus Holl 8e7352cdb4 Adjust docu 
there is no return value anymore.
 2018-11-08 16:05:35 +01:00
Marcus Holl f48c8a038e Merge remote-tracking branch 'github/master' into HEAD 2018-11-08 15:58:26 +01:00
Marcus Holl d1e33d6b2f Disable check for Boolean.getBoolean() 
Is it IMO completly normal to use Boolean.getBoolean(./.).

What is stated in the rule description

  | It is often mistakenly used to attempt to read user input or parse

is not a cool reason for having that rule. With such an approach we
can knock out a lot of APIs which can be misunderstood. It is the
duty of the developer to understand the API s?he is using.

The alternate way would be

'Boolean.parseBoolean(System.getProperty('xxx'))'

which is not that convenient like Boolean.getBoolean('xxx').
 2018-11-08 13:57:49 +01:00
Marcus Holl 7063aa1249 set build to unstable in case old config framework is used. 
protected by feature flag (so we can test it manually already).
 2018-11-08 13:11:24 +01:00