Marcus Holl
d0d4cac75b
Assert that there is no git commit if there should be not commit intentionally ( #321 )
...
up to now only the mvn call for setting the version was asserted, but it was not asserted
whether or not there is a commit.
2018-10-02 08:53:21 +02:00
Marcus Holl
74609a75ae
Merge pull request #316 from marcusholl/pr/lessSh
...
[refactoring] Reduce number of sh calls
2018-10-01 12:40:24 +02:00
Marcus Holl
01b03f0df3
[refactoring] Reduce number of sh calls
2018-09-27 16:18:46 +02:00
Marcus Holl
ced73231fa
Merge pull request #204 from marcusholl/pr/configurationHelperRequiredParameterFailsLate
...
Report all missing mandatory parameters instead of only the first on
2018-09-27 11:21:00 +02:00
Marcus Holl
f14781d913
Report all missing mandatory parameters instead of only the first one
2018-09-27 11:13:47 +02:00
Marcus Holl
556c561bb6
Merge pull request #210 from marcusholl/pr/limitConfigurationHelperToBuilderPattern
...
Limit usage of ConfigurationHelper to the builder pattern
2018-09-27 08:49:26 +02:00
Marcus Holl
752993aefa
Merge remote-tracking branch 'github/master' into HEAD
2018-09-27 08:24:04 +02:00
Thorsten Duda
bf61b6ebd0
Merge pull request #313 from SAP/pr/fixsshmkdocs
...
create .ssh dir
2018-09-26 12:59:31 +02:00
Thorsten Duda
b7cbc4b763
Merge branch 'master' into pr/fixsshmkdocs
2018-09-26 12:55:49 +02:00
Thorsten Duda
2947125199
create .ssh dir
2018-09-26 12:54:55 +02:00
Thorsten Duda
09dfa67605
Merge pull request #312 from SAP/pr/fixsshmkdocs
...
added github.com to knownhosts
2018-09-26 12:46:15 +02:00
Thorsten Duda
91b37a3562
added github.com to knownhosts
2018-09-26 12:32:50 +02:00
Thorsten Duda
06d2b81900
Merge pull request #311 from SAP/pr/fixdocudeployment
...
change script persmission
2018-09-26 11:54:59 +02:00
Thorsten Duda
ffb6a996e3
Merge branch 'master' into pr/fixdocudeployment
2018-09-26 11:13:46 +02:00
Travis CI Publisher
da3581eecb
change script persmission
2018-09-26 11:12:21 +02:00
Thorsten Duda
4fa250b40b
Merge pull request #310 from SAP/pr/fixdocudeployment
...
fix docu deployment
2018-09-26 11:00:58 +02:00
Travis CI Publisher
5bbced1500
fix docu deployment
2018-09-26 10:52:30 +02:00
Thorsten Duda
df4e9c82ae
Merge pull request #307 from SAP/pr/fixmkdocs
...
fix mkdocs issue
2018-09-26 08:47:59 +02:00
Thorsten Duda
520b375fb5
changed moint point and workdir
2018-09-25 17:00:02 +02:00
Thorsten Duda
db5414618b
added gh-deploy step with docker
...
- gh-pages-deploy.sh removed and added the part into .travis.yml to be
able to call it via docker
2018-09-25 15:05:57 +02:00
Thorsten Duda
72f611c5c2
fix mkdocs issue
...
- introduced docker mkdocs build
- changed pages to nav in mkdocs.yml due to newer mkdocs version
2018-09-25 14:03:22 +02:00
Marcus Holl
c63e6e88c0
Merge pull request #297 from marcusholl/pr/returnTypeVoid
...
Pipeline steps are expected not to return a return value
2018-09-21 13:48:33 +02:00
Marcus Holl
14d1027323
Merge remote-tracking branch 'github/master' into HEAD
2018-09-21 13:44:54 +02:00
Marcus Holl
1802d0c15a
Merge pull request #280 from marcusholl/pr/libResourceAndReadYamlCloserToReality
...
Be more precise with libraryResource and read yaml in prepareDefaultV…
2018-09-21 13:37:10 +02:00
Marcus Holl
726b969682
Merge remote-tracking branch 'github/master' into HEAD
2018-09-21 13:33:42 +02:00
Marcus Holl
afca9ca9fc
Merge pull request #282 from marcusholl/pr/credentialsRule
...
Tests: make use of JenkinsCredentialsRule
2018-09-21 13:32:56 +02:00
Marcus Holl
9cd31e7236
Merge remote-tracking branch 'github/master' into HEAD
2018-09-21 13:27:29 +02:00
Marcus Holl
e2e6f5d401
Merge pull request #281 from marcusholl/defaultValueCacheInstanceLikeChecks
...
Make DefaultConfigurationCache instance checks more precise
2018-09-21 13:26:43 +02:00
Marcus Holl
f07b596c46
Merge remote-tracking branch 'github/master' into HEAD
2018-09-21 12:48:14 +02:00
Marcus Holl
4fbf9b1df5
Merge pull request #286 from marcusholl/pr/ReplaceGStrings
...
replace GStrings in configuration by correspoding java.lang.Strings
2018-09-21 12:46:51 +02:00
Marcus Holl
8a5685bae7
Merge remote-tracking branch 'github/master' into HEAD
2018-09-21 12:18:25 +02:00
Marcus Holl
f0820fa399
Merge remote-tracking branch 'github/master' into HEAD
2018-09-21 12:16:50 +02:00
Marcus Holl
0919f23ff1
Merge pull request #296 from marcusholl/pr/fixWrongLinkToContributionGuidelines
...
Fix not working link to contribution guidelines
2018-09-21 12:15:47 +02:00
Marcus Holl
dc1c57ccca
Merge remote-tracking branch 'github/master' into HEAD
2018-09-21 11:26:04 +02:00
Marcus Holl
9399588f5d
Merge pull request #300 from marcusholl/pr/moveGitUtilsMockToGitUtilsTestClass
...
Remove generic gitUtils from BasePiperTest
2018-09-21 11:25:19 +02:00
Marcus Holl
123ce3a603
Merge remote-tracking branch 'github/master' into HEAD
2018-09-21 11:20:14 +02:00
Marcus Holl
154750d98d
Merge pull request #301 from marcusholl/pr/noStashUnstashOutputWrittenByTests
...
Remove output to stdout from tests
2018-09-21 11:18:39 +02:00
Marcus Holl
42188d3a4f
Merge remote-tracking branch 'github/master' into HEAD
2018-09-21 11:13:07 +02:00
Marcus Holl
5b28c787ab
Merge pull request #304 from marcusholl/pr/fixMissingGettersAndSetters
...
Revert "Remove explict getters and setters from common pipeline envir…
2018-09-21 10:18:15 +02:00
Marcus Holl
341cb97c25
Revert "Remove explict getters and setters from common pipeline environment"
...
This reverts commit d22af0f9d4
.
2018-09-21 09:24:47 +02:00
Oliver Nocon
518a08bdb4
Update CONTRIBUTING.md
2018-09-19 09:25:40 +02:00
Marcus Holl
23af245ad9
Merge pull request #302 from marcusholl/pr/noExplictGetterAnDSettersInCommonPipelineEnvironment
...
Remove explict getters and setters from common pipeline environment
2018-09-19 09:13:21 +02:00
Marcus Holl
d22af0f9d4
Remove explict getters and setters from common pipeline environment
...
We get getters and setters generated automatically.
2018-09-17 16:51:13 +02:00
Marcus Holl
726fbe36ab
Limit usage of ConfigurationHelper to the builder pattern
...
it is the duty of the configuration helper to build a map
providing the configuration. Having facilites to use the
ConfigurationHelper as some kind of configuration registry
makes life more complicated.
2018-09-17 12:56:18 +02:00
Marcus Holl
657ccf7d91
Merge pull request #294 from marcusholl/pr/premoveDeclarationsOfPrepareObjectInterceptors
...
Remove not (really) needed declarations of prepareObjectInterceptors
2018-09-14 10:36:42 +02:00
thorstenwillenbacher
1420c8a5bd
Merge branch 'master' into pr/premoveDeclarationsOfPrepareObjectInterceptors
2018-09-14 10:12:26 +02:00
Marcus Holl
c1900f6ecd
Remove output to stdout from tests
...
In fact nobody reads it, but on some IDEs it is shown when tests are executed.
2018-09-14 09:08:52 +02:00
Marcus Holl
dc9ce9a732
Remove generic gitUtils from BasePiperTest
...
there is only one test class making use of it left. This test class is the
GitUtilsTest itself.
Hence moving this member downwards in the test class hierarchy into GitUtilsTest.
I doubt it makes sense to make use of a generic git utils mock somewhere else since this basically
means to test the GitUtils class in the conxtext of other examinees. For that there is no need.
The GitUtils class should be tested by the corresponding test class, but not in a transive manner
by other tests. For all other tests a specific git utils mock should be provided mocking the corresponding
method class. This is already the case today, otherwise we would have more test classes making use
of the generic git utils mock.
2018-09-13 16:01:35 +02:00
Marcus Holl
63cf375398
Pipeline steps are expected not to return a return value
2018-09-13 11:24:04 +02:00
Marcus Holl
2d29555811
Fix not working link to contribution guidelines
2018-09-13 11:09:24 +02:00