Christian Luttenberger
d2c420bfe7
Fix call issue to abap build framework ( #2108 )
...
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
2020-10-02 10:06:33 +02:00
Kevin Hudemann
08a5189f39
Update Cloud SDK stash settings and stage defaults ( #2105 )
...
This change updates and cleans up the Cloud SDK specific stash settings
and stage defaults.
2020-10-02 09:05:42 +02:00
Oliver Nocon
9354697525
fix : allow creation of Checkmarx projects ( #2106 )
2020-10-01 17:08:07 +02:00
Marcus Holl
75a35fb35a
Improve logging wrt the docker image used for launching piper-go ( #1578 )
...
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-10-01 16:27:50 +02:00
Oliver Nocon
911a88bd49
fortify: fix semver for pip ( #2104 )
2020-10-01 14:47:08 +02:00
Oliver Nocon
b506235398
detect: add parameter aliases ( #2099 )
...
* align parameters for Detect
* include feedback
* update generation and formatting
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
Co-authored-by: Daniel Kurzynski <daniel.kurzynski@sap.com>
2020-10-01 13:34:51 +02:00
Christopher Fenner
5eb4c9de29
refactor(sonar): align serverUrl with other steps ( #2090 )
...
Co-authored-by: Daniel Kurzynski <daniel.kurzynski@sap.com>
2020-10-01 11:45:14 +02:00
Daniel Kurzynski
265541354d
Archive debug report in piper post action stage ( #2101 )
2020-10-01 10:14:14 +02:00
Christian Luttenberger
7a028c4149
Refactor build framework steps ( #2068 )
...
* adding my steps
* messy step
* Update abapEnvironmentAssembly.go
* clean up
* change yaml
* corrections
* Update cloudFoundryDeploy.go
* update
* delete simulation step
* remove simulate
* Update PiperGoUtils.groovy
* Update PiperGoUtils.groovy
* Update CommonStepsTest.groovy
* add docu
* Update abapEnvironmentAssembly.md
* changes due to PR
* Update .gitignore
* b
* CV list
* Update abapEnvironmentAssembly.go
* testing with simulation
* Update abapEnvironmentAssembly.go
* remove simulation
* renaming
* Update mkdocs.yml
* moving service key to yaml and fixing code climate
* Update abapEnvironmentAssemblePackages.go
* Update abapEnvironmentAssemblePackages.go
* Update abapEnvironmentAssemblePackages.go
* Update abapEnvironmentAssemblePackages.go
* change input
* Update abapEnvironmentAssemblePackages.go
* change json tag
* fixed error handling
* documentation
* Update abapEnvironmentAssemblePackages.md
* Update abapEnvironmentAssemblePackages.md
* fixing code climate issues
* fixing code climate issues
* Update abapEnvironmentAssemblePackages.yaml
* fixing code climate issues
* Update abapEnvironmentAssemblePackages.yaml
* adding unittests
* adding unittests and improved logging
* yaml -> json
* change scope of cfServiceKeyName
* correct indentation
* Update CommonStepsTest.groovy
* maintain correct step order
* Move Connector to connector.go
* Refactor bfw with unit tests
* remove spaces
* CodeClimate Fix for unexported type
* ABAP BF - Adding Error Handling Unmarshal
* Revert Unmarshal
Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
Co-authored-by: Koerner <tilo.koerner@sap.com>
Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com>
2020-09-30 16:40:36 +02:00
Christopher Fenner
b16f0428e1
docs: make used library and binary name in samples exchangeable for custom steps ( #2092 )
...
* add code block type
* add parameters to hand in library and binary name
* use library and binary name parameters
* add test cases
* use yaml file to distintuish custom from regular steps
* add test case
2020-09-30 15:02:00 +02:00
Marcus Holl
93cac1a2f4
Clarify: transportRequestId can only be provided via signature ( #1378 )
...
Clarify: transportRequestId can only be provided via signature
2020-09-30 14:29:46 +02:00
Marcus Holl
bed3ec1e28
[refactoring] Avoid having simiar dockerExecuteOnKubernetes call twice. ( #2067 )
...
Having that like this increases maintainability.
2020-09-30 13:44:40 +02:00
Marcus Holl
0a17ed561e
make unstash work for parallel executions ( #2095 )
...
without 'int' in a 'for (i = 0; ...)' loop 'i' is
a global variable and the value gets inside some parallel
execution randomly incremented from the parallel threads.
Defining it with the keyword 'int' makes it a method local
variable which does not change its value 'randomly'.
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2020-09-30 13:10:40 +02:00
Stephan Aßmus
fc55d02230
Fix conditions for whitesourceExecuteScan ( #2097 )
2020-09-30 12:37:01 +02:00
tiloKo
61dfa9d3d9
AAKaaS check steps to run without prior PV input ( #2091 )
...
* adding my steps
* messy step
* Update abapEnvironmentAssembly.go
* clean up
* change yaml
* corrections
* Update cloudFoundryDeploy.go
* update
* delete simulation step
* remove simulate
* Update PiperGoUtils.groovy
* Update PiperGoUtils.groovy
* Update CommonStepsTest.groovy
* add docu
* Update abapEnvironmentAssembly.md
* changes due to PR
* Update .gitignore
* b
* CV list
* Update abapEnvironmentAssembly.go
* testing with simulation
* Update abapEnvironmentAssembly.go
* remove simulation
* renaming
* Update mkdocs.yml
* moving service key to yaml and fixing code climate
* Update abapEnvironmentAssemblePackages.go
* Update abapEnvironmentAssemblePackages.go
* Update abapEnvironmentAssemblePackages.go
* Update abapEnvironmentAssemblePackages.go
* change input
* Update abapEnvironmentAssemblePackages.go
* change json tag
* fixed error handling
* documentation
* Update abapEnvironmentAssemblePackages.md
* Update abapEnvironmentAssemblePackages.md
* fixing code climate issues
* fixing code climate issues
* Update abapEnvironmentAssemblePackages.yaml
* fixing code climate issues
* Update abapEnvironmentAssemblePackages.yaml
* adding unittests
* adding unittests and improved logging
* yaml -> json
* change scope of cfServiceKeyName
* correct indentation
* Update CommonStepsTest.groovy
* maintain correct step order
* AAKaaS Checks as First Step
* remove old coding
Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
Co-authored-by: Chris <42861202+bluesbrother84@users.noreply.github.com>
2020-09-30 10:30:53 +02:00
Srinikitha Kondreddy
4fec440030
Fix typo ( #2086 )
2020-09-30 09:35:36 +02:00
Florian Wilhelm
e8f49df6a3
Optionally use new go-based Whitesource step ( #2079 )
2020-09-30 08:56:16 +02:00
Sven Merk
58b6c04cd2
Update fortifyExecuteScan.go ( #2093 )
...
* Update fortifyExecuteScan.go
* Update fortifyExecuteScan.go
* Docs are lying
Checked the API which returns a status similar to that of artifact
* Update fortifyExecuteScan_test.go
2020-09-29 18:26:16 +02:00
Kevin Hudemann
b47e08781c
Remove absolute links from Cloud SDK docs section ( #2089 )
2020-09-29 14:23:46 +02:00
Oliver Nocon
19c1732826
Telemetry: report error category ( #2085 )
2020-09-29 13:49:40 +02:00
Stephan Aßmus
54ea3ed51a
whitesourceExecuteScan: bypass UA for mta, maven, npm and yarn ( #1879 )
...
Co-authored-by: Florian Wilhelm <florian.wilhelm02@sap.com>
2020-09-29 12:44:31 +02:00
Kevin Hudemann
e2aea73022
Preparation to switch to piperPipelineStageSecurity for Cloud SDK pipeline ( #2082 )
...
Updates containersMap, stash settings, stage defaults and legacy config settings.
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2020-09-29 12:25:57 +02:00
Kevin Hudemann
b3a5d1e55e
Update Cloud SDK documentation ( #2081 )
...
This change updates the Cloud SDK documentation with the changes of migrating to
the piperPipelineStageInit and update the legacy configuration settings accordingly.
In addition, it fixes the documentation of the step debugReportArchive and includes
it in the list of library steps.
2020-09-29 11:26:55 +02:00
Oliver Nocon
15b3957137
checkmarxExecuteScan: update error handling ( #2084 )
...
* checkmarxExecuteScan: update error handling
* Update cmd/checkmarxExecuteScan.go
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
* include PR feedback
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2020-09-29 09:23:31 +02:00
Christopher Fenner
b2e345f4dc
docs: add note about Jenkins credentials ( #2078 )
...
* add note about Jenkins credentials
* remove copy&paste issue
* Update parameters.go
2020-09-28 11:45:21 +02:00
Kevin Hudemann
80250ab2b9
Extend piperPipelineStageInit to support init of Cloud SDK ( #2062 )
...
This change adds necessary functionality to support initialization of
Cloud SDK pipelines. In addition, it adds the support to check the
pipeline configuration for legacy configuration parameters.
2020-09-28 10:44:56 +02:00
Kevin Hudemann
a075526d15
Extend piperPipelineStageSecurity to run detectExecuteScan step ( #2069 )
...
This change adds the detectExecuteScan step to the
piperPipelineStageSecurity.
2020-09-28 09:56:57 +02:00
Christopher Fenner
cd819f205e
use correct template library ( #2077 )
...
fixes #2073
2020-09-28 09:10:52 +02:00
Jakub Filak
48d7f33d45
doc: fix an invalid relative link ( #2070 )
2020-09-25 20:55:10 +02:00
Marcus Holl
fd568c9174
do not swallow exception triggered inside SWA handling ( #1839 )
...
* do not swallow exception triggered inside SWA handling
--> write it to the log
The real change is in src/com/sap/piper/Utils.groovy
All the changes in the tests are dealing with mocking the echo method
used in the Utils class mentioned above.
2020-09-24 13:47:20 +02:00
Srinikitha Kondreddy
75e696ad7b
Add steps for cf space creation and deletion ( #2049 )
...
* [wip] Add steps for cf spaces creation and deletion
* Add tests
* Add cf space creation groovy file
* Fix shell script
* Fix shell script
* Add cloudFoundryCreateSpace command to command line controller
* Fix format
* Add cloudFoundryDeleteSpace command to command line controller
* Refactor cloudFoundryDeleteSpace step
* Add cloudFoundryDeleteSpace groovy file
* Add missing test
* Fix tests
* Add docu for cloudFoundryCreateSpace step
* Add docu for cloudFoundryDeleteSpace step
* Code review changes
Co-authored-by: Marcus Holl <marcus.holl@sap.com>
2020-09-24 11:30:25 +02:00
Marcus Holl
55bba0ebbb
Vars handling centralized ( #1934 )
...
Vars file handling centralized
We have the same coding for handling varsf-files and vars. With that change we shift to having one common coding for that
2020-09-24 09:39:18 +02:00
Christopher Fenner
6999380ee3
chore(go): simplify code using gofmt -s ( #2065 )
2020-09-24 08:58:53 +02:00
Christopher Fenner
b219fb6514
fix(typo): found by misspell ( #2064 )
...
* fix typos in step yamls
* fix typos in go files
* regenerate step code
* fix typos in md files
* fix typos in groovy files
* fix further typos
2020-09-24 07:41:06 +02:00
Florian Wilhelm
d960b9f3a1
Improve docs on mtaBuild installArtifacts ( #2061 )
...
Based on https://github.com/SAP/jenkins-library/issues/2060
2020-09-23 16:19:59 +02:00
tiloKo
e9b7e5e6f8
AAKaaS Target Vector steps - Documentation update ( #2059 )
...
* adding my steps
* messy step
* Update abapEnvironmentAssembly.go
* clean up
* change yaml
* corrections
* Update cloudFoundryDeploy.go
* update
* delete simulation step
* remove simulate
* Update PiperGoUtils.groovy
* Update PiperGoUtils.groovy
* Update CommonStepsTest.groovy
* add docu
* Update abapEnvironmentAssembly.md
* changes due to PR
* Update .gitignore
* b
* CV list
* Update abapEnvironmentAssembly.go
* testing with simulation
* Update abapEnvironmentAssembly.go
* remove simulation
* renaming
* Update mkdocs.yml
* moving service key to yaml and fixing code climate
* Update abapEnvironmentAssemblePackages.go
* Update abapEnvironmentAssemblePackages.go
* Update abapEnvironmentAssemblePackages.go
* Update abapEnvironmentAssemblePackages.go
* change input
* Update abapEnvironmentAssemblePackages.go
* change json tag
* fixed error handling
* documentation
* Update abapEnvironmentAssemblePackages.md
* Update abapEnvironmentAssemblePackages.md
* fixing code climate issues
* fixing code climate issues
* Update abapEnvironmentAssemblePackages.yaml
* fixing code climate issues
* Update abapEnvironmentAssemblePackages.yaml
* adding unittests
* adding unittests and improved logging
* yaml -> json
* change scope of cfServiceKeyName
* correct indentation
* Update CommonStepsTest.groovy
* maintain correct step order
* TV step docu update
* TV step docu update #2
Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
Co-authored-by: Chris <42861202+bluesbrother84@users.noreply.github.com>
2020-09-23 14:57:45 +02:00
Christopher Fenner
54ff93233e
refactor(docs): separate step and docs generator ( #2033 )
...
* remove docs generator code from step-generator
* add docs generator to dedicated package
* add test cases
* add entry point for docs generation
* make output more readable
* remove dead code
2020-09-23 13:55:17 +02:00
Oliver Nocon
4d9d2e78d8
Add / update Jenkins credential descriptions ( #2058 )
2020-09-23 13:22:51 +02:00
Marcus Holl
da147b16ce
dockerExecuteOnKubernetes: Make container limits configurable ( #1993 )
...
dockerExecuteOnKubernetes: Make container limits configurable
2020-09-23 13:08:43 +02:00
Marcus Holl
c092ab0c28
support credentials for docker pull ( #1990 )
...
support credentials for docker pull
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
Co-authored-by: Florian Wilhelm <florian.wilhelm02@sap.com>
2020-09-23 11:50:57 +02:00
Marcus Holl
5e0402c345
Remove useless space from lockIdentifier ( #2057 )
...
the space does not contribute to the uniqueness of the lock
identifier. Hence the space should be removed.
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2020-09-23 11:19:32 +02:00
Alejandra Ferreiro Vidal
32fd89c664
allow multicloud deployment to run in current workspace ( #2031 )
...
* allow run in current workspace
* add documentation
* add tests
* apply review changes
Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
2020-09-23 10:33:18 +02:00
Marcus Holl
9e20e70050
Remove dockerExecute rule from dockerExecuteOnKubernetes unit test ( #1994 )
2020-09-23 09:27:42 +02:00
Sven Merk
c72020b7a5
fortifyExecuteScan: Clean and improve parameters ( #2050 )
...
* Fix PR feature
* Fix Fortify parameters
* Update resources/metadata/fortify.yaml
* Update resources/metadata/fortify.yaml
* Update resources/metadata/fortify.yaml
* Update resources/metadata/fortify.yaml
* Update resources/metadata/fortify.yaml
* Update resources/metadata/fortify.yaml
* Update descriptions
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
Co-authored-by: OliverNocon <oliver.nocon@sap.com>
2020-09-22 17:39:40 +02:00
Oliver Nocon
c8b1ffd654
checkmarxExecuteScan: fix PR project identification ( #2055 )
2020-09-22 14:39:34 +02:00
Sven Merk
4ae46823b1
Fix PR feature ( #2048 )
...
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-09-22 12:36:22 +02:00
Oliver Nocon
155a19147a
Fix error category for general config issue ( #2053 )
2020-09-22 07:49:34 +02:00
Oliver Nocon
940e9aa498
artifactPrepareVersion: fix error categorization ( #2047 )
...
* artifactPrepareVersion: fix error categorization
* Update artifactPrepareVersion.go
* Update artifactPrepareVersion.go
* Update cmd/artifactPrepareVersion.go
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2020-09-21 14:51:02 +02:00
Kevin Hudemann
fda932aff5
Add capabilities to check for breaking changes in config ( #2045 )
...
This change adds the capabilities to check if the user still uses legacy
configuration parameters and allows to fail the pipeline in the
piperPipelineStageInit in case incompatible configuration is found.
Thus, it is now possible to describe breaking changes in the
configuration with the use of a yaml resource file. In this file, one can
describe the changes in configuration, e.g., when a configuration parameter
was replaced or removed. A concrete example for such a file for the Cloud
SDK Pipeline is part of this PR.
2020-09-21 14:29:07 +02:00
Marcus Holl
83deefd645
Fix: Avoid newline at end of timestamp in mtaBuild step ( #2044 )
2020-09-21 09:14:48 +02:00
