1
0
mirror of https://github.com/google/comprehensive-rust.git synced 2024-12-15 22:37:28 +02:00
Commit Graph

921 Commits

Author SHA1 Message Date
Charisee Chiw
c22b35e426
Remove silenced warnings in book-library exercise (#388)
* Update book-library.md

* Update book-library.rs

* Apply suggestions from code review

Expanding the variable makes it ever-so-slightly easier to read.

---------

Co-authored-by: Martin Geisler <mgeisler@google.com>
2023-02-28 17:53:02 -08:00
Jooyung Han
1821a3fd12
Make i18n-helpers a requirement (#461)
* Make i18n-helpers a requirement

* Skip mdbook-gettext for mdbook-xgettext

* Gettext finds PO file based on `book.language`

* Update workflow

No need to set `preprocessor.gettext.po-file`.

---------

Co-authored-by: Jooyung Han <jooyung@google.com>
2023-02-28 22:05:09 +09:00
Jooyung Han
b65c30fb5f
Update Korean Translation. (#460)
* Resolve fuzzy items in Korean

* Add missing translation in Korean (visibility)

* Translate filesystem in Korean

* Update po/ko.po

Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>

* Update po/ko.po

Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>

* Update po/ko.po

Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>

---------

Co-authored-by: Jooyung Han <jooyung@google.com>
Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>
2023-02-27 23:14:52 +00:00
Martin Geisler
1feb94e02a
Take out unnecessary code from enum size slide (#309)
The slide is way too large to comfortable use in a classroom. Instead
of printing six lines of output, the instructor should carefully walk
through the different examples. That way we can take the course
participants with us through the explanations instead of simply
showing them the end result.
2023-02-27 17:42:46 +01:00
Adam MacBeth
b1b78a9672
Fix typo in string.md (#456)
* Fix typo in string.md

* Update src/std/string.md

---------

Co-authored-by: Martin Geisler <martin@geisler.net>
2023-02-27 13:37:08 +00:00
Steve Masterman
0562771ce0
Update variant-payloads.md (#459)
Fix typo
2023-02-27 13:19:32 +00:00
Charisee Chiw
e73b163d77
Add to speaker notes rc.md (#366)
* Update rc.md

* Fix wording and formatting

* Update rc.md

---------

Co-authored-by: Andrew Walbran <qwandor@google.com>
2023-02-27 02:05:01 +00:00
Jooyung Han
973e27a322
Cleanup Korean Translation (#458)
* s/블럭/블록

* Add missing translation for Korean

* Fix spacing in Korean

along with typos.

* Add missing msgstr in Korean

---------

Co-authored-by: Jooyung Han <jooyung@google.com>
2023-02-27 09:42:50 +09:00
Adam MacBeth
4690f19e8c
Fix typo in drop.md (#457) 2023-02-26 22:04:39 +00:00
Jooyung Han
98ec5c65af
Cosmetic refinement in Korean translation (#455)
* Add missing translation in Korean

* Cosmetic refinement of Korean translation

* typo
* spacing
* newlines
* `_text_` into `*text*` or `*text*`
* removed a few "translation note"(역주)

* Fix typo in Korean

---------

Co-authored-by: Jooyung Han <jooyung@google.com>
2023-02-25 01:34:27 +09:00
Martin Geisler
261bcfce3e
Show Markdown diff as unified diff (#454)
Also add nice colors to make things pretty.
2023-02-24 16:46:08 +01:00
Andrew Jones
db7a6044b4
Remove extraneous trailing parenthesis (#453)
The text currently looks like this:
> See the Rust Reference).

And should look like this:
> See the Rust Reference.

Closer #452
2023-02-24 16:27:24 +01:00
Jiyong Park
10e918d897
Revise the translation for Korean (#450)
* Run msgmerge --no-wrap --update po/ko.po po/messages.pot

* Be consistent with the line ending. For example, if the original text
ends with ":", so the translation is.

* Remove unnecessary newline characters

If a newline character is from the rendering of the source text, remove
it in the translated text.

* Fix the remaining inconsistencies on line ending chracters

* s/제너릭/제네릭/g

제네릭 seems to be the popular translation for "generic":

제너릭: 120K results
제네릭: 1M results

* s/트레이트/트레잇/g

트레잇 seems to be the popular translation for "trait" at least in the
Rust ecosystem. The Rust book also uses 트레잇.
https://rinthel.github.io/rust-lang-book-ko/appendix-08-glossary.html

* Revive the missing translations for the Translations section

* Resolve remaining fuzzy translations
2023-02-24 10:40:22 +09:00
Sandro Meier
07513b2b4e
Add fechu as owner to german translation (#451) 2023-02-23 13:57:04 +01:00
Charisee Chiw
60aa747aca
Add Speaker notes string.md (#368)
* Update string.md

* Update src/std/string.md

Co-authored-by: Martin Geisler <mgeisler@google.com>

* Update src/std/string.md

Co-authored-by: Martin Geisler <mgeisler@google.com>

* Update string.md

---------

Co-authored-by: Martin Geisler <mgeisler@google.com>
2023-02-22 18:01:07 +00:00
Alexey Sokolov
e616f66593
Clarify box (#448) 2023-02-22 16:08:50 +01:00
Charisee Chiw
bb3b17b6bd
Additional speaker notes for variant payloads (#200)
* Additional speaker notes for variant payloads

* Update variant-payloads.md

* Update variant-payloads.md
2023-02-22 15:00:45 +00:00
Charisee Chiw
3f6bd6aa14
Speaker Notes for Field Shorthand (#198)
* Speaker Notes for Field Shorthand

* Update field-shorthand.md
2023-02-22 14:55:29 +00:00
Charisee Chiw
8ee637d886
Lecture notes for Destructing Arrays (#266)
* Lecture notes for Destructing Arrays

* Update destructuring-arrays.md
2023-02-22 13:41:12 +01:00
Jooyung Han
c88738db02
Update Korean Translation (#444)
* Update Korean translation

* Apply --no-wrap for Korean translation

Use `--no-wrap` for Korean translation to avoid unnecessary diffs.

When updating ko.po,
`msgmerge --no-wrap --update po/ko.po po/messages.pot`

Poedit's settings:
- uncheck "line-wrapping"
- uncheck "keep old formatting"

Note that with these settings/options `msgstr` will be still
line-wrapped at `\n`.

---------

Co-authored-by: Jooyung Han <jooyung@google.com>
2023-02-20 16:02:20 +09:00
Jooyung Han
c885bbf2ee
Remove all fuzzy items in Korean translation (#433)
* Remove all fuzzy items in Korean translation

* Apply grammar fixes in Korean Translation

of #440, #441

---------

Co-authored-by: Jooyung Han <jooyung@google.com>
2023-02-20 10:05:18 +09:00
Eunsu(Daniel) Kim
582500b0b2
Fix a typo (#443) 2023-02-19 20:17:30 +09:00
Eunsu(Daniel) Kim
9a31c2e5e5
Fix a typo (#442) 2023-02-19 17:29:16 +09:00
Adam MacBeth
9bb586689a
Minor grammar fixes to type-inference.md (#437) 2023-02-19 09:27:56 +01:00
Adam MacBeth
e6d6ee28fe
Update move-semantics.md (#438) 2023-02-19 09:27:41 +01:00
Adam MacBeth
aef4c3ca72
Update example.md (#441) 2023-02-19 04:53:11 +00:00
Adam MacBeth
9510e80165
Update receiver.md (#440) 2023-02-19 04:52:41 +00:00
Hugo Drumond Jacob
df2c773652
More polishing on the pt-BR translation (#425)
* More polishing on the pt-BR translation

* Fix translation to make code compile

This was tested with `mdbook test` from
https://github.com/rust-lang/mdBook/pull/1986.

---------

Co-authored-by: Martin Geisler <mgeisler@google.com>
2023-02-17 16:55:59 +01:00
Jooyung Han
b6a55e419c
svgbob should run after gettext (#429)
svgbob translates `_text_` into `*text*`, which makes gettext fail to
translate paragraphs with `_text_`.

Co-authored-by: Jooyung Han <jooyung@google.com>
2023-02-17 16:49:34 +01:00
Jooyung Han
00edafbf77
Update Korean translation and resolve some fuzzy marks (#431)
* Update Korean translation with latest English

- mdbuild build
- msgmerge --update
- poedit

* Resolve some fuzzy marks

and also add Korean translation for translations.md.

---------

Co-authored-by: Jooyung Han <jooyung@google.com>
2023-02-17 18:38:35 +09:00
Jiyong Park
92d00f2fd4
Fix typo: patten -> pattern (#430) 2023-02-17 18:34:35 +09:00
Jiyong Park
eb57ba9e51
Publish Korean translation (#428)
* Publish Korean translation

* 한국어 -> 한국어 (Korean)

* Add translator names for the Korean translation
2023-02-17 17:58:33 +09:00
Jooyung Han
a6bbd1e64e
links should run before gettext (#421)
fixes #419

Co-authored-by: Jooyung Han <jooyung@google.com>
2023-02-17 09:56:51 +09:00
Jiyong Park
11ef0d3e49
Refine Korean translation for Day 3 afternoon (#422)
* Refine ko-translation for Day 3 afternoon

* Address comments from Jooyung
2023-02-17 09:28:51 +09:00
Andrew Jones
9a4cda6f35
Fix references within options returned from Args (#427)
This fixes #426
2023-02-16 21:54:18 +00:00
Martin Geisler
5c03394b31
Lock mdbook and mdbook-svgbob version numbers (#398)
This will help avoid breakage[1] when mdbook and mdbook-svgbob are out
of sync with each other.

[1]: https://github.com/boozook/mdbook-svgbob/issues/25.
2023-02-16 13:39:19 +01:00
Martin Geisler
bc2dbd0fd3
Add a page which mentions the translations (#424)
This is to help people discover the language picker.
2023-02-16 13:21:45 +01:00
Hugo Drumond Jacob
6edc5b1155
pt-BR.po: fine tuning (#418)
* pt-BR.po: fine tuning for slide #1

* pt-BR.po: orador -> instrutor

Orador is a person who speaks to the public while instrutor is literally a trainer.
2023-02-16 11:48:26 +00:00
Jiyong Park
057d50a3bc
Refine ko-translation for Day 3 morning (#420) 2023-02-16 16:40:54 +09:00
gendx
29b6b90bfc
Add example where breaking UTF-8 encoding leads to a crash. (#387) 2023-02-16 03:19:44 +00:00
Marko Zagar
fe21b773e7
Day2: Afternoon - speaker note details and minor cosmetic changes. (#408)
* A few speaker notes in Day2: Afternoon and minor cosmetic changes.

* Do not test filesystem example code block.
2023-02-16 03:19:25 +00:00
Jooyung Han
93d61b2e7d
Apply latest English changes to the Korean translation (#413)
* Applies en changes to ko.

$ MDBOOK_OUTPUT='{"xgettext": {"pot-file": "messages.pot"}}' mdbook build -d po
$ msgmerge --update po/ko.po po/messages.pot
$ poedit po/ko.po (with "save")

* Add missing translation(ko) for `Default` trait.

* Resolve some "fuzzy" translations (ko)

* Fix formatting in <details> of lifetimes-data-structures.md (ko)

---------

Co-authored-by: Jooyung Han <jooyung@google.com>
2023-02-16 02:36:45 +00:00
Martin Geisler
f16b41f012
Further simplify Box diagrams (#409)
* Further simplify `Box` diagrams

I think we can improve the drawing by simplifying them and making them
more symbolic. Followup to #374.

* Apply suggestions from code review
2023-02-15 18:10:50 +00:00
Martin Geisler
14b5e86579
Fix links in language picker (#417)
When the current page is not `en`, we need to add an additional `../`
to the path to reach the top of the site.
2023-02-15 18:59:58 +01:00
rastringer
747589ae8c
Fixing mistranslation in match statement (#416) 2023-02-15 18:07:58 +01:00
Martin Geisler
3b7123d21a
Add language picker menu (#411)
The picker is a drop-down menu using the same design as the theme
picker in the top-left.

There doesn’t seem to be an easy way to pass in a list of languages
and descriptions, so for now we’ll have to expand the menu by hand as
we add new languages. A comment has been added to `publish.yml` to
remind us of this.
2023-02-15 15:10:16 +01:00
Jan Wilken Dörrie
8e4bf245d3
Add Too Many Lists book to other resources (#410)
As suggested by @mgeisler in https://news.ycombinator.com/item?id=34092980. Wording taken from https://github.com/rust-unofficial/awesome-rust#resources.
2023-02-14 21:25:06 +00:00
Charisee Chiw
2436560e40
Let user know they can modify the tests, but do not need to. (#401) 2023-02-14 12:28:22 -08:00
Charisee Chiw
c06709838f
Update visibility.md (#403) 2023-02-14 12:24:32 -08:00
Charisee Chiw
cd79cc41a3
Remove code markers for compiler message (#402)
Follow up on comment in merged PR #360, working on issue #274
2023-02-14 20:22:49 +00:00