Michael Niedermayer
679a315424
avformat/oggparsedaala: Check duration for AV_NOPTS_VALUE
...
This avoids an integer overflow
the solution matches oggparsevorbis.c and 45581ed15d
Fixes: 700242
Found-by: Thomas Guilbert <tguilbert@google.com >
Reviewed-by: Rostislav Pehlivanov <atomnuker@gmail.com >
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-04-01 22:09:23 +02:00
Michael Niedermayer
58b867a7cf
Bump minor versions for master after release/3.3 branchpoint
...
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-31 13:21:06 +02:00
Michael Niedermayer
fc332f3e29
Bump minor versions for staring release/3.3 branch
...
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-31 13:21:06 +02:00
Michael Niedermayer
1317a9f7aa
doc/APIchanges: Update
2017-03-31 13:21:06 +02:00
Michael Niedermayer
55d53cb593
avfilter/avfiltergraph: Check for allocation failure in avfilter_graph_queue_command()
...
Fixes: CID1396538
Reviewed-by: Paul B Mahol <onemda@gmail.com >
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-31 12:28:58 +02:00
Michael Niedermayer
5036e214b0
avfilter/vf_zoompan: Free out frame on error
...
Fixes: CID1398578
Reviewed-by: Paul B Mahol <onemda@gmail.com >
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-31 12:28:58 +02:00
Michael Niedermayer
c217027c11
avcodec/mips: fix build
...
Found-by: Shivraj Patil <shivraj.patil@imgtec.com >
Suggested-by: "Ronald S. Bultje" <rsbultje@gmail.com >
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-31 12:28:58 +02:00
Michael Niedermayer
afebf470ca
avutil/tests/dict: Check return of av_dict_parse_string()
...
Fixes: CID1396402
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-30 23:35:18 +02:00
Michael Niedermayer
77a3c288bd
avformat/mov: Init ref_sc / ref_st to NULL
...
This is more robust in case some change or corner case causes them to be
dereferenced before being set
Fixes CID1396274, CID1396275
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-30 23:35:18 +02:00
Michael Niedermayer
bd8201566d
avformat/libopenmpt: Check for avio_size() failure
...
Fixes CID1396850
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-30 23:35:18 +02:00
Michael Niedermayer
477ba8f939
avfilter/af_chorus & aecho: Handle NULL return from av_strtok()
...
Fixes CID1396260
Reviewed-by: Paul B Mahol <onemda@gmail.com >
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-30 23:35:18 +02:00
Michael Niedermayer
fe46d92c15
avcodec/clearvideo: Do not lose the return code of decode_mb()
...
Fixes CID1401671
Reviewed-by: Paul B Mahol <onemda@gmail.com >
Reviewed-by: Nicolas George <george@nsup.org >
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-30 23:35:18 +02:00
Michael Niedermayer
855305fac2
avfilter/vf_minterpolate: Use dx and dy
...
Fixes CID1396283 and CID1396284
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-30 22:46:31 +02:00
Michael Niedermayer
4798237f01
avfilter/deshake_opencl: Remove redundant return
...
Fixes: CID1396846
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-30 22:46:31 +02:00
Michael Niedermayer
4064f3f0df
avfilter/af_sofalizer: Fix bad shift
...
Fixes CID1396835
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-30 22:46:31 +02:00
Michael Niedermayer
e976e68fc5
avcodec/atrac3: Check init_get_bits8() for failure
...
This is more for correctness than actually fixing a missing error path
Fixes CID1399967
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-30 22:13:38 +02:00
Michael Niedermayer
59b8c2a4e6
doc/examples/encode_audio: Favor a sample rate close to 44khz instead of the maximum sample rate
...
This is an example, people will copy and use this. The maximum supported is quite
unreasonable as a default choice
Reviewed-by: Steven Liu <lingjiujianke@gmail.com >
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-30 16:34:06 +02:00
Michael Niedermayer
004f27f0fb
ffmpeg: Fix avframe memleak
...
Fixes CID1401674
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-30 16:34:06 +02:00
Michael Niedermayer
8779ec91b2
avformat/mux: Check return code of av_packet_split_side_data()
...
Fixes CID1403225
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-30 16:30:14 +02:00
Michael Niedermayer
ad7aff0355
tests/fate/source-check: Use git grep in place of grep
...
grep -L is not posix, solaris default grep does not support it
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-30 03:12:05 +02:00
Michael Niedermayer
5f019909c0
avfilter: Add AV_OPT_FLAG_FILTERING_PARAM where it is missing
...
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-30 03:12:05 +02:00
Michael Niedermayer
bcd7153df3
ffprobe: Support adding av_log output to frames
...
adding demuxer and other logs should be easy
This forces single threaded decoding for simplicity
It also requires pthreads, this could be avoided either with
some lockless tricks or simply by assuming av_log would never be called from
another thread.
Fixes Ticket5521
Previous version reviewed by Stefano
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-28 00:13:47 +02:00
Michael Niedermayer
d65b59550b
avcodec/avcodec: Correct and make consistent AVERROR() in comments
...
Reviewed-by: "Ronald S. Bultje" <rsbultje@gmail.com >
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-27 01:48:39 +02:00
Michael Niedermayer
eaf6f10f1b
avfilter/vf_signature: Replace uncommon spelling of seperate
...
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-26 20:34:47 +02:00
Michael Niedermayer
0ba22831e1
avcodec/h264idct_template: Fix multiple runtime error: signed integer overflow
...
Fixes: 712/clusterfuzz-testcase-6647676227551232
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-26 19:17:30 +02:00
Michael Niedermayer
73fb40dc87
avcodec/x86/idctdsp: Remove duplicate include
...
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-26 19:17:30 +02:00
Michael Niedermayer
9dd1573423
doc/bitstream_filters: Fix project name after merge
...
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-26 19:17:30 +02:00
Michael Niedermayer
d92ad42fb3
avcodec/tests/celp_math: Change IsAlmostEqual() to a function
...
Fixes empty statement, found by ubitux
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-24 18:18:57 +01:00
Michael Niedermayer
4f727fbc73
avcodec/h264_ps: Fix runtime error: signed integer overflow: 2147483647 + 26 cannot be represented in type 'int'
...
Fixes: 902/clusterfuzz-testcase-4561155144024064
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Reviewed-by: "Ronald S. Bultje" <rsbultje@gmail.com >
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-23 15:25:48 +01:00
Michael Niedermayer
0f34c0789f
avcodec/pictordec: runtime error: left shift of 15 by 28 places cannot be represented in type 'int'
...
Fixes: 898/clusterfuzz-testcase-6149765467209728
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-23 15:25:48 +01:00
Michael Niedermayer
3182e19c1c
avcodec/tiff: Check geotag count for being non zero
...
Fixes memleak
Fixes: 874/clusterfuzz-testcase-5252796175613952
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-23 15:25:48 +01:00
Michael Niedermayer
423375d4f0
avcodec/wavpack: Check shift
...
Fixes: runtime error: shift exponent 255 is too large for 32-bit type 'unsigned int'
Fixes: 894/clusterfuzz-testcase-4841537823309824
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-21 20:54:27 +01:00
Michael Niedermayer
b15818642b
avcodec/mpegaudiodec_template: Fix 2 runtime error: signed integer overflow
...
Fixes: 873/clusterfuzz-testcase-5714546230558720
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-21 20:52:08 +01:00
Michael Niedermayer
23f3f92361
avcodec/mjpegdec: quant_matrixes can be up to 65535, use uint16_t
...
Fixes invalid shift
Fixes: 870/clusterfuzz-testcase-5649105424482304
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-20 01:38:04 +01:00
Michael Niedermayer
656a17e126
avcodec/mjpegdec: Check quant_matrixes values for being non zero
...
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-20 01:38:02 +01:00
Michael Niedermayer
98da63b3f5
avcodec/vp56: Check avctx->error_concealment before enabling EC
...
Fixes timeout with 847/clusterfuzz-testcase-5291877358108672
Fixes timeout with 850/clusterfuzz-testcase-5721296509861888
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-20 01:33:08 +01:00
Michael Niedermayer
a84d610b37
avcodec/h264_direct: Fix runtime error: signed integer overflow: -9 - 2147483647 cannot be represented in type 'int'
...
Fixes: 864/clusterfuzz-testcase-4774385942528000
See: [FFmpeg-devel] [PATCH 1/2] avcodec/h264_direct: Fix runtime error: signed integer overflow: 2147483647 - -14133 cannot be represented in type 'int'
See: [FFmpeg-devel] [PATCH 2/2] avcodec/h264_direct: Fix runtime error: signed integer overflow: -9 - 2147483647 cannot be represented in type 'int'
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-20 01:33:08 +01:00
Michael Niedermayer
5d996b5649
avcodec/tiff: Check stripsize strippos for overflow
...
Fixes: 861/clusterfuzz-testcase-5688284384591872
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-20 01:33:08 +01:00
Michael Niedermayer
a3a4082599
avcodec/h264_cabac: Fix runtime error: negation of -2147483648 cannot be represented in type 'int'; cast to an unsigned type to negate this value to itself
...
Fixes: 858/clusterfuzz-testcase-5168477042114560
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-16 16:16:05 +01:00
Michael Niedermayer
2898bc522d
avcodec/h264idct_template: fix multiple runtime error: signed integer overflow
...
Fixes: 857/clusterfuzz-testcase-5319093760557056
Benchmark changes from 335->333 (so if its not a random fluctuation then it would be faster)
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-16 16:16:05 +01:00
Michael Niedermayer
cfa10e11be
avcodec/tiff: Check palette shift
...
Fixes multiple runtime error: shift exponent 792 is too large for 32-bit type 'unsigned int'
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-16 01:04:35 +01:00
Michael Niedermayer
58e9c7f4a2
avcodec/wavpack: Fix multiple integer overflows
...
Fixes: 839/clusterfuzz-testcase-4871084446842880
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-16 01:04:35 +01:00
Michael Niedermayer
45198477de
avcodec/simple_idct_template: Fix several integer overflows
...
Benchmarks with START_TIMER indicate that the code is faster with unsigned, (that is
with the patch), there was quite some fluctuation in the numbers so this may be just
random
Fixes: 811/clusterfuzz-testcase-6465493076541440
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-16 01:04:35 +01:00
Michael Niedermayer
8ebed703f1
avcodec/mpegaudiodec_template: Make l3_unscale() work with e=0
...
Fixes undefined behavior
Fixes: 830/clusterfuzz-testcase-6253175327686656
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-14 22:48:49 +01:00
Michael Niedermayer
108b02e547
avcodec/tiff: Check for multiple geo key directories
...
Fixes memleak
Fixes: 826/clusterfuzz-testcase-5316921379520512
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-14 22:48:49 +01:00
Michael Niedermayer
0728d9a281
avcodec/pictordec: Fix runtime error: left shift of 805306368 by 2 places cannot be represented in type 'int'
...
Fixes: 823/clusterfuzz-testcase-6727060074528768
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-14 22:48:49 +01:00
Michael Niedermayer
7cebc5a9cc
avcodec/wavpack: Fix runtime error: shift exponent 32 is too large for 32-bit type 'int'
...
Fixes: 822/clusterfuzz-testcase-4873433189974016
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-14 02:23:50 +01:00
Michael Niedermayer
acdacb108d
avcodec/targa: Skip hflip on blank images
...
Fixes: timeout with 810/clusterfuzz-testcase-5249282825256960
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-14 02:23:50 +01:00
Michael Niedermayer
1467143a6e
avcodec/wavpack: Fix runtime error: shift exponent 137 is too large for 32-bit type 'int'
...
Fixes: 808/clusterfuzz-testcase-4715513349406720
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-14 02:23:50 +01:00
Michael Niedermayer
a557ae8d52
avcodec/h264_direct: Fix runtime error: signed integer overflow: 2147483647 - -14133 cannot be represented in type 'int'
...
Fixes: 755/clusterfuzz-testcase-5369072516595712
See: [FFmpeg-devel] [PATCH 1/2] avcodec/h264_direct: Fix runtime error: signed integer overflow: 2147483647 - -14133 cannot be represented in type 'int'
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-14 02:23:50 +01:00
Michael Niedermayer
967feea5eb
avcodec/vp6: clear dimensions on failed resolution change in vp6_parse_header()
...
Fixes: 807/clusterfuzz-testcase-6470061042696192
Fixes null pointer dereference
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-13 04:48:43 +01:00
Michael Niedermayer
a66c6e28b5
avcodec/rv34: Fix runtime error: signed integer overflow: 36880 * 66288 cannot be represented in type 'int'
...
Fixes: 768/clusterfuzz-testcase-4807444305805312
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-13 04:48:43 +01:00
Michael Niedermayer
a720b854b0
avcodec/mpeg12dec: Fix runtime error: left shift of negative value -1
...
Fixes: 764/clusterfuzz-testcase-6273034652483584
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-13 04:48:43 +01:00
Michael Niedermayer
ce010655a6
avcodec/dca_xll: Fix runtime error: signed integer overflow: 2147286116 + 6298923 cannot be represented in type 'int'
...
Fixes: 732/clusterfuzz-testcase-4872990070145024
See: [FFmpeg-devel] [PATCH 2/6] avcodec/dca_xll: Fix runtime error: signed integer overflow: 2147286116 + 6298923 cannot be represented in type 'int'
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-12 04:38:14 +01:00
Michael Niedermayer
44e2105189
avcodec/amrwbdec: Fix runtime error: left shift of negative value -1
...
Fixes: 763/clusterfuzz-testcase-6007567320875008
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-12 04:38:14 +01:00
Michael Niedermayer
f4c2302ee2
avcodec/dca_xll: Fix runtime error: signed integer overflow: 1762028192 + 698372290 cannot be represented in type 'int'
...
Fixes: 762/clusterfuzz-testcase-5927683747741696
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-12 04:38:14 +01:00
Michael Niedermayer
47cc9c1d77
avcodec/wavpack: Fix runtime error: signed integer overflow: -2147483648 + -83886075 cannot be represented in type 'int'
...
Fixes: 761/clusterfuzz-testcase-5442222252097536
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-12 04:38:14 +01:00
Michael Niedermayer
6e913f2129
avcodec/vp56: Reset have_undamaged_frame on resolution changes
...
Fixes: timeout in 758/clusterfuzz-testcase-4720832028868608
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-11 02:50:22 +01:00
Michael Niedermayer
dc0b9b218c
avcodec/h264_ps: Forward errors from decode_scaling_list()
...
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-11 02:50:22 +01:00
Michael Niedermayer
bac9c03ed9
avcodec/movtextdec: run mov_text_cleanup() before overwriting pointers
...
Fixes: memleak
Fixes: 741/clusterfuzz-testcase-586996200452915
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-09 23:28:10 +01:00
Michael Niedermayer
e2a4f1a9eb
avcodec/mpeg4videodec: Fix runtime error: signed integer overflow: -135088512 * 16 cannot be represented in type 'int'
...
Fixes: 736/clusterfuzz-testcase-5580263943831552
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-09 23:28:10 +01:00
Michael Niedermayer
222c9f031d
avcodec/h264_mvpred: Fix runtime error: left shift of negative value -1
...
Fixes: 734/clusterfuzz-testcase-4821293192970240
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-09 23:28:10 +01:00
Michael Niedermayer
800d02abe0
avcodec/mjpegdec: Fix runtime error: left shift of negative value -127
...
Fixes: 733/clusterfuzz-testcase-4682158096515072
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-09 23:28:10 +01:00
Michael Niedermayer
58dd25f8ad
avcodec/mpegaudiodec_template: Check for negative e
...
Fixes: undefined shift
Fixes: 631/clusterfuzz-testcase-6725491035734016
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-09 20:37:10 +01:00
Michael Niedermayer
3016e919d4
avcodec/wavpack: Fix runtime error: left shift of negative value -5
...
Fixes: 729/clusterfuzz-testcase-5154831595470848
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-08 21:15:07 +01:00
Michael Niedermayer
01a33b835f
avcodec/pictordec: Fix runtime error: left shift of 64 by 25 places cannot be represented in type 'int'
...
Fixes: 724/clusterfuzz-testcase-6738249571631104
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-08 21:15:07 +01:00
Michael Niedermayer
1d0bad421c
avutil/tests/lfg: Remove debugging start/stop timer
...
Fixes code with qemu ARM
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-08 14:32:00 +01:00
Michael Niedermayer
1afd246960
avcodec/vp8: Check for the bitstream end per MB in decode_mb_row_no_filter()
...
Fixes: timeout in 730/clusterfuzz-testcase-5265113739165696 (part 2 of 2)
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Reviewed-by: BBB
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-07 21:29:43 +01:00
Michael Niedermayer
55d7371fe0
avcodec/vp568: Check that there is enough data for ff_vp56_init_range_decoder()
...
Fixes: timeout in 730/clusterfuzz-testcase-5265113739165696 (part 1 of 2)
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Reviewed-by: BBB
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-07 21:29:12 +01:00
Michael Niedermayer
5098a6f627
avcodec/vp8: remove redundant check
...
Reviewed-by: Paul B Mahol <onemda@gmail.com >
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-07 19:13:19 +01:00
Michael Niedermayer
8aa4f3bb4f
avcodec/proresdec2: Do not discard frames with bad slices
...
The code previously completely discarded frames that had any error in a slice
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-06 16:47:17 +01:00
Michael Niedermayer
835d9f299c
avcodec/x86/cavsdsp: Put MMX code under mmx check
...
Without this the FPU state becomes trashed and causes mysterious
fate failures with cpuflags=0
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-06 16:47:17 +01:00
Michael Niedermayer
a9f9b7f5c7
avcodec/movtextdec: Call mov_text_cleanup() on close
...
Fixes memleak
Fixes: 548/clusterfuzz-testcase-5511470875934720
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-06 16:47:17 +01:00
Michael Niedermayer
ba15005132
avcodec/wavpack: Fix runtime error: left shift of negative value -2
...
Fixes: 723/clusterfuzz-testcase-6471394663596032
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-05 12:03:15 +01:00
Michael Niedermayer
29638d4db9
avcodec/dcadsp: Fix 2 runtime error: signed integer overflow: -1958094138 - 1078906344 cannot be represented in type 'int'
...
Fixes: 722/clusterfuzz-testcase-5711268868521984
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-05 12:01:48 +01:00
Michael Niedermayer
d03d386162
avcodec/wavpack: Check bitrate_acc for overflow
...
Fixes: undefined behavior in 717/clusterfuzz-testcase-5434924129583104
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-05 12:01:46 +01:00
Michael Niedermayer
fab13bbbcd
avcodec/mpeg4videodec: Fix runtime error: signed integer overflow: 134527392 * 16 cannot be represented in type 'int'
...
This checks the sprite delta intermediates for overflow
Fixes: 716/clusterfuzz-testcase-4890287480504320
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-05 12:01:41 +01:00
Michael Niedermayer
d757ddbaab
avcodec/mpeg12dec: Fix runtime error: left shift of negative value -13
...
Fixes: 709/clusterfuzz-testcase-4789836449841152
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-04 17:48:04 +01:00
Michael Niedermayer
ab998f4c7f
avcodec/h264_mvpred: Fix multiple runtime error: left shift of negative value
...
Fixes: 710/clusterfuzz-testcase-5091051431788544
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-04 17:48:04 +01:00
Michael Niedermayer
d23727e042
avcodec/adxdec: Fix runtime error: left shift of negative value -1
...
Fixes: 705/clusterfuzz-testcase-5129572590813184
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-04 17:48:04 +01:00
Michael Niedermayer
eb41956636
avcodec/mpeg4videodec: Improve the overflow checks in mpeg4_decode_sprite_trajectory()
...
Also clear the state on errors
Fixes integer overflows in 701/clusterfuzz-testcase-6594719951880192
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-04 03:05:15 +01:00
Michael Niedermayer
2ce4f28431
avcodec/vp56: Require a correctly decoded frame before using vp56_conceal_mb()
...
Fixes timeout with 700/clusterfuzz-testcase-5660909504561152
Fixes timeout with 702/clusterfuzz-testcase-4553541576294400
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-04 03:05:15 +01:00
Michael Niedermayer
d8094a303b
avcodec/vp3: Do not return random positive values but the buf size
...
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-03 17:17:53 +01:00
Michael Niedermayer
55196e5d10
Revert "avutil/frame: Disallow zero sized frame side data"
...
Found a case where we use size==0, the other related commits
remain needed, and should be sufficient to fix the original issue
This reverts commit 7e4f32f4e4 .
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-03 01:03:29 +01:00
Michael Niedermayer
6191198c21
avcodec/interplayvideo: Fix timeout from lack of bitstream end check
...
Fixes: 697/clusterfuzz-testcase-6111250582863872
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-03 01:03:29 +01:00
Michael Niedermayer
3b0b35150d
avcodec/mpegaudiodec_template: Fix runtime error: signed integer overflow: 2053224902 + 2053224902 cannot be represented in type 'int'
...
Fixes: 696/clusterfuzz-testcase-5853632270434304
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-03 01:03:29 +01:00
Michael Niedermayer
4b72d5cd6f
avcodec/mjpegdec: Fix runtime error: left shift of negative value -511
...
Fixes: 693/clusterfuzz-testcase-6109776066904064
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-03 01:03:29 +01:00
Michael Niedermayer
4bed066377
avcodec/vp56: Clear dimensions in case of failure in the middle of a resolution change
...
Similar code is used elsewhere in vp56 to force a more complete reinit in the future.
Fixes null pointer dereference
Fixes: 707/clusterfuzz-testcase-4717453097566208
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-02 03:16:18 +01:00
Michael Niedermayer
f8060ab927
avcodec/wavpack: Check value before shift in wp_exp2()
...
Fixes undefined shift, all callers should be changed to check the value
they use with wp_exp2() or its return value.
Fixes: 692/clusterfuzz-testcase-5757381516460032
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-02 03:16:15 +01:00
Michael Niedermayer
12c3e120fe
avcodec/ituh263dec: Use 0xffff as error code in h263p_decode_umotion()
...
This matches ff_h263_decode_motion() both functions error codes are interpreted by the same common code
Fixes: 690/clusterfuzz-testcase-4744944981901312
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-02 03:16:12 +01:00
Michael Niedermayer
04c99c8042
avcodec/h264idct_template: Fix several runtime error: signed integer overflow
...
Fixes: 689/clusterfuzz-testcase-6029352737177600
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-02 03:16:10 +01:00
Michael Niedermayer
e46ab99750
avformat/oggdec: fix leak in ogg_restore()
...
Fixes: asan_bug_leak
Found-by: Thomas Guilbert <tguilbert@google.com >
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-02 03:12:26 +01:00
Michael Niedermayer
fb6fa48fce
avformat/oggdec: Factor free_stream out
...
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-02 03:12:25 +01:00
Michael Niedermayer
3250d4b39c
avformat/oggdec: remove unused parameter of ogg_restore()
...
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-02 03:12:25 +01:00
Michael Niedermayer
7b5ff7d573
avcodec/vp8: Check for bitsteam end in decode_mb_row_no_filter()
...
Fixes timeout with 686/clusterfuzz-testcase-5853946876788736
this shortcuts (i.e. speeds up) the error and
return-to-user when decoding a truncated frame
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Previous version reviewed by: "Ronald S. Bultje" <rsbultje@gmail.com >
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-01 14:07:33 +01:00
Michael Niedermayer
4bd3f1ce3e
avcodec/h264_direct: Fix runtime error: left shift of negative value -14
...
Fixes: 682/clusterfuzz-testcase-4799120021651456
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-01 14:07:33 +01:00
Michael Niedermayer
2c00b37302
avcodec/avpacket: Check metadata key in av_packet_unpack_dictionary()
...
Fixes timeout
Fixes: 501/clusterfuzz-testcase-5672752870588416
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-03-01 14:07:33 +01:00
Michael Niedermayer
7f62368bac
MAINTAINERS: Add Rodger Combs to ffmpeg-security
...
Rodger Combs will be added to the ffmpeg-security alias when this patch is applied
Reviewed-by: Paul B Mahol <onemda@gmail.com >
Reviewed-by: Clément Bœsch <u@pkh.me >
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-02-28 01:13:52 +01:00
Michael Niedermayer
4f21868207
MAINTAINERS: add wm4 to ffmpeg-security
...
wm4 will be added to the ffmpeg-security alias when this patch is applied
Reviewed-by: Paul B Mahol <onemda@gmail.com >
Reviewed-by: Clément Bœsch <u@pkh.me >
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-02-28 01:13:52 +01:00
Michael Niedermayer
3d66eb6ec3
MAINTAINERS: Make formating of ffmpeg-security entry the same as others
...
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc >
2017-02-28 01:13:52 +01:00