1
0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2025-02-14 22:22:59 +02:00
FFmpeg/libavutil
Andreas Rheinhardt 5b85ca5317 avutil/x86/pixelutils: Empty MMX state in ff_pixelutils_sad_8x8_mmxext
We currently mostly do not empty the MMX state in our MMX
DSP functions; instead we only do so before code that might
be using x87 code. This is a violation of the System V i386 ABI
(and maybe of other ABIs, too):
"The CPU shall be in x87 mode upon entry to a function. Therefore,
every function that uses the MMX registers is required to issue an
emms or femms instruction after using MMX registers, before returning
or calling another function." (See 2.2.1 in [1])
This patch does not intend to change all these functions to abide
by the ABI; it only does so for ff_pixelutils_sad_8x8_mmxext, as this
function can by called by external users, because it is exported
via the pixelutils API. Without this, the following fragment will
assert (on x86/x64):
    uint8_t src1[8 * 8], src2[8 * 8];
    av_pixelutils_sad_fn fn = av_pixelutils_get_sad_fn(3, 3, 0, NULL);
    fn(src1, 8, src2, 8);
    av_assert0_fpu();

[1]: https://raw.githubusercontent.com/wiki/hjl-tools/x86-psABI/intel386-psABI-1.1.pdf

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
2023-11-04 01:26:03 +01:00
..
2023-03-26 01:46:39 +01:00
2023-10-29 22:15:15 +02:00
2023-09-07 00:42:10 +02:00
2021-04-27 10:43:13 -03:00
2023-07-12 15:35:37 +02:00
2022-09-13 16:50:43 -03:00
2023-09-07 00:42:10 +02:00
2022-11-06 08:26:50 +01:00
2023-09-02 02:49:06 +02:00
2023-09-02 02:49:06 +02:00
2023-09-07 00:42:10 +02:00
2023-08-08 09:46:11 +02:00
2023-09-07 00:42:10 +02:00
2021-07-22 14:34:31 +02:00
2023-09-07 00:42:10 +02:00
2021-07-22 14:34:31 +02:00
2022-10-17 09:56:47 +02:00
2021-07-22 14:34:31 +02:00
2022-02-24 12:56:49 +01:00
2021-07-21 16:35:27 +02:00
2023-09-02 02:49:06 +02:00
2023-09-07 00:42:10 +02:00
2021-07-22 14:34:31 +02:00
2023-02-09 15:35:14 +01:00
2023-09-07 00:42:10 +02:00
2023-09-07 00:42:10 +02:00
2021-07-22 14:34:31 +02:00
2022-03-15 09:42:29 -03:00
2023-09-28 19:36:08 +02:00
2020-05-23 15:51:44 +02:00
2021-07-22 14:34:31 +02:00
2021-07-22 14:34:31 +02:00
2021-07-22 14:34:31 +02:00
2023-07-22 21:35:15 +03:00
2023-09-07 00:42:10 +02:00
2021-07-22 14:34:31 +02:00
2022-10-17 09:51:47 +02:00
2023-09-07 00:42:10 +02:00
2023-09-01 23:59:10 +02:00
2023-08-08 09:46:11 +02:00
2023-08-08 09:46:11 +02:00