Alexander Wilms
|
5cbc75d3b7
|
Merge remote-tracking branch 'upstream/develop' into develop
|
2023-10-29 13:35:37 +00:00 |
|
Alexander Wilms
|
ed86a917eb
|
AI/BattleAI/BattleAI.cpp: Use Class template argument deduction for wallParts array
Co-authored-by: Ivan Savenko <saven.ivan@gmail.com>
|
2023-10-29 13:34:19 +00:00 |
|
Alexander Wilms
|
e677164ed0
|
client/widgets/Buttons.h: Fix const reference
Co-authored-by: Andrey Filipenkov <kambaladecapitator@gmail.com>
|
2023-10-29 13:34:19 +00:00 |
|
Alexander Wilms
|
5d7b83c10b
|
client/widgets/Buttons.cpp: Fix const reference
Co-authored-by: Andrey Filipenkov <kambaladecapitator@gmail.com>
|
2023-10-29 13:34:19 +00:00 |
|
Alexander Wilms
|
0232ae5327
|
AI/BattleAI/BattleEvaluator.cpp: Convert this integer literal to a bool literal.
Integer literals should not be cast to bool
|
2023-10-29 13:34:19 +00:00 |
|
Alexander Wilms
|
bfddc90ff4
|
AI/BattleAI.cpp: Use "std::array" or "std::vector" instead of a C-style array.
Variables of array type should not be declared cpp:M23_356
|
2023-10-29 13:34:19 +00:00 |
|
Alexander Wilms
|
466cdb9d2b
|
client/widgetsImages.{h,cpp}: implicit conversion loses integer precision: 'int' to 'uint8_t' (aka 'unsigned char')
|
2023-10-29 13:34:19 +00:00 |
|
Alexander Wilms
|
f1bb6b999c
|
client/widgets/Buttons.{h,cpp}: Pass expensive to copy object "callback" by reference to const.
|
2023-10-29 13:33:57 +00:00 |
|
Ivan Savenko
|
98cb2abd01
|
Merge pull request #3117 from Alexander-Wilms/patch-1
Installation_Linux.md: Fix link to Building_Linux.md
|
2023-10-29 15:23:19 +02:00 |
|
Ivan Savenko
|
e2cffd4c7b
|
Merge pull request #3118 from rilian-la-te/glamor-slight-bonus-fixes
Small bonus fixes
|
2023-10-29 15:23:07 +02:00 |
|
Ivan Savenko
|
720a404e20
|
Merge pull request #3121 from vcmi/fix-fight-in-dwelling
BattleAI: fix freeze fighting in dwelling
|
2023-10-29 15:22:47 +02:00 |
|
Ivan Savenko
|
3016014543
|
Merge pull request #3110 from IvanSavenko/mod_compat_fix
Mod compatibility fixes
|
2023-10-29 14:30:04 +02:00 |
|
Ivan Savenko
|
be5505690d
|
Apply suggestions from code review
Co-authored-by: Nordsoft91 <nordsoft@yahoo.com>
|
2023-10-29 13:47:56 +02:00 |
|
Ivan Savenko
|
cc5bc40103
|
Merge pull request #3105 from IvanSavenko/fix_conflicts
Fix handling of conflicting mods by game client
|
2023-10-29 13:47:04 +02:00 |
|
Ivan Savenko
|
18b8971d6f
|
Merge pull request #3101 from IvanSavenko/fix_android_data_import
Fix data import on Android
|
2023-10-29 13:46:48 +02:00 |
|
Ivan Savenko
|
0169c65937
|
Merge pull request #3100 from IvanSavenko/split_net_packs
Split netpacks.h into multiple files
|
2023-10-29 13:46:40 +02:00 |
|
Tomasz Zieliński
|
368a185008
|
Cleaning up the code
|
2023-10-29 10:05:24 +01:00 |
|
Andrii Danylchenko
|
b579ca8a33
|
#1912 trap, exception on adding duplicating hero
|
2023-10-29 11:03:37 +02:00 |
|
Tomasz Zieliński
|
b0830a837b
|
Fixed template with no starting towns for players 3 and 4.
|
2023-10-29 09:35:38 +01:00 |
|
Andrii Danylchenko
|
4d6d64837f
|
#2993 - destruct battle info first when destruction CGameState
|
2023-10-29 09:41:22 +02:00 |
|
Andrii Danylchenko
|
3025785839
|
BattleAI: fix freeze fighting in dwelling
|
2023-10-29 09:29:57 +02:00 |
|
Alexander Wilms
|
248877245e
|
Improve ccache hit rate for PRs
|
2023-10-29 01:33:40 +00:00 |
|
Alexander Wilms
|
e4db6f2af8
|
CClient::removeGUI(): This function should be declared 'const'
|
2023-10-28 23:05:05 +00:00 |
|
nordsoft
|
35e7fbb366
|
Fix crash cause by duplicated delete
|
2023-10-28 22:22:30 +02:00 |
|
Tomasz Zieliński
|
07dac8b6d4
|
Works more or less
|
2023-10-28 20:30:38 +02:00 |
|
Alexander Wilms
|
9e1629fb40
|
launcher/modManager/cmodlist.cpp: Member functions that don't mutate their objects should be declared "const"
|
2023-10-28 16:44:58 +00:00 |
|
Alexander Wilms
|
d686d40bb4
|
launcher/firstLaunch/firstlaunch_moc.cpp: "static" members should be accessed statically
|
2023-10-28 15:44:17 +00:00 |
|
Konstantin
|
df07b27129
|
parseSelector: fix anyOf and noneOf
|
2023-10-28 18:35:59 +03:00 |
|
Konstantin
|
f6b03201db
|
BattleAction: handle obstacle for standing units
|
2023-10-28 18:34:11 +03:00 |
|
Alexander Wilms
|
e95439e556
|
Installation_Linux.md: Fix link to Building_Linux.md
|
2023-10-28 17:13:13 +02:00 |
|
Ivan Savenko
|
36eacf99d5
|
Cleanup
|
2023-10-28 17:58:08 +03:00 |
|
Ivan Savenko
|
4ba8014573
|
Added subtype for SPELL_DURATION
|
2023-10-28 17:57:56 +03:00 |
|
Ivan Savenko
|
1e0ea5f1f0
|
documented NEGATIVE_EFFECTS_IMMUNITY, fixed subtype loading
|
2023-10-28 17:56:11 +03:00 |
|
Ivan Savenko
|
1459006916
|
Added separate bonus for native terrain check
|
2023-10-28 17:54:58 +03:00 |
|
Alexander Wilms
|
a6db82f6f1
|
mapeditor/inspector/inspector.cpp: Directly assign to the "std::optional", without dereferencing it.
Assigning to an optional should directly target the optiona
|
2023-10-28 10:16:33 +00:00 |
|
Alexander Wilms
|
3d8dd35d43
|
lib/NetPacksLib.cpp: Directly assign to the "std::optional", without dereferencing it.
Assigning to an optional should directly target the optional
|
2023-10-28 10:15:50 +00:00 |
|
Alexander Wilms
|
703ab677ba
|
lib/mapObjects/IMarket.cpp: Show error message about failed dynamic_cast() even if cast object is nullptr
|
2023-10-27 23:43:39 +00:00 |
|
Alexander Wilms
|
bb04ca46b5
|
client/NetPacksClient.cpp: Combine null pointer checks
Co-authored-by: Nordsoft91 <nordsoft@yahoo.com>
|
2023-10-27 23:43:39 +00:00 |
|
Alexander Wilms
|
92bab6dd08
|
client/NetPacksClient.cpp: Combine null pointer checks
Co-authored-by: Nordsoft91 <nordsoft@yahoo.com>
|
2023-10-27 23:43:39 +00:00 |
|
Alexander Wilms
|
d2c03773cd
|
client/NetpacksClient.cpp: Called C++ object pointer is null
Null pointers should not be dereferenced
|
2023-10-27 23:43:39 +00:00 |
|
Alexander Wilms
|
03835236fb
|
lib/mapObjects/CGPandoraBox.cpp: Identical sub-expressions on both sides of operator "||".
Identical expressions should not be used on both sides of a binary operator
|
2023-10-27 23:40:55 +00:00 |
|
Alexander Wilms
|
cc8cc11da3
|
server/battles/BattleFlowProcessor.cpp: Called C++ object pointer is null
Null pointers should not be dereferenced
|
2023-10-27 23:40:55 +00:00 |
|
Alexander Wilms
|
860f6150aa
|
lib/mapObjects/IMarket.cpp: Forming reference to null pointer
Null pointers should not be dereferenced
|
2023-10-27 23:34:11 +00:00 |
|
Alexander Wilms
|
0a6c82c639
|
AI/Nullkiller/Behaviors/DefenceBehavior.{h,cpp}: treat -> threat
|
2023-10-27 23:34:11 +00:00 |
|
Alexander Wilms
|
457e73ed12
|
AI/BattleAI/BattleExchangeVariant.cpp: Do not assign data members in a constructor. Initialize members in an initialization list.
Member data should be initialized in-class or in a constructor initialization list
|
2023-10-27 23:34:11 +00:00 |
|
Alexander Wilms
|
ead1140b9b
|
client/icons/generate_icns.py: Replace print statement by built-in function.
The "print" statement should not be used
|
2023-10-27 23:34:11 +00:00 |
|
Alexander Wilms
|
b10b1a5444
|
AI/BattleAI/BattleExchangeVariant.cpp: This function should be declared "const".
Member functions that don't mutate their objects should be declared "const"
|
2023-10-27 23:34:11 +00:00 |
|
Andrii Danylchenko
|
7531400f53
|
Merge pull request #3098 from vcmi/battle-ai-movement-fix
Battle ai movement fix
|
2023-10-27 22:10:41 +03:00 |
|
Alexander Wilms
|
af330ff038
|
AI/BattleAI/BattleEvaluator.cpp: Remove this redundant cast.
Redundant casts should not be used
|
2023-10-27 18:19:17 +00:00 |
|
Alexander Wilms
|
10ad5b6789
|
client/windows/CCastleInterface.cpp: Identical sub-expressions on both sides of operator "&&".
Identical expressions should not be used on both sides of a binary operator
|
2023-10-27 18:19:17 +00:00 |
|