Alexander Wilms and Nordsoft91
bb04ca46b5
client/NetPacksClient.cpp: Combine null pointer checks
...
Co-authored-by: Nordsoft91 <nordsoft@yahoo.com >
2023-10-27 23:43:39 +00:00
Alexander Wilms and Nordsoft91
92bab6dd08
client/NetPacksClient.cpp: Combine null pointer checks
...
Co-authored-by: Nordsoft91 <nordsoft@yahoo.com >
2023-10-27 23:43:39 +00:00
Alexander Wilms
d2c03773cd
client/NetpacksClient.cpp: Called C++ object pointer is null
...
Null pointers should not be dereferenced
2023-10-27 23:43:39 +00:00
Alexander Wilms
03835236fb
lib/mapObjects/CGPandoraBox.cpp: Identical sub-expressions on both sides of operator "||".
...
Identical expressions should not be used on both sides of a binary operator
2023-10-27 23:40:55 +00:00
Alexander Wilms
cc8cc11da3
server/battles/BattleFlowProcessor.cpp: Called C++ object pointer is null
...
Null pointers should not be dereferenced
2023-10-27 23:40:55 +00:00
Alexander Wilms
860f6150aa
lib/mapObjects/IMarket.cpp: Forming reference to null pointer
...
Null pointers should not be dereferenced
2023-10-27 23:34:11 +00:00
Alexander Wilms
0a6c82c639
AI/Nullkiller/Behaviors/DefenceBehavior.{h,cpp}: treat -> threat
2023-10-27 23:34:11 +00:00
Alexander Wilms
457e73ed12
AI/BattleAI/BattleExchangeVariant.cpp: Do not assign data members in a constructor. Initialize members in an initialization list.
...
Member data should be initialized in-class or in a constructor initialization list
2023-10-27 23:34:11 +00:00
Alexander Wilms
ead1140b9b
client/icons/generate_icns.py: Replace print statement by built-in function.
...
The "print" statement should not be used
2023-10-27 23:34:11 +00:00
Alexander Wilms
b10b1a5444
AI/BattleAI/BattleExchangeVariant.cpp: This function should be declared "const".
...
Member functions that don't mutate their objects should be declared "const"
2023-10-27 23:34:11 +00:00
Alexander Wilms
af330ff038
AI/BattleAI/BattleEvaluator.cpp: Remove this redundant cast.
...
Redundant casts should not be used
2023-10-27 18:19:17 +00:00
Alexander Wilms
10ad5b6789
client/windows/CCastleInterface.cpp: Identical sub-expressions on both sides of operator "&&".
...
Identical expressions should not be used on both sides of a binary operator
2023-10-27 18:19:17 +00:00
Alexander Wilms
f01ec55d21
Use the "nullptr" literal.
...
"nullptr" should be used to denote the null pointer
2023-10-27 18:18:59 +00:00
Alexander Wilms
70acf987b4
lib/BasicTypes.cpp: Remove the unary minus operator or change the expression's underlying type.
...
Unary minus should not be applied to an unsigned expression
2023-10-27 14:47:09 +00:00
Alexander Wilms
2b21001743
lib/rmg/RoadPlacer.cpp: Remove "e" from this "throw" statement to rethrow the original exception.
...
The original exception object should be rethrown
2023-10-27 14:35:03 +00:00
Alexander Wilms
3616235bb5
FramerateManager.cpp: Merge this "if" statement with the enclosing one.
...
Collapsible "if" statements should be merged
2023-10-27 14:30:04 +00:00
Alexander Wilms
bcaa2e5966
AI/VCAI/VCAI.cpp: Remove "e" from "throw" statement to rethrow the original exception.
...
The original exception object should be rethrown
2023-10-27 14:29:44 +00:00
Alexander Wilms
e4aaeef5da
AUTHORS.h: Global variables should be const.
...
Non-const global variables should not be used
2023-10-27 14:29:34 +00:00
Alexander Wilms
04b3dca773
github.yml: Remove duplicate -prune in line endings stage
2023-10-27 14:28:58 +00:00
Alexander Wilms
1d206253e0
CI/linux-qt6/validate_json.py: Use sys.exit(1) instead of throwing Exception
2023-10-27 14:28:19 +00:00
Alexander Wilms
6516ecbedd
Format CI/linux-qt6/validate_json.py with 'black -l999 .'
2023-10-27 14:28:05 +00:00
Alexander Wilms
941181b8b9
Convert XML files in android/ from CRLF to LF, exclude .bat files from CI check
2023-10-23 13:33:09 +00:00
f63c2ac5db
CI step "Ensure LF line endings": No need to ignore Android files
...
Co-authored-by: Ivan Savenko <saven.ivan@gmail.com >
2023-10-23 14:55:09 +02:00
Alexander Wilms
7e9a3ea042
CI step "Ensure LF line endings": Don't create subshell for grouped commands
2023-10-22 17:50:16 +00:00
Alexander Wilms
0ff423ff0e
Change remaining CRLF line endings to LF
...
find . -type f -name "*.JSON" -exec dos2unix {} \+;
2023-10-22 16:41:09 +00:00
Alexander Wilms
9e84ddc0aa
Add CI stage to ensure LF line endings
...
Based on @josch's command:
https://github.com/vcmi/vcmi/pull/3078#issuecomment-1772150744
2023-10-22 16:12:16 +00:00
Alexander Wilms
5c0c317691
Move JSON validation script to CI folder
2023-10-14 14:22:50 +00:00
Alexander Wilms
a8ff11ad74
Remove redundant mention of GPL 2 or later from metainfo description
2023-10-14 14:16:50 +00:00
Alexander Wilms
01aa288b72
Link to Discord instead of Slack in metainfo
2023-10-14 14:07:05 +00:00
Alexander Wilms and Alexander Wilms
73ea52c615
Enable VSync to prevent screen tearing while scrolling across map
...
Fixes #2935
2023-09-26 18:55:25 +02:00
Alexander Wilms
1c20431035
Use 64px and 32px as icon sizes in launcher sidebar
2023-09-17 15:52:20 +00:00
Alexander Wilms
ee935e9fa7
Fix JSON files
2023-09-17 12:36:57 +00:00
Alexander Wilms
e0089c76ae
Add shebang, use elif and only run on linux-clang-test
2023-09-16 11:32:26 +00:00
Alexander Wilms
6c15e5b426
Add include path of a more recent version of fuzzylite, which is required to build it with gcc 12.2.0
...
https://github.com/fuzzylite/fuzzylite/commit/a651f3d13e192352d7a02ee9da65ab591a963ab9
2023-09-16 05:13:16 +00:00
Alexander Wilms
512816b223
Only validate JSON on Linux
2023-09-16 00:59:08 +00:00
Alexander Wilms
2394612e28
JSON validation: Support various levels of strictness
2023-09-15 23:47:32 +00:00
Alexander Wilms
f38f2d5b6a
Add JSON validation as a CI stage
2023-09-15 22:32:53 +00:00
Alexander Wilms and Ivan Savenko
c0f0211098
Update VCMI icon ( #2672 )
...
* Update VCMI icon
Fixes #1993
Sources will be added to https://github.com/vcmi/vcmi-assets
* Use entire canvas height for shield, add remaining icons
* Use a slighty more saturated brown
* Align VCMI letters to pixel grid for 32px icons
* Align VCMI letters to pixel grid for 48px icon
* Align VCMI letters to pixel grid for 64px icon
* Add 96px icon to .ico
* Update Android and iOS icons
* Install 22px icon on Linux
* Update macOS .icns file
* Add more icons
* Update iOS icons
* Add more sizes to .ico files
* Don't use .png inside .ico
* Only include resolutions up to 256px in .ico files
* Center map editor icon
2023-09-05 23:57:19 +03:00
Alexander Wilms and GitHub
d2f0a80573
Update VCMI icon ( #2672 )
...
* Update VCMI icon
Fixes #1993
Sources will be added to https://github.com/vcmi/vcmi-assets
* Use entire canvas height for shield, add remaining icons
* Use a slighty more saturated brown
* Align VCMI letters to pixel grid for 32px icons
* Align VCMI letters to pixel grid for 48px icon
* Align VCMI letters to pixel grid for 64px icon
* Add 96px icon to .ico
* Update Android and iOS icons
* Install 22px icon on Linux
* Update macOS .icns file
* Add more icons
* Update iOS icons
* Add more sizes to .ico files
* Don't use .png inside .ico
* Only include resolutions up to 256px in .ico files
* Center map editor icon
2023-09-01 22:36:32 +03:00
Alexander Wilms and GitHub
48150211d9
Update bug tracker URL in metainfo
2022-09-29 23:07:54 +02:00
Alexander Wilms and Andrii Danylchenko
d67d8a003e
Add 1.0.0 release to appstream metadata
2022-09-14 21:53:42 +03:00