rust/comprehensive-rust
1
0
Fork 0
mirror of https://github.com/google/comprehensive-rust.git synced 2025-01-28 23:52:09 +02:00
Code Issues Releases Activity
2,157 Commits 17 Branches 0 Tags
Commit Graph

2157 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
dependabot[bot]
9dcfc7e4d8
cargo: bump the patch group with 11 updates (#2456) 
Bumps the patch group with 11 updates:

| Package | From | To |
| --- | --- | --- |
| [anyhow](https://github.com/dtolnay/anyhow) | `1.0.89` | `1.0.91` |
| [clap](https://github.com/clap-rs/clap) | `4.5.18` | `4.5.20` |
| [regex](https://github.com/rust-lang/regex) | `1.11.0` | `1.11.1` |
| [serde](https://github.com/serde-rs/serde) | `1.0.210` | `1.0.214` |
| [serde_json](https://github.com/serde-rs/json) | `1.0.128` | `1.0.132`
|
| [pulldown-cmark](https://github.com/raphlinus/pulldown-cmark) |
`0.12.1` | `0.12.2` |
| [thiserror](https://github.com/dtolnay/thiserror) | `1.0.64` |
`1.0.66` |
| [reqwest](https://github.com/seanmonstar/reqwest) | `0.12.8` |
`0.12.9` |
| [futures-util](https://github.com/rust-lang/futures-rs) | `0.3.30` |
`0.3.31` |
| [cxx](https://github.com/dtolnay/cxx) | `1.0.128` | `1.0.129` |
| [cxx-build](https://github.com/dtolnay/cxx) | `1.0.128` | `1.0.129` |

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-11-01 08:29:38 +01:00
Martin Geisler
1d7c9163f5
Simplify imports by importing fewer items directly (#2404) 
When reading the code without an IDE, I find it useful to use explicit
module names, especially when items come from the standard library.

So `io::Error` instead of just `Error`, especially when people have
just been told about `std::error::Error` as well.

I also omitted most single-use items: I find it has less cognitive
overhead to say “we import `fmt`” and then later use `fmt::Display`
and `fmt::Formatter` in the code. It’s clear from the name that these
two things have something to do with formatting.

Finally, I made a few usages more consistent so that we refer to each
item in the same way within a single codeblock.
 2024-10-29 11:19:58 +01:00
Martin Geisler
7a462efb57
Ensure examples compile on latest version of AOSP (#2414) 
This is part of #2398.
 2024-10-28 19:35:54 +01:00
Martin Geisler
c16c07a53a
The Error trait is in core as of Rust 1.81.0 (#2408) 2024-10-28 19:24:36 +01:00
Martin Geisler
905784e601
Remove open-ended Android exercise (#2418) 
Despite good intentions, I have not actually been able to make this
work in a classroom.

I suggest we remove it for now and later replace it with a guided
exercise: something where we ask students to write a AIDL client for a
simple system service.
 2024-10-28 19:24:30 +01:00
Martin Geisler
6e829ff89a
Show expressions trees (#2425) 
While giving the class, I noticed that a few people were not used to
this kind of recursive structures. A diagram could help here.
 2024-10-28 19:24:22 +01:00
Võ Hoàng Long
8873e3ea53
vi: translate Default trait (#2447) 
Translate the `Default` chapter of the `std-trait` section to Vietnamese
 2024-10-27 13:47:59 -04:00
Martin Geisler
8bfff0d95a
Consistently inline formatting arguments (#2413) 2024-10-21 20:01:21 +02:00
Martin Geisler
ce56ea551e
Use both break and continue for consistency (#2412) 
To me, this little change makes it a little clearer that we either
print something, we break, or we continue in the loop.
 2024-10-21 19:57:19 +02:00
Martin Geisler
ec6cb024e8
Apply clippy::semicolon_if_nothing_returned (#2410) 
This is for consistency: if a block returns `()`, and the last
expression of the block also returns `()`, then the final `;` can be
left out.

However, this is a little confusing (I was asked about this in a class
today) and it is inconsistent.

See

https://rust-lang.github.io/rust-clippy/master/index.html#/semicolon_if_nothing_returned
for details.
 2024-10-21 19:57:01 +02:00
Danny Ra
3d1339c546
fa: fix translations.md restore sentence paragraph. (#2446) 
fix: translations.md restore sentence paragraph.

---------

Co-authored-by: javad-jafari <javajafarifromsharak@gmail.com>
Co-authored-by: javad-jafari <65780584+javad-jafari@users.noreply.github.com>
 2024-10-19 22:03:57 +03:30
Martin Geisler
e5d73d915b
Format filenames consistently (#2415) 
The style used in the rest of the course is _italic_ filenames, so we
should be careful to not suddenly use **bold** names.

The style is of course up for debate, but we need to ensure
consistency first.
 2024-10-18 12:29:31 +02:00
Martin Geisler
ab78a9e6b8
Links in channel pages (#2441) 2024-10-18 09:05:01 +02:00
Martin Geisler
ad7ef2e50a
Make scoped thread examples consistent (#2444) 
This is a followup to #1020.
 2024-10-18 09:04:44 +02:00
Martin Geisler
1a9941b39f
Put “Bye!” message on its own line (#2431) 
Before the message would be printed right next to the text echoed
back. We now make sure to print it after a blank line.
 2024-10-18 09:04:19 +02:00
Martin Geisler
0f00434a0f
Simplify language on mutex page (#2440) 
The “iff” phrasing has confused people in the past.
 2024-10-18 09:04:10 +02:00
Martin Geisler
fb17791c26
Remove misplaced extern "C" (#2429) 
I think something changed: I now get a compilation error with these
lines (and it works fine without).
 2024-10-18 09:03:54 +02:00
Martin Geisler
466233d959
Fix inclusion of PhoneNumber in exercise (#2426) 
The anchor used the wrong name. This was not caught by our tests
because the code isn’t expected to compile, even when this is
included.
 2024-10-18 09:03:48 +02:00
Martin Geisler
47c3d50542
Simplify language, add links, formatting fixes (#2443) 
- Avoid time-specific statements (“recently”, “today”, …).

- Move details such as “RPIT” to the speaker notes.

- More links to our slides as well as community documentation.

- Formatting fixes
 2024-10-18 09:03:17 +02:00
Martin Geisler
5d292377a0
Remove outdated note about showing type of future (#2442) 
Modern Rust just says “note: calling an async function returns a
future” and hides the `Future` type.
 2024-10-18 09:02:53 +02:00
Martin Geisler
0afca2f69b
Formatting in threads (#2439) 2024-10-18 09:02:45 +02:00
Younies Mahmoud
2552776288
ar: First Stage: Initial 5000 Lines Translated (#2322) 2024-10-17 15:53:31 +02:00
Martin Geisler
36a592df28
Mention https://std.rs/ and rustup doc (#2421) 
These are convenient short-cuts for going to the standard library
documentation.
 2024-10-17 02:53:02 -04:00
Danny Ra
4096bf89ae
fa: update fuzzy and untranslated part 1 (#2438) 
fa: update fuzzy and untranslated part 1

---------

Co-authored-by: javad-jafari <javajafarifromsharak@gmail.com>
Co-authored-by: javad-jafari <65780584+javad-jafari@users.noreply.github.com>
 2024-10-17 01:12:23 +03:30
Henri F.
f1423eaa72
Fix broken link on translations.md (#2437) 2024-10-16 14:50:13 -04:00
Martin Geisler
09a072b1ce
Point out new code in Luhn exercise solution (#2409) 
This makes it easier for the students to understand where the changes
and thus fixes are.
 2024-10-16 11:35:27 +02:00
Martin Geisler
0c824ab740
Fix “incorrect” which should have been “unsafe” (#2419) 2024-10-16 11:34:53 +02:00
Martin Geisler
701589ffd5
Consistently end list items with a full stop (#2416) 
This is more consistent.
 2024-10-16 11:34:22 +02:00
Martin Geisler
bd7b7eb121
Clean up duplicate heading (#2424) 2024-10-16 11:28:43 +02:00
Martin Geisler
4c78c3be6d
Simplify with local variable (#2423) 
This reduces the vertical space needed.
 2024-10-16 11:28:30 +02:00
Martin Geisler
dcdf3915ec
Fix typo in expect message (#2420) 2024-10-16 11:28:25 +02:00
Martin Geisler
1c3e4648e4
Remove unnecessary null check in FFI exercise (#2432) 
We only assign `self.dir` once and we only assign it if the pointer is
non-null. We can therefore simplify the drop implementation a little.
 2024-10-16 11:25:22 +02:00
Henri F.
28b5b559b3
fa: Adds Farsi to the language selector (#2436) 
Adds Farsi to the drop-down language selector and minor rearrangement on
Translation page
#671
 2024-10-15 22:17:55 -07:00
Dustin J. Mitchell
d9e3ad9e63
Reduce references to niche optimization (#2385) 
Niche optimization is currently mentioned in three places:
 - Enums (User-Defined Types, Day 1 Afternoon)
 - Option (Standard Library Types, Day 2 Afternoon)
 - Box (Smart Pointers, Day 3 Morning)

This is a tricky thing to get right, and it was just in the speaker
notes in each place. #1820 will introduce a fuller explanation.

Fixes #1820.
 2024-10-15 11:19:37 -04:00
Martin Geisler
a699430741
Remove unused Concurrency exercises page (#2411) 
This was moved to the `concurrency/` directory.
 2024-10-15 16:15:38 +02:00
Martin Geisler
a1b483a2f5
Call out that self receivers are covered later (#2422) 
We have not formally introduced ownership at this point, so the
exercise can be confusing for students.

Alternatively, we could consider removing the `finish` method since
it’s not essential for a first encounter with methods.
 2024-10-15 16:15:12 +02:00
Martin Geisler
a387b2c755
Simplify iterator method chaining exercise (#2427) 
The exercise is about iterators, _not_ generic integer types. The
`where` syntax has also not been introduced before, further adding
confusion for the students.
 2024-10-15 16:14:50 +02:00
Martin Geisler
61407e6079
Avoid uppercase “HINT” (#2428) 
We don’t have a convention of all-capital headings. However, we can
have do a similar convention with a block quotes (see README and
TRANSLATIONS).

Reviewed-by: Martin Geisler <mgeisler@google.com>
 2024-10-15 16:14:25 +02:00
Martin Geisler
c01142e5d2
Fix casing of “Rust” (#2433) 2024-10-15 16:13:53 +02:00
Martin Geisler
cf7359fac8
Add links to std and docs.rs (#2403) 
- **Link to relevant crate APIs**
- **Add missing std links**
 2024-10-15 08:12:25 +02:00
Danny Ra
25a2fa6a09
fa: try to complete Farsi - part 4 (#2401) 
fa: try to complete Farsi - part 4

---------

Co-authored-by: javad-jafari <javajafarifromsharak@gmail.com>
Co-authored-by: javad-jafari <65780584+javad-jafari@users.noreply.github.com>
 2024-10-14 00:00:04 +03:30
Yerkebulan Tulibergenov
252bb62521
Fix typo (#2399) 
Fix typo
 2024-10-09 03:25:54 +00:00
Danny Ra
7a25c4ad84
fa: try to complete Farsi part 3 (#2395) 
fa: try to complete Farsi part 3

---------

Co-authored-by: javad-jafari <javajafarifromsharak@gmail.com>
Co-authored-by: javad-jafari <65780584+javad-jafari@users.noreply.github.com>
 2024-10-04 23:28:39 +03:30
Martin Geisler
0474168196
Remove outdated tip about handling division by zero (#2393) 
The exercise text already asks you to handle this.
 2024-10-02 00:31:49 +00:00
dependabot[bot]
0a9a01d991
cargo: bump the patch group with 8 updates (#2388) 
Bumps the patch group with 8 updates:

| Package | From | To |
| --- | --- | --- |
| [anyhow](https://github.com/dtolnay/anyhow) | `1.0.86` | `1.0.89` |
| [clap](https://github.com/clap-rs/clap) | `4.5.16` | `4.5.18` |
| [serde](https://github.com/serde-rs/serde) | `1.0.209` | `1.0.210` |
| [serde_json](https://github.com/serde-rs/json) | `1.0.127` | `1.0.128`
|
| [pulldown-cmark](https://github.com/raphlinus/pulldown-cmark) |
`0.12.0` | `0.12.1` |
| [tokio-util](https://github.com/tokio-rs/tokio) | `0.7.11` | `0.7.12`
|
| [thiserror](https://github.com/dtolnay/thiserror) | `1.0.63` |
`1.0.64` |
| [reqwest](https://github.com/seanmonstar/reqwest) | `0.12.7` |
`0.12.8` |

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-10-01 14:14:54 +01:00
dependabot[bot]
6a013839f3
cargo: bump cc from 1.1.15 to 1.1.23 in /src/exercises/bare-metal/rtc in the patch group (#2391) 
Bumps the patch group in /src/exercises/bare-metal/rtc with 1 update:
[cc](https://github.com/rust-lang/cc-rs).

Updates `cc` from 1.1.15 to 1.1.23

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-10-01 14:01:30 +01:00
dependabot[bot]
7422ee20e6
cargo: bump cc from 1.1.15 to 1.1.23 in /src/bare-metal/aps/examples in the patch group (#2390) 
Bumps the patch group in /src/bare-metal/aps/examples with 1 update:
[cc](https://github.com/rust-lang/cc-rs).

Updates `cc` from 1.1.15 to 1.1.23

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-10-01 14:01:07 +01:00
dependabot[bot]
259220ba88
build(deps): bump crate-ci/typos from 1.24.3 to 1.24.6 (#2389) 
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.24.3 to
1.24.6.

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-10-01 14:00:39 +01:00
dependabot[bot]
be9ed92365
cargo: bump the minor group with 4 updates (#2387) 
Bumps the minor group with 4 updates:
[regex](https://github.com/rust-lang/regex),
[buddy_system_allocator](https://github.com/rcore-os/buddy_system_allocator),
[tempfile](https://github.com/Stebalien/tempfile) and
[tokio-websockets](https://github.com/Gelbpunkt/tokio-websockets).

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-10-01 14:00:01 +01:00
dependabot[bot]
c23c0c9312
cargo: bump buddy_system_allocator from 0.10.0 to 0.11.0 in /src/bare-metal/alloc-example in the minor group (#2386) 
Bumps the minor group in /src/bare-metal/alloc-example with 1 update:
[buddy_system_allocator](https://github.com/rcore-os/buddy_system_allocator).

Updates `buddy_system_allocator` from 0.10.0 to 0.11.0

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-10-01 13:59:34 +01:00