1
0
mirror of https://github.com/google/comprehensive-rust.git synced 2024-12-11 13:18:43 +02:00
Commit Graph

548 Commits

Author SHA1 Message Date
Eunsu(Daniel) Kim
dc0091882a
fix: fix typo at ko.po (#514) 2023-03-20 09:25:28 +09:00
Andrew Walbran
daf25d094b
Make Miri happy (#486)
I think this is a better solution than #308. It fixes the Miri error, and mostly keeps the original intent of demonstrating how to use raw pointers.
2023-03-15 23:18:12 +00:00
Andrew Walbran
7a22d5567a
Don't allocate in success case (#506)
`format!` was being called (and allocating a string) even in the success case.
2023-03-15 09:06:35 +01:00
Oliver Mannion
9ee562c267
Remove unnecessary Mutex::lock from shared state example (#499)
It's not necessary to explicitly take the lock to print it.
2023-03-12 10:48:52 +01:00
Charisee Chiw
59d3d7f625
Indent code in speaker notes (#476)
* Indent code in speaker notes

#475

* Update stack.md

* Update destructuring-arrays.md

* Update hashmap.md

* Update traits.md
2023-03-11 14:12:32 -08:00
Daniel Gorelik
368f3ba302
The code block at https://google.github.io/comprehensive-rust/testing/unit-tests.html probably should not be runnable (#498) 2023-03-11 10:12:37 +01:00
Jooyung Han
ef9d9e3bbe
Update Korean Translation (20230310) (#493)
* Update Korean translation

```
$ MDBOOK_OUTPUT='{"xgettext": {"pot-file": "messages.pot"}}' mdbook build -d po
$ msgmerge --no-wrap --update po/ko.po po/messages.pot
$ LANGUAGE=C msgfmt  -o /dev/null --statistics po/ko.po
 1235 translated messages, 36 fuzzy translations, 633 untranslated messages.
```

* Resolve fuzzy entries in Korean translation

```
$ LANGUAGE=C msgfmt  -o /dev/null --statistics po/ko.po
1278 translated messages, 626 untranslated messages.
```

* Remove obsolete entries

---------

Co-authored-by: Jooyung Han <jooyung@google.com>
2023-03-11 09:48:38 +09:00
Dustin J. Mitchell
bfed596d28
Generalize the day-4 afternoon (#487)
* Generalize the day-4 afternoon

This is in preparation for adding more options for this portion of the
course, and reflects an existing practice of substituting other
materials for this last half-day.

* address review comments
2023-03-10 09:07:36 -05:00
MMINO
ff66258c50
Fix typo in borrowing.md in the Speaker's Notes (#490)
the -> they
2023-03-09 14:13:04 +00:00
Dustin J. Mitchell
ba28dd2d4c
Parse Markdown in mdbook-xgettext (#449)
* Parse Markdown to support translation.

This upgrades from just splitting Markdown files on double-newlines, to
using a Markdown parser to break them into more appropriate chunks. The
upshot is that code samples are all in one message, lists are bundled
together, and generally it should be easier to translate.

* [WIP] helper to update po files for new translation

* process synthetic input file-by-file

* review comments

* remove temporary code

* fix msgfmt lints
2023-03-07 18:07:07 +00:00
Charisee Chiw
3242afae09
Create default.md (#370)
* Create default.md

* Update SUMMARY.md

* Update SUMMARY.md

* Update default.md

* Update default.md

* Update default.md
2023-03-07 17:11:43 +01:00
Martin Geisler
64340562ea
Add badges to README and welcome page (#481) 2023-03-07 12:45:00 +00:00
Martin Geisler
e366d833d0
Update mdbook to 0.4.28 (#480)
* Update mdbook to 0.4.28

This version contains https://github.com/rust-lang/mdBook/pull/1986 which will allow us to test the code in each translation.

* Fix formatting in Korean translation

The extra code block made `mdbook test` fail.
2023-03-07 10:14:26 +01:00
ronaldfw
46aeaa508c Make some more progress on the German translation 2023-03-06 15:42:11 +01:00
Martin Geisler
31500974e4
Add note about requesting a room with tables (#479)
* Add note about requesting a room with tables

The course is built on the idea of using live-coding as much as possible. This means that it's important that there are desks in the classrooms — a traditional auditorium setup does not work well.
2023-03-06 15:23:10 +01:00
JeongHyeon Lee
c7d03651ff
Fix a typo at ko translation (#477) 2023-03-06 00:04:31 +09:00
JeongHyeon Lee
05eb17a6fe
Fix typo in string.md (#473) 2023-03-04 17:22:04 +01:00
Andrew Walbran
a78d58ba56
Add note about hygienic macros (#472)
* Add note about hygienic macros

* Fix typo.

* Add link about macro hygiene.
2023-03-03 12:19:52 +00:00
Martin Geisler
449ead5575
Integrate GA4 code directly with book.js (#470)
* Integrate GA4 code directly with `book.js`

The main advantage of this is that it simplifies the setup since we
can avoid the monkey-patching we did before.

A secondary advantage is that it should make things a little faster
since we avoid a request to the server on every page load.

* Remove unreachable return

* Watch all of `third_party`

It just occurred to me that we want to refresh the page in `mdbook serve` when anything changes in `third_party`.
2023-03-02 17:50:37 +00:00
Jooyung Han
e1546235c8
Update Korean Translation (2023-03-01) (#465)
* Update po/ko.po with the latest changes

```
$ MDBOOK_OUTPUT='{"xgettext": {"pot-file": "messages.pot"}}' mdbook build -d po
$ msgmerge --update po/ko.po --no-wrap po/messages.pot
```

* Resolve fuzzy translations in Korean

* Translate new texts into Korean

* Copy code blocks as msgstr in Korean

and fix some minor typos.

* Remove #~ lines from ko.po

* Address Jiyong's comments

* Fix typos and translate untranslated messages in Korean

---------

Co-authored-by: Jooyung Han <jooyung@google.com>
2023-03-02 18:31:01 +09:00
Jooyung Han
e4205b3ac8
Remove renderers from links and index preprocessors (#464)
* Remove `renderers` from `links` and `index` preprocessors

These two preprocessors are default preprocessors and controlled by
`build.use_default_preprocessors` not by `renders`.

* Fix the order of preprocessors

I was wrong about the order in #461.

* Remove `links` and `index` preprocessor lines

These default preprocessors are run by default.

---------

Co-authored-by: Jooyung Han <jooyung@google.com>
2023-03-02 18:01:24 +09:00
Martin Geisler
2de8d7cdbb
Simplify running the course slightly (#463)
Thanks to many contributors, we now have lots of speaker notes.
2023-03-02 09:13:49 +01:00
Martin Geisler
7e47e31408
Group per-translation output in publish step (#467) 2023-03-02 06:38:32 +09:00
Martin Geisler
adc6720031 Increase playground timeout to 15 seconds
We often see timeouts when running the course. Most of the time, the
code compiles on the second try, which indicates that we just need to
wait a little longer.

Fixes #406.
2023-03-01 13:14:42 +01:00
Martin Geisler
2a2f8ec94e Add book.js generated with mdbook init --theme
This allows us to customize the JavaScript used on the page.
2023-03-01 13:14:42 +01:00
Jooyung Han
7bddf5e6d6
Remove Last-* properties in po/ko.po (#468)
* Remove Last-* properties in po/ko.po

* Remove Last* properties in other po files

---------

Co-authored-by: Jooyung Han <jooyung@google.com>
2023-03-01 20:57:47 +09:00
Kuba
4a9b679a9c
Add note about fuzzy and fix heading nesting (#466) 2023-03-01 09:17:41 +00:00
Charisee Chiw
c22b35e426
Remove silenced warnings in book-library exercise (#388)
* Update book-library.md

* Update book-library.rs

* Apply suggestions from code review

Expanding the variable makes it ever-so-slightly easier to read.

---------

Co-authored-by: Martin Geisler <mgeisler@google.com>
2023-02-28 17:53:02 -08:00
Jooyung Han
1821a3fd12
Make i18n-helpers a requirement (#461)
* Make i18n-helpers a requirement

* Skip mdbook-gettext for mdbook-xgettext

* Gettext finds PO file based on `book.language`

* Update workflow

No need to set `preprocessor.gettext.po-file`.

---------

Co-authored-by: Jooyung Han <jooyung@google.com>
2023-02-28 22:05:09 +09:00
Jooyung Han
b65c30fb5f
Update Korean Translation. (#460)
* Resolve fuzzy items in Korean

* Add missing translation in Korean (visibility)

* Translate filesystem in Korean

* Update po/ko.po

Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>

* Update po/ko.po

Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>

* Update po/ko.po

Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>

---------

Co-authored-by: Jooyung Han <jooyung@google.com>
Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>
2023-02-27 23:14:52 +00:00
Martin Geisler
1feb94e02a
Take out unnecessary code from enum size slide (#309)
The slide is way too large to comfortable use in a classroom. Instead
of printing six lines of output, the instructor should carefully walk
through the different examples. That way we can take the course
participants with us through the explanations instead of simply
showing them the end result.
2023-02-27 17:42:46 +01:00
Adam MacBeth
b1b78a9672
Fix typo in string.md (#456)
* Fix typo in string.md

* Update src/std/string.md

---------

Co-authored-by: Martin Geisler <martin@geisler.net>
2023-02-27 13:37:08 +00:00
Steve Masterman
0562771ce0
Update variant-payloads.md (#459)
Fix typo
2023-02-27 13:19:32 +00:00
Charisee Chiw
e73b163d77
Add to speaker notes rc.md (#366)
* Update rc.md

* Fix wording and formatting

* Update rc.md

---------

Co-authored-by: Andrew Walbran <qwandor@google.com>
2023-02-27 02:05:01 +00:00
Jooyung Han
973e27a322
Cleanup Korean Translation (#458)
* s/블럭/블록

* Add missing translation for Korean

* Fix spacing in Korean

along with typos.

* Add missing msgstr in Korean

---------

Co-authored-by: Jooyung Han <jooyung@google.com>
2023-02-27 09:42:50 +09:00
Adam MacBeth
4690f19e8c
Fix typo in drop.md (#457) 2023-02-26 22:04:39 +00:00
Jooyung Han
98ec5c65af
Cosmetic refinement in Korean translation (#455)
* Add missing translation in Korean

* Cosmetic refinement of Korean translation

* typo
* spacing
* newlines
* `_text_` into `*text*` or `*text*`
* removed a few "translation note"(역주)

* Fix typo in Korean

---------

Co-authored-by: Jooyung Han <jooyung@google.com>
2023-02-25 01:34:27 +09:00
Martin Geisler
261bcfce3e
Show Markdown diff as unified diff (#454)
Also add nice colors to make things pretty.
2023-02-24 16:46:08 +01:00
Andrew Jones
db7a6044b4
Remove extraneous trailing parenthesis (#453)
The text currently looks like this:
> See the Rust Reference).

And should look like this:
> See the Rust Reference.

Closer #452
2023-02-24 16:27:24 +01:00
Jiyong Park
10e918d897
Revise the translation for Korean (#450)
* Run msgmerge --no-wrap --update po/ko.po po/messages.pot

* Be consistent with the line ending. For example, if the original text
ends with ":", so the translation is.

* Remove unnecessary newline characters

If a newline character is from the rendering of the source text, remove
it in the translated text.

* Fix the remaining inconsistencies on line ending chracters

* s/제너릭/제네릭/g

제네릭 seems to be the popular translation for "generic":

제너릭: 120K results
제네릭: 1M results

* s/트레이트/트레잇/g

트레잇 seems to be the popular translation for "trait" at least in the
Rust ecosystem. The Rust book also uses 트레잇.
https://rinthel.github.io/rust-lang-book-ko/appendix-08-glossary.html

* Revive the missing translations for the Translations section

* Resolve remaining fuzzy translations
2023-02-24 10:40:22 +09:00
Sandro Meier
07513b2b4e
Add fechu as owner to german translation (#451) 2023-02-23 13:57:04 +01:00
Charisee Chiw
60aa747aca
Add Speaker notes string.md (#368)
* Update string.md

* Update src/std/string.md

Co-authored-by: Martin Geisler <mgeisler@google.com>

* Update src/std/string.md

Co-authored-by: Martin Geisler <mgeisler@google.com>

* Update string.md

---------

Co-authored-by: Martin Geisler <mgeisler@google.com>
2023-02-22 18:01:07 +00:00
Alexey Sokolov
e616f66593
Clarify box (#448) 2023-02-22 16:08:50 +01:00
Charisee Chiw
bb3b17b6bd
Additional speaker notes for variant payloads (#200)
* Additional speaker notes for variant payloads

* Update variant-payloads.md

* Update variant-payloads.md
2023-02-22 15:00:45 +00:00
Charisee Chiw
3f6bd6aa14
Speaker Notes for Field Shorthand (#198)
* Speaker Notes for Field Shorthand

* Update field-shorthand.md
2023-02-22 14:55:29 +00:00
Charisee Chiw
8ee637d886
Lecture notes for Destructing Arrays (#266)
* Lecture notes for Destructing Arrays

* Update destructuring-arrays.md
2023-02-22 13:41:12 +01:00
Jooyung Han
c88738db02
Update Korean Translation (#444)
* Update Korean translation

* Apply --no-wrap for Korean translation

Use `--no-wrap` for Korean translation to avoid unnecessary diffs.

When updating ko.po,
`msgmerge --no-wrap --update po/ko.po po/messages.pot`

Poedit's settings:
- uncheck "line-wrapping"
- uncheck "keep old formatting"

Note that with these settings/options `msgstr` will be still
line-wrapped at `\n`.

---------

Co-authored-by: Jooyung Han <jooyung@google.com>
2023-02-20 16:02:20 +09:00
Jooyung Han
c885bbf2ee
Remove all fuzzy items in Korean translation (#433)
* Remove all fuzzy items in Korean translation

* Apply grammar fixes in Korean Translation

of #440, #441

---------

Co-authored-by: Jooyung Han <jooyung@google.com>
2023-02-20 10:05:18 +09:00
Eunsu(Daniel) Kim
582500b0b2
Fix a typo (#443) 2023-02-19 20:17:30 +09:00
Eunsu(Daniel) Kim
9a31c2e5e5
Fix a typo (#442) 2023-02-19 17:29:16 +09:00