Alexander Wilms and GitHub
734128e069
ChangeLog.md: Fix bullet points
2024-06-02 21:03:06 +02:00
Alexander Wilms
e70411bf1a
Fix typo: preasure -> pressure
2024-04-16 21:10:49 +00:00
Alexander Wilms
7d925b3689
Fix typo: Preasure -> Pressure
2024-04-16 21:10:15 +00:00
Alexander Wilms
ef417a0db0
Disable warnings about boost 1.7.4 including deprecated headers internally
2024-04-06 14:59:24 +00:00
Alexander Wilms and GitHub
4197c82f43
Readme: Point CI badge to runs that were triggered by a push to the develop branch
2024-02-01 13:45:55 +01:00
Alexander Wilms
781328f282
Convert C-style casts to the more verbose C++ style
2024-01-10 00:30:35 +00:00
Alexander Wilms
5e9f98b15c
Resolve intentionality issues
2024-01-10 00:23:24 +00:00
Alexander Wilms
f3277b7953
Define each identifier in a dedicated statement
2024-01-10 00:22:23 +00:00
Alexander Wilms
f78fe102ac
H3 data for unit tests: Use encrypted zip
...
This is easier than splitting H3bitmap and encrypting each file separately
2024-01-08 19:28:11 +00:00
Alexander Wilms
8800b361fd
Disable broken tests so the working ones don't rot
2024-01-08 19:13:44 +00:00
Alexander Wilms
b1020bdd5b
Enable unit tests for Linux CI builds
2024-01-08 19:13:44 +00:00
Alexander Wilms
5e96c90996
CI: Build linux-gcc-test preset with gcc 13
...
This helps detecting issues with newer gcc versions, like #2866
Fixes #3407
2024-01-04 19:48:16 +00:00
Alexander Wilms and Ivan Savenko
dd0d17c690
Translations.md: Add instructions on how to translate .metainfo.xml
...
Co-authored-by: Ivan Savenko <saven.ivan@gmail.com >
2023-12-20 14:57:19 +00:00
Alexander Wilms
62eedde0a7
Translations.md: Mention AppStream metainfo
2023-12-19 10:27:29 +00:00
Alexander Wilms
5cbc75d3b7
Merge remote-tracking branch 'upstream/develop' into develop
2023-10-29 13:35:37 +00:00
Alexander Wilms and Ivan Savenko
ed86a917eb
AI/BattleAI/BattleAI.cpp: Use Class template argument deduction for wallParts array
...
Co-authored-by: Ivan Savenko <saven.ivan@gmail.com >
2023-10-29 13:34:19 +00:00
Alexander Wilms and Andrey Filipenkov
e677164ed0
client/widgets/Buttons.h: Fix const reference
...
Co-authored-by: Andrey Filipenkov <kambaladecapitator@gmail.com >
2023-10-29 13:34:19 +00:00
Alexander Wilms and Andrey Filipenkov
5d7b83c10b
client/widgets/Buttons.cpp: Fix const reference
...
Co-authored-by: Andrey Filipenkov <kambaladecapitator@gmail.com >
2023-10-29 13:34:19 +00:00
Alexander Wilms
0232ae5327
AI/BattleAI/BattleEvaluator.cpp: Convert this integer literal to a bool literal.
...
Integer literals should not be cast to bool
2023-10-29 13:34:19 +00:00
Alexander Wilms
bfddc90ff4
AI/BattleAI.cpp: Use "std::array" or "std::vector" instead of a C-style array.
...
Variables of array type should not be declared cpp:M23_356
2023-10-29 13:34:19 +00:00
Alexander Wilms
466cdb9d2b
client/widgetsImages.{h,cpp}: implicit conversion loses integer precision: 'int' to 'uint8_t' (aka 'unsigned char')
2023-10-29 13:34:19 +00:00
Alexander Wilms
f1bb6b999c
client/widgets/Buttons.{h,cpp}: Pass expensive to copy object "callback" by reference to const.
2023-10-29 13:33:57 +00:00
Alexander Wilms
248877245e
Improve ccache hit rate for PRs
2023-10-29 01:33:40 +00:00
Alexander Wilms
e4db6f2af8
CClient::removeGUI(): This function should be declared 'const'
2023-10-28 23:05:05 +00:00
Alexander Wilms
9e1629fb40
launcher/modManager/cmodlist.cpp: Member functions that don't mutate their objects should be declared "const"
2023-10-28 16:44:58 +00:00
Alexander Wilms
d686d40bb4
launcher/firstLaunch/firstlaunch_moc.cpp: "static" members should be accessed statically
2023-10-28 15:44:17 +00:00
Alexander Wilms and GitHub
e95439e556
Installation_Linux.md: Fix link to Building_Linux.md
2023-10-28 17:13:13 +02:00
Alexander Wilms
a6db82f6f1
mapeditor/inspector/inspector.cpp: Directly assign to the "std::optional", without dereferencing it.
...
Assigning to an optional should directly target the optiona
2023-10-28 10:16:33 +00:00
Alexander Wilms
3d8dd35d43
lib/NetPacksLib.cpp: Directly assign to the "std::optional", without dereferencing it.
...
Assigning to an optional should directly target the optional
2023-10-28 10:15:50 +00:00
Alexander Wilms
703ab677ba
lib/mapObjects/IMarket.cpp: Show error message about failed dynamic_cast() even if cast object is nullptr
2023-10-27 23:43:39 +00:00
Alexander Wilms and Nordsoft91
bb04ca46b5
client/NetPacksClient.cpp: Combine null pointer checks
...
Co-authored-by: Nordsoft91 <nordsoft@yahoo.com >
2023-10-27 23:43:39 +00:00
Alexander Wilms and Nordsoft91
92bab6dd08
client/NetPacksClient.cpp: Combine null pointer checks
...
Co-authored-by: Nordsoft91 <nordsoft@yahoo.com >
2023-10-27 23:43:39 +00:00
Alexander Wilms
d2c03773cd
client/NetpacksClient.cpp: Called C++ object pointer is null
...
Null pointers should not be dereferenced
2023-10-27 23:43:39 +00:00
Alexander Wilms
03835236fb
lib/mapObjects/CGPandoraBox.cpp: Identical sub-expressions on both sides of operator "||".
...
Identical expressions should not be used on both sides of a binary operator
2023-10-27 23:40:55 +00:00
Alexander Wilms
cc8cc11da3
server/battles/BattleFlowProcessor.cpp: Called C++ object pointer is null
...
Null pointers should not be dereferenced
2023-10-27 23:40:55 +00:00
Alexander Wilms
860f6150aa
lib/mapObjects/IMarket.cpp: Forming reference to null pointer
...
Null pointers should not be dereferenced
2023-10-27 23:34:11 +00:00
Alexander Wilms
0a6c82c639
AI/Nullkiller/Behaviors/DefenceBehavior.{h,cpp}: treat -> threat
2023-10-27 23:34:11 +00:00
Alexander Wilms
457e73ed12
AI/BattleAI/BattleExchangeVariant.cpp: Do not assign data members in a constructor. Initialize members in an initialization list.
...
Member data should be initialized in-class or in a constructor initialization list
2023-10-27 23:34:11 +00:00
Alexander Wilms
ead1140b9b
client/icons/generate_icns.py: Replace print statement by built-in function.
...
The "print" statement should not be used
2023-10-27 23:34:11 +00:00
Alexander Wilms
b10b1a5444
AI/BattleAI/BattleExchangeVariant.cpp: This function should be declared "const".
...
Member functions that don't mutate their objects should be declared "const"
2023-10-27 23:34:11 +00:00
Alexander Wilms
af330ff038
AI/BattleAI/BattleEvaluator.cpp: Remove this redundant cast.
...
Redundant casts should not be used
2023-10-27 18:19:17 +00:00
Alexander Wilms
10ad5b6789
client/windows/CCastleInterface.cpp: Identical sub-expressions on both sides of operator "&&".
...
Identical expressions should not be used on both sides of a binary operator
2023-10-27 18:19:17 +00:00
Alexander Wilms
f01ec55d21
Use the "nullptr" literal.
...
"nullptr" should be used to denote the null pointer
2023-10-27 18:18:59 +00:00
Alexander Wilms
70acf987b4
lib/BasicTypes.cpp: Remove the unary minus operator or change the expression's underlying type.
...
Unary minus should not be applied to an unsigned expression
2023-10-27 14:47:09 +00:00
Alexander Wilms
2b21001743
lib/rmg/RoadPlacer.cpp: Remove "e" from this "throw" statement to rethrow the original exception.
...
The original exception object should be rethrown
2023-10-27 14:35:03 +00:00
Alexander Wilms
3616235bb5
FramerateManager.cpp: Merge this "if" statement with the enclosing one.
...
Collapsible "if" statements should be merged
2023-10-27 14:30:04 +00:00
Alexander Wilms
bcaa2e5966
AI/VCAI/VCAI.cpp: Remove "e" from "throw" statement to rethrow the original exception.
...
The original exception object should be rethrown
2023-10-27 14:29:44 +00:00
Alexander Wilms
e4aaeef5da
AUTHORS.h: Global variables should be const.
...
Non-const global variables should not be used
2023-10-27 14:29:34 +00:00
Alexander Wilms
04b3dca773
github.yml: Remove duplicate -prune in line endings stage
2023-10-27 14:28:58 +00:00
Alexander Wilms
1d206253e0
CI/linux-qt6/validate_json.py: Use sys.exit(1) instead of throwing Exception
2023-10-27 14:28:19 +00:00
Alexander Wilms
6516ecbedd
Format CI/linux-qt6/validate_json.py with 'black -l999 .'
2023-10-27 14:28:05 +00:00
Alexander Wilms
941181b8b9
Convert XML files in android/ from CRLF to LF, exclude .bat files from CI check
2023-10-23 13:33:09 +00:00
f63c2ac5db
CI step "Ensure LF line endings": No need to ignore Android files
...
Co-authored-by: Ivan Savenko <saven.ivan@gmail.com >
2023-10-23 14:55:09 +02:00
Alexander Wilms
7e9a3ea042
CI step "Ensure LF line endings": Don't create subshell for grouped commands
2023-10-22 17:50:16 +00:00
Alexander Wilms
0ff423ff0e
Change remaining CRLF line endings to LF
...
find . -type f -name "*.JSON" -exec dos2unix {} \+;
2023-10-22 16:41:09 +00:00
Alexander Wilms
9e84ddc0aa
Add CI stage to ensure LF line endings
...
Based on @josch's command:
https://github.com/vcmi/vcmi/pull/3078#issuecomment-1772150744
2023-10-22 16:12:16 +00:00
Alexander Wilms
5c0c317691
Move JSON validation script to CI folder
2023-10-14 14:22:50 +00:00
Alexander Wilms
a8ff11ad74
Remove redundant mention of GPL 2 or later from metainfo description
2023-10-14 14:16:50 +00:00
Alexander Wilms
01aa288b72
Link to Discord instead of Slack in metainfo
2023-10-14 14:07:05 +00:00
Alexander Wilms and Alexander Wilms
73ea52c615
Enable VSync to prevent screen tearing while scrolling across map
...
Fixes #2935
2023-09-26 18:55:25 +02:00
Alexander Wilms
1c20431035
Use 64px and 32px as icon sizes in launcher sidebar
2023-09-17 15:52:20 +00:00
Alexander Wilms
ee935e9fa7
Fix JSON files
2023-09-17 12:36:57 +00:00
Alexander Wilms
e0089c76ae
Add shebang, use elif and only run on linux-clang-test
2023-09-16 11:32:26 +00:00
Alexander Wilms
6c15e5b426
Add include path of a more recent version of fuzzylite, which is required to build it with gcc 12.2.0
...
https://github.com/fuzzylite/fuzzylite/commit/a651f3d13e192352d7a02ee9da65ab591a963ab9
2023-09-16 05:13:16 +00:00
Alexander Wilms
512816b223
Only validate JSON on Linux
2023-09-16 00:59:08 +00:00
Alexander Wilms
2394612e28
JSON validation: Support various levels of strictness
2023-09-15 23:47:32 +00:00
Alexander Wilms
f38f2d5b6a
Add JSON validation as a CI stage
2023-09-15 22:32:53 +00:00
Alexander Wilms and Ivan Savenko
c0f0211098
Update VCMI icon ( #2672 )
...
* Update VCMI icon
Fixes #1993
Sources will be added to https://github.com/vcmi/vcmi-assets
* Use entire canvas height for shield, add remaining icons
* Use a slighty more saturated brown
* Align VCMI letters to pixel grid for 32px icons
* Align VCMI letters to pixel grid for 48px icon
* Align VCMI letters to pixel grid for 64px icon
* Add 96px icon to .ico
* Update Android and iOS icons
* Install 22px icon on Linux
* Update macOS .icns file
* Add more icons
* Update iOS icons
* Add more sizes to .ico files
* Don't use .png inside .ico
* Only include resolutions up to 256px in .ico files
* Center map editor icon
2023-09-05 23:57:19 +03:00
Alexander Wilms and GitHub
d2f0a80573
Update VCMI icon ( #2672 )
...
* Update VCMI icon
Fixes #1993
Sources will be added to https://github.com/vcmi/vcmi-assets
* Use entire canvas height for shield, add remaining icons
* Use a slighty more saturated brown
* Align VCMI letters to pixel grid for 32px icons
* Align VCMI letters to pixel grid for 48px icon
* Align VCMI letters to pixel grid for 64px icon
* Add 96px icon to .ico
* Update Android and iOS icons
* Install 22px icon on Linux
* Update macOS .icns file
* Add more icons
* Update iOS icons
* Add more sizes to .ico files
* Don't use .png inside .ico
* Only include resolutions up to 256px in .ico files
* Center map editor icon
2023-09-01 22:36:32 +03:00
Alexander Wilms and GitHub
48150211d9
Update bug tracker URL in metainfo
2022-09-29 23:07:54 +02:00
Alexander Wilms and Andrii Danylchenko
d67d8a003e
Add 1.0.0 release to appstream metadata
2022-09-14 21:53:42 +03:00