1
0
mirror of https://github.com/SAP/jenkins-library.git synced 2024-12-14 11:03:09 +02:00
Commit Graph

3339 Commits

Author SHA1 Message Date
Marcus Holl
9e8e5da394
[refactoring] Make room for other upload action: move package (#2518)
* [refactoring] Make room for other upload action: move package

In the near future we will have more upload actions, like
SOLMAN, RFC. Here we prepare the package structure for that.

* don't use aliasing

* rename entities (no leading CTS)
2021-01-18 13:20:30 +01:00
Daniel Mieg
273012ddfc
Fix marshalling a boolean (#2521) 2021-01-18 11:14:55 +01:00
Sven Merk
205d59c1ed
Remove obsolete parameter (#2515)
* Remove obsolete parameter

* Update pkg/fortify/fortify_test.go

Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>

* Update fortify_test.go

Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2021-01-15 13:55:13 +01:00
Marcus Holl
f22ff9a4d5
Remove cm client as prerequisite since we are expecting always a docker environment (#2511) 2021-01-14 09:35:31 +01:00
Marcus Holl
c8c1315d0c
transport request upload cts / the step (#2416)
fiori cts upload piper-go step
2021-01-13 16:14:56 +01:00
Marcus Holl
f9af1841e4
[docu] remove outated hint for not supported CTS upload (#2506) 2021-01-13 15:13:38 +01:00
Oliver Feldmann
741b49140e
Move pull image parameters to general section (#2478)
* Move pull image parameters to general section

* Allow no nesting override

* Test dockerPullImage can be set to true

As the default is false, we need to make sure it can still be set to true.
2021-01-13 10:48:48 +01:00
Oliver Feldmann
ce9b958410
Document SendRequest error case (#2507)
* Document error case

* Improve docu text
2021-01-12 15:26:45 +01:00
Marcus Holl
84bb028ffd
fix typo for transportRequestUploadFile (#2499) 2021-01-12 15:15:30 +01:00
mayurmohan
f4469c3427
DeployIntegrationArtifact Command (#2474)
DeployIntegrationArtifact Command

Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
Co-authored-by: Marcus Holl <marcus.holl@sap.com>
2021-01-12 12:17:42 +01:00
Christopher Fenner
6dd006f0a0
fix(cpe): fix issue in custom type determination (#2505) 2021-01-12 11:36:25 +01:00
Marcus Holl
65d22eb42a
Mta extension credentials handling (#2430)
Mta extension credentials handling

Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2021-01-12 09:39:04 +01:00
Marcus Holl
93330d5ed2
Prepare credentials for forwarding as environment variables to piper go (#2432)
Prepare credentials for forwarding as environment variables to piper go
2021-01-12 09:17:34 +01:00
Christopher Fenner
834dd1a1de
fix(CPE): correct handling of complex (json) data in writeToDisk (#2500)
* correct handling of JSON data

* fix typo

* Update commonPipelineEnvironment.groovy
2021-01-11 12:58:12 +01:00
Oliver Nocon
006aaab50d
fix(handlePipelineStepError): correct handling of failed steps (#2498)
* WIP: debug incorrect error message

* Update piperExecuteBin.groovy

* Update piperExecuteBin.groovy

* Update handlePipelineStepErrors.groovy

* Update piperExecuteBin.groovy

* Update handlePipelineStepErrors.groovy

* Update piperExecuteBin.groovy

* Update piperExecuteBin.groovy

* Update piperExecuteBin.groovy

* Update piperExecuteBin.groovy

* Update handlePipelineStepErrors.groovy

* Update handlePipelineStepErrors.groovy

* Update commonPipelineEnvironment.groovy

* Update piperExecuteBin.groovy

* Update handlePipelineStepErrors.groovy

* Update handlePipelineStepErrors.groovy

* Update handlePipelineStepErrors.groovy

* Update handlePipelineStepErrors.groovy

* Update handlePipelineStepErrors.groovy

* Update piperExecuteBin.groovy

* Update piperExecuteBin.groovy

* Update piperExecuteBin.groovy

* Update commonPipelineEnvironment.groovy

* Update handlePipelineStepErrors.groovy

* Update handlePipelineStepErrors.groovy

* Update piperExecuteBin.groovy

* Update vars/piperExecuteBin.groovy

* Update vars/handlePipelineStepErrors.groovy

* Update handlePipelineStepErrors.groovy

* Apply suggestions from code review

* correct test case

* change test case

Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
Co-authored-by: Christopher Fenner <Christopher.Fenner@sap.com>
2021-01-11 10:49:33 +01:00
Oliver Nocon
ab3362849a
feat(kubernetesDeploy): allow disabling --force (#2495)
fixes #1731
2021-01-07 16:52:16 +01:00
Oliver Nocon
5f5450449e
fix(piperExecuteBin): define variable (#2497) 2021-01-07 12:24:48 +01:00
Marcus Holl
a6b2cb9c83
Tell us what was changed. (#2492)
With the current approach we get a failure when the generated
content triggers a change. But we cannot see what was changed.

With this commit we can see the diff. In case there is not diff
we will not see anything, so there is in that case no real change
in the behaviour. But in case there is a change we will see that
change.

Without that we have to reproduce locally, which means additional
efforts.
2021-01-04 13:23:30 +01:00
Marcus Holl
6d5a30683b
[refactor] Relocate npmExecutorMock so that it can be used from pkg (#2472)
From the current location inside "cmd" the npmExecutorMock cannot
be used from any coding inside "pkg".

When we would like to re-use the npm functionality we have also to
provide tests and this requires having a mock.

In order to be able to use the mock from pkg we move the mock from
"cmd" to "pkg" into package "npm".

With the shift from package "cmd" to "npm" a lot of fields in the mock
has been made public.
2021-01-04 12:46:14 +01:00
Marcus Holl
9172fcae04
Don't expose auth header to log (#2334)
Do not expose auth header to log
2021-01-04 10:06:28 +01:00
Oliver Nocon
59f32cf042
feature(vault) retrieve github token from Vault (#2484) 2020-12-22 17:57:11 +01:00
Oliver Nocon
4bd155d1ed
feature(protecodeExecuteScan) proper Vault support (#2483) 2020-12-22 17:43:57 +01:00
lndrschlz
b101106a05
chore: hide warn level if verbose not configured (#2466) 2020-12-22 14:33:11 +01:00
Fabian Reh
40a594f5fa
Add section about signing commits in git. (#2488)
* Add section about signing commits in git.

Signed-off-by: Fabian Reh <fabian.reh@sap.com>

* Fixes headings

Signed-off-by: Fabian Reh <fabian.reh@sap.com>
2020-12-22 10:09:35 +01:00
Fabian Reh
d8d4f83fb4
Unit test enhancement (#2471)
* Fixes parallelization in generated code

* Fixes test_code_generated.golden

* generate go code

Signed-off-by: Fabian Reh <fabian.reh@sap.com>

Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-12-22 09:30:54 +01:00
Hans Schulz
e9a7590c5c
Add cfTrace parameter (#2248)
* add cfTrace parameter

* make cfTrace toggle creation of log file

Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-12-21 17:46:52 +01:00
Oliver Nocon
7de42230e0
add step to create a GitHub issue (#2481)
* add step to create a GirHub issue

* add groovy library step

* Update githubcreateissue.yaml

Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com>
2020-12-21 17:13:16 +01:00
Oliver Nocon
cf7ca8f791
add step to create a GitHub comment (#2479)
* add step to create a GitHub comment

* add docs

* mandatory parameters

* add command

* Update githubCommentIssue.go

* add groovy library step

Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com>
2020-12-21 16:21:07 +01:00
Stephan Aßmus
cb069148d2
WS: Provide missing aliases (#2485) 2020-12-21 13:16:38 +01:00
Marcus Holl
cdb784aaf4
fiori cts upload (#2390)
fiori cts upload


Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
2020-12-21 09:05:49 +01:00
Marcus Holl
a84692ea97
Remove strange 'Hello', most likly troubleshoot leftover (#2475)
in case this is really important it should be logged and not
emitted to stdout.
2020-12-18 11:15:15 +01:00
tiloKo
dbef910e83
Update abapAddonAssemblyKitCheckPV.go (#2468)
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
2020-12-16 11:19:48 +01:00
Peter Persiel
fe6a0b057e
Replace naming of software product with add-on product (#2450)
Co-authored-by: Dominik Lendle <59923031+dominiklendle@users.noreply.github.com>
2020-12-16 10:11:41 +01:00
Marcus Holl
f9fc642c0e
http client: tell us which resource was not found (#2410)
Up to now we get a message 'Requested resource could not be found' which is not very
helpul during troubleshooting based on the log. With this change we tell the reader
which resource could not be resolved.
2020-12-16 08:55:22 +01:00
Srinikitha Kondreddy
d9a1355220
Fix typo (#2436) 2020-12-14 15:02:49 +01:00
Peter Persiel
e1935fe3dc
link multitenant application in ABAP Environment (#2451)
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
2020-12-14 14:35:51 +01:00
Christopher Fenner
9cd3ee5758
fix(checks+tests): fail pipeline if plugins fail the build (#2463)
* fix false negative

* add comment

* add default
2020-12-11 14:49:36 +01:00
Oliver Feldmann
96ebaa1a20
chore(docs): Fix switheroo of deployType and deployTool typo (#2464)
* Fix switcheroo

* Add commas
2020-12-11 13:11:36 +01:00
Daniel Mieg
44e7766e8f
Add stage docu (#2460)
* Add stage docu

* Add table to configuration.md

* Add comment to clone repo stage

* Fix indentation errors

* Docu: commitID

* fix links
2020-12-10 14:28:03 +01:00
Oliver Feldmann
4f6b99cead
Don't allow empty strings as default container parameters (#2406)
First a bug fix is addressed in which the pull policy could not be configured to false by configuring the general configuration. It could neither be configured via dockerExecute or dockerExecuteOnKubernetes, even though this parameter is docker specific. Only by configuring the specific step where one wants to set the pull policy to false can it be configured.

As the bug stems from zero values being in the context config map, which is also addressed with this PR. That is the second part: Context config parameters are only set if they have a value.

* Don't set pull image if not configured

Otherwise, if the pull policy is not set explicitly for a step, dockerPullImage is set to true. Thus, before this change, it cannot be set in the general, or in dockerExecute or in dockerExecuteOnKubernetes configuration.

* Fix unit tests

* Add pullImage parameter test

* Do not place empty default values in context config

* Use putIfNotEmpty for sidecar container options

* Export common configuration

Keys that are set by both main and sidecar container can be exported

Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2020-12-10 11:28:39 +01:00
Christopher Fenner
6970b57468
fix(cfDeploy): correct stash for go step (#2456) 2020-12-09 14:31:07 +01:00
Peter Persiel
f32420eb92
Change abap-oem service to saas_oem service plan (#2415) 2020-12-08 13:26:51 +01:00
Daniel Mieg
a3ff90f632
Fix: Change URL creation for abapEnvironmentCloneGitRepo (#2452)
* Fix url creation

* Adapt url creation
2020-12-08 09:31:08 +01:00
Florian Wilhelm
2ac5c42d15
Don't update go dependencies on schedule (#2447) 2020-12-07 09:20:31 +01:00
Marcus Holl
17bdbe2ef4
piperExecuteBin: provide credentials directly without indirection into config (#2437)
`piperExecuteBin` is called with a credentials list. Each list entry is a map consisting of
* the type of the credential (e.g. usernamePassword, token)
* the identifier which is used for resolving the credential.
* a list of environment variables which holds the resolved credentials.

Inside `piperExecuteBin` the id was resolved against the config and the result was used for resolving the credentials against the jenkins-credentials-plugin.

With this change here we introduce another key for the map mentioned above:
* resolveCredentialsId

When this key is provided with value `false` we do not resolve the credentials-id from the config. In that case the id is directly used for resolving the credential again the jenkins-credentials-plugin.
2020-12-07 08:54:49 +01:00
Christopher Fenner
fac4af231f
fix(cfDeploy): correct stashing (#2448)
* remove stash from step yaml

* add stash to groovy code
2020-12-05 13:35:16 +01:00
Florian Wilhelm
7dc2c86758
Revert "Update Go dependencies (#2441)" (#2449)
This reverts commit e03f2ba98c.

There is a regression in the go lib which was updated in this commit
2020-12-04 16:10:47 +01:00
Florian Wilhelm
e03f2ba98c
Update Go dependencies (#2441)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2020-12-04 11:09:11 +01:00
Daniel Mieg
b001474edd
Remove input statement (#2419)
* Remove input statement

* adaptDocu
2020-12-04 10:03:41 +01:00
Daniel Mieg
4573410379
Update abapEnvironmentAddons.md (#2446) 2020-12-04 09:31:53 +01:00