4120 Commits

Author	SHA1	Message	Date
Ivan Savenko	d85ee019ec	Removed CGHeroInstance::convertPosition method	2022-12-07 22:51:32 +02:00
Ivan Savenko	49cbd5adc9	CGHeroInstance::convertPosition is no longer static method	2022-12-07 22:34:08 +02:00
Ivan Savenko	908e6892f3	Removed CGHeroInstance::getPosition pseudo-override ... Now access to hero visible position is always done via visitablePos	2022-12-07 22:10:08 +02:00
Ivan Savenko	2855606a88	Enabled & fixed -Woverloaded-virtual warning from gcc/cland ... - fixed almost all instances of overloaded-virtual warning - cleared up inheritance & method overrides in code affected by warning	2022-12-07 21:50:45 +02:00
Ivan Savenko	65802d958b	Integrated valid fixes from PR #1143	2022-12-07 18:13:54 +02:00
Ivan Savenko	fb6b3c31e8	Renamed UNUSED -> MAYBE_UNUSED macro to match c++17 attribute name	2022-12-07 18:06:47 +02:00
Ivan Savenko	3219e322ae	Fixed all non-silenced gcc/clang warnings	2022-12-07 18:05:47 +02:00
Andrii Danylchenko	4b19d37988	Merge pull request #1214 from IvanSavenko/enlightenment_fix ... Library of Enlightenment fix	2022-12-07 09:14:06 +02:00
Ivan Savenko	17f9c3af23	Library of Enlightenment fix ... Do not offer choice between multiple identical option if hero is qualified to receive multiple of them due to diplomacy skill	2022-12-06 18:08:10 +02:00
nordsoft	5d1b5b6c9c	Throw an exception if empty zone is generated	2022-12-06 15:07:16 +04:00
Andrii Danylchenko	34cd856f53	Merge pull request #1197 from IvanSavenko/hero_positioning_fix ... Adjust positions of heroes in towns earlier	2022-12-05 14:47:44 +02:00
Ivan Savenko	46b8709712	Adjust positions of heroes in towns earlier ... fixes crash due to accessing tile that is outside of map bonds	2022-12-05 13:02:55 +02:00
Andrii Danylchenko	40e55e2788	Merge pull request #1196 from IvanSavenko/hero_positioning_fix ... Fixes incorrect positioning of heroes on spawn/release from prison	2022-12-05 10:35:24 +02:00
Ivan Savenko	2cc4f59699	Update map properly on hero position change	2022-12-04 22:03:25 +02:00
Ivan Savenko	b6b6063505	Fix positioning of heroes after release from prisons	2022-12-04 22:00:33 +02:00
Ivan Savenko	fa3a05a074	Removed hardcoded constants in hero placement code for more robust ... solution	2022-12-04 21:23:47 +02:00
nordsoft	bbe51bfaf4	Fix hero experience deserialization	2022-12-04 16:58:46 +04:00
nordsoft	8d1024fcfc	Clear error message	2022-12-03 20:56:05 +04:00
nordsoft	2f2c980a0c	Fix crash on map destroying	2022-12-03 20:56:05 +04:00
Ivan Savenko	1248292503	Fixed access violation - do NOT return address to temporary created on ... stack	2022-12-02 21:37:58 +02:00
Andrii Danylchenko	d9c4b28ccc	Merge pull request #1177 from IvanSavenko/fix_mod_identifiers ... Fix mod identifiers registration & incorrect mod validation	2022-12-02 09:20:49 +02:00
Andrii Danylchenko	82179a9cdb	Merge pull request #1176 from IvanSavenko/tower_shooter_icons ... Tower shooter icons fix	2022-12-01 12:30:24 +02:00
SoundSSGood	45a3064e5d	suggested changes	2022-11-30 18:28:33 +02:00
Ivan Savenko	7c410ab5ce	Fix potential crash due to iterator invalidation	2022-11-30 18:07:21 +02:00
Ivan Savenko	5cd405bce8	Fixed meta field handling in JsonUtils::inherit function, removed ... workarounds	2022-11-30 17:38:53 +02:00
Ivan Savenko	79c96e94fa	Cleared up comments	2022-11-30 17:37:36 +02:00
Ivan Savenko	36ae26bc37	Fixed several scenarios which could lead to json with incorrectly set ... mod origin info, leading to non-resolving identifiers	2022-11-29 22:34:32 +02:00
SoundSSGood	3bf0cfe4fa	Merge branch 'vcmi:develop' into refactoring-art	2022-11-29 22:34:08 +02:00
Ivan Savenko	abe11aaf54	Introduced "map" scope for accessing identifier on map loading. ... Currently it allows access to all mods, should be restricted to mods that map depends on	2022-11-29 22:33:08 +02:00
SoundSSGood	96d8e952c4	attempt to fix the build	2022-11-29 21:45:37 +02:00
Ivan Savenko	861a6849f9	Added possibility to define per-town tower icon for battle queue in siege	2022-11-29 14:47:51 +02:00
SoundSSGood	8a6052fd54	CArtHandler refactoring	2022-11-29 02:34:04 +02:00
SoundSSGood	909dcb82fa	use ArtifactID	2022-11-29 00:32:18 +02:00
krs	ea2fe78776	(char*)&data[0] changed to (char*)data.data()	2022-11-27 19:35:11 +02:00
krs	9b3cab1181	IVCMIDirs::userExtractedPath() created	2022-11-27 19:35:11 +02:00
krs	6130776fe4	removed one too many implementation of extractToFolder. ... changed parameter 2 from CFileInputStream to CInputStream	2022-11-27 19:35:11 +02:00
krs	75b4b64b6f	Final checks according to review	2022-11-27 19:35:11 +02:00
krs	31b7a81cd2	Data types in CArchiveLoader::extractToFolder() made more simple.	2022-11-27 19:35:10 +02:00
krs	d516a5f529	More changes following review.	2022-11-27 19:35:10 +02:00
krs	f0b66b6192	Animation.cpp fixes after review	2022-11-27 19:35:10 +02:00
krs	221a9e14b9	Linux Compile Fix: ../../lib/filesystem/CArchiveLoader.cpp:236:52: error: invalid initialization of non-const reference of type 'std::unique_ptr<CInputStream>&' from an rvalue of type 'std::unique_ptr<CInputStream>'	2022-11-27 19:35:10 +02:00
krs	62e479ae16	Linux Compile Fix: removed old code related to std::locale	2022-11-27 19:35:10 +02:00
krs	eecaa20693	Resource extractor "enablers" are now command line options ... In VCMI_lib the extractArchives will be passed all the way down the call chain!	2022-11-27 19:35:10 +02:00
krs	cca1f074bf	Convert PCX to PNG, Final touches, everything deactivated.	2022-11-27 19:35:10 +02:00
krs	93cf2682f3	Working Extractor, DefSplitter and pcx convertor	2022-11-27 19:35:10 +02:00
Andrii Danylchenko	3b072b80d5	Merge pull request #1168 from Nordsoft91/fix-obstacles-generation ... Fix obstacles generation	2022-11-27 09:56:11 +02:00
Andrii Danylchenko	dfee2eda68	Merge pull request #1148 from SoundSSGood/ask-assemble ... Feature to assemble/disassemble arts in backpack	2022-11-27 09:48:57 +02:00
nordsoft	8e324603bf	Remove extra lines	2022-11-27 00:08:47 +04:00
nordsoft	2c88e35749	Fix obstacles generation	2022-11-27 00:04:14 +04:00
Andrii Danylchenko	0ccb706782	Merge pull request #1155 from Nordsoft91/fix-camp-919 ... Fix for #919	2022-11-25 11:43:25 +02:00