Alexander Wilms
|
703ab677ba
|
lib/mapObjects/IMarket.cpp: Show error message about failed dynamic_cast() even if cast object is nullptr
|
2023-10-27 23:43:39 +00:00 |
|
Alexander Wilms
|
bb04ca46b5
|
client/NetPacksClient.cpp: Combine null pointer checks
Co-authored-by: Nordsoft91 <nordsoft@yahoo.com>
|
2023-10-27 23:43:39 +00:00 |
|
Alexander Wilms
|
92bab6dd08
|
client/NetPacksClient.cpp: Combine null pointer checks
Co-authored-by: Nordsoft91 <nordsoft@yahoo.com>
|
2023-10-27 23:43:39 +00:00 |
|
Alexander Wilms
|
d2c03773cd
|
client/NetpacksClient.cpp: Called C++ object pointer is null
Null pointers should not be dereferenced
|
2023-10-27 23:43:39 +00:00 |
|
Alexander Wilms
|
03835236fb
|
lib/mapObjects/CGPandoraBox.cpp: Identical sub-expressions on both sides of operator "||".
Identical expressions should not be used on both sides of a binary operator
|
2023-10-27 23:40:55 +00:00 |
|
Alexander Wilms
|
cc8cc11da3
|
server/battles/BattleFlowProcessor.cpp: Called C++ object pointer is null
Null pointers should not be dereferenced
|
2023-10-27 23:40:55 +00:00 |
|
Alexander Wilms
|
860f6150aa
|
lib/mapObjects/IMarket.cpp: Forming reference to null pointer
Null pointers should not be dereferenced
|
2023-10-27 23:34:11 +00:00 |
|
Alexander Wilms
|
0a6c82c639
|
AI/Nullkiller/Behaviors/DefenceBehavior.{h,cpp}: treat -> threat
|
2023-10-27 23:34:11 +00:00 |
|
Alexander Wilms
|
457e73ed12
|
AI/BattleAI/BattleExchangeVariant.cpp: Do not assign data members in a constructor. Initialize members in an initialization list.
Member data should be initialized in-class or in a constructor initialization list
|
2023-10-27 23:34:11 +00:00 |
|
Alexander Wilms
|
ead1140b9b
|
client/icons/generate_icns.py: Replace print statement by built-in function.
The "print" statement should not be used
|
2023-10-27 23:34:11 +00:00 |
|
Alexander Wilms
|
b10b1a5444
|
AI/BattleAI/BattleExchangeVariant.cpp: This function should be declared "const".
Member functions that don't mutate their objects should be declared "const"
|
2023-10-27 23:34:11 +00:00 |
|
Andrii Danylchenko
|
7531400f53
|
Merge pull request #3098 from vcmi/battle-ai-movement-fix
Battle ai movement fix
|
2023-10-27 22:10:41 +03:00 |
|
Alexander Wilms
|
af330ff038
|
AI/BattleAI/BattleEvaluator.cpp: Remove this redundant cast.
Redundant casts should not be used
|
2023-10-27 18:19:17 +00:00 |
|
Alexander Wilms
|
10ad5b6789
|
client/windows/CCastleInterface.cpp: Identical sub-expressions on both sides of operator "&&".
Identical expressions should not be used on both sides of a binary operator
|
2023-10-27 18:19:17 +00:00 |
|
Alexander Wilms
|
f01ec55d21
|
Use the "nullptr" literal.
"nullptr" should be used to denote the null pointer
|
2023-10-27 18:18:59 +00:00 |
|
Laserlicht
|
c1707bcc71
|
fix datatype
|
2023-10-27 18:52:25 +02:00 |
|
Alexander Wilms
|
70acf987b4
|
lib/BasicTypes.cpp: Remove the unary minus operator or change the expression's underlying type.
Unary minus should not be applied to an unsigned expression
|
2023-10-27 14:47:09 +00:00 |
|
Alexander Wilms
|
2b21001743
|
lib/rmg/RoadPlacer.cpp: Remove "e" from this "throw" statement to rethrow the original exception.
The original exception object should be rethrown
|
2023-10-27 14:35:03 +00:00 |
|
Alexander Wilms
|
3616235bb5
|
FramerateManager.cpp: Merge this "if" statement with the enclosing one.
Collapsible "if" statements should be merged
|
2023-10-27 14:30:04 +00:00 |
|
Alexander Wilms
|
bcaa2e5966
|
AI/VCAI/VCAI.cpp: Remove "e" from "throw" statement to rethrow the original exception.
The original exception object should be rethrown
|
2023-10-27 14:29:44 +00:00 |
|
Alexander Wilms
|
e4aaeef5da
|
AUTHORS.h: Global variables should be const.
Non-const global variables should not be used
|
2023-10-27 14:29:34 +00:00 |
|
Alexander Wilms
|
04b3dca773
|
github.yml: Remove duplicate -prune in line endings stage
|
2023-10-27 14:28:58 +00:00 |
|
Alexander Wilms
|
1d206253e0
|
CI/linux-qt6/validate_json.py: Use sys.exit(1) instead of throwing Exception
|
2023-10-27 14:28:19 +00:00 |
|
Alexander Wilms
|
6516ecbedd
|
Format CI/linux-qt6/validate_json.py with 'black -l999 .'
|
2023-10-27 14:28:05 +00:00 |
|
Nordsoft91
|
def927f8be
|
Merge pull request #3106 from Nordsoft91/editor-improvements-1.4
Fixes for map editor
|
2023-10-26 23:23:02 +02:00 |
|
Nordsoft91
|
8824835c09
|
Merge pull request #3096 from Alexander-Wilms/develop
Add CI stage to ensure LF line endings
|
2023-10-26 23:19:40 +02:00 |
|
Nordsoft91
|
8f2b50a5e2
|
Merge pull request #3095 from Laserlicht/team_alignment
fix team alignments
|
2023-10-26 23:19:18 +02:00 |
|
Ivan Savenko
|
feae8b6ae4
|
Do not allow loading new objects into another mod namespace
|
2023-10-26 15:32:46 +03:00 |
|
Ivan Savenko
|
6337b0d3b9
|
Fix potential crash on loading mod with invalid handler name
|
2023-10-26 15:32:13 +03:00 |
|
Tomasz Zieliński
|
a817e481d0
|
Merge fix
|
2023-10-26 10:46:04 +02:00 |
|
Tomasz Zieliński
|
36911d1e0a
|
Merge remote-tracking branch 'origin/develop' into fix_rmg_teams
# Conflicts:
# client/lobby/RandomMapTab.cpp
|
2023-10-26 10:31:41 +02:00 |
|
krs
|
7d473317ac
|
Renamed to AI.md
|
2023-10-26 00:13:22 +03:00 |
|
krs
|
27c4a1fe15
|
Update ai-description.md
|
2023-10-25 22:59:45 +03:00 |
|
krs
|
d0cdd06383
|
Update docs/developers/ai-description.md
Co-authored-by: Alexander Wilms <Alexander-Wilms@users.noreply.github.com>
|
2023-10-25 22:23:06 +03:00 |
|
krs
|
90f20b20d5
|
Added ai-description to docs
|
2023-10-25 21:13:47 +03:00 |
|
nordsoft
|
b6b75beb29
|
Fixes for map editor
1) fix owner serialization for hero placeholder
2) fix roads/rivers layout
3) fix lasso
|
2023-10-24 23:58:26 +02:00 |
|
Laserlicht
|
e28d14d16d
|
not needed anymore
|
2023-10-24 18:56:30 +02:00 |
|
Laserlicht
|
abb279f5b4
|
use config
|
2023-10-24 18:51:58 +02:00 |
|
Ivan Savenko
|
c202f58a15
|
Account for conflicts (and reverse-conflicts) when loading mods
|
2023-10-24 14:01:20 +03:00 |
|
Ivan Savenko
|
5cbf5031ea
|
move SetStackEffect to a separate file
|
2023-10-24 01:27:52 +03:00 |
|
krs
|
ab7caa0777
|
Removed space after Torosar hero name
|
2023-10-23 23:57:37 +02:00 |
|
Ivan Savenko
|
9fc3d822bb
|
Merge pull request #3103 from IvanSavenko/spell_shool_fix
Fix crash on accessing "any" spellschool via bonus system
|
2023-10-23 23:58:36 +03:00 |
|
Ivan Savenko
|
77780e0de5
|
Fix crash on accessing "any" spellschool via bonus system
|
2023-10-23 22:28:36 +03:00 |
|
Ivan Savenko
|
2315ea84ec
|
Invert condition
|
2023-10-23 22:18:21 +03:00 |
|
Ivan Savenko
|
7dfdee2db8
|
Check whether H3 data has been imported using most common spellings of
data directory
|
2023-10-23 20:33:01 +03:00 |
|
Ivan Savenko
|
91e202e0e3
|
Ignore case when checking whether path is white-listed.
Fixes data import with H3 data that has different case in directory names
|
2023-10-23 20:32:45 +03:00 |
|
Ivan Savenko
|
5523f05284
|
Moved ArtifactLocation to a separate file
|
2023-10-23 19:02:28 +03:00 |
|
Alexander Wilms
|
941181b8b9
|
Convert XML files in android/ from CRLF to LF, exclude .bat files from CI check
|
2023-10-23 13:33:09 +00:00 |
|
Ivan Savenko
|
ae92bdfb51
|
Fix Lua and test building
|
2023-10-23 16:05:38 +03:00 |
|
Alexander Wilms
|
f63c2ac5db
|
CI step "Ensure LF line endings": No need to ignore Android files
Co-authored-by: Ivan Savenko <saven.ivan@gmail.com>
|
2023-10-23 14:55:09 +02:00 |
|