Ivan Savenko
9fbeacb688
Fix possible memory corruption in video player
...
Fixes two bugs, one was definitely happening, and 2nd one that is causing
undefined behavior and may work only in some std implementations
- VideoPlayer would attempt to access subtitles widget after VideoPlayer
itself was destroyed in onPlaybackFinished call
- std::function was destroyed from a function that is being called by
it. Replaced with 1-method interface to avoid usage of std::function in
this scenario
2024-12-07 15:37:03 +00:00
Ivan Savenko
7543635847
Merge pull request #5032 from dydzio0614/alt-creature-buttons
...
Exchange full army by holding alt while pressing VCMI extras creature arrow button
2024-12-05 16:38:32 +02:00
Dydzio
ceac0bc203
Full exchange when holding alt while pressing exchange screen creature arrow button
2024-12-03 20:40:06 +01:00
Laserlicht
f6b37dbca2
revert text fix
2024-12-02 22:36:49 +01:00
Ivan Savenko
877f47e37f
Merge branch 'develop' into video
2024-12-02 13:48:30 +02:00
Ivan Savenko
304f6bbc90
Merge pull request #5009 from Laserlicht/scroll_fix
...
fix scrolling in search window
2024-12-02 13:13:23 +02:00
Ivan Savenko
f10899ed9e
Merge pull request #5006 from Laserlicht/textfixes
...
text fixes
2024-12-02 13:13:08 +02:00
Laserlicht
28fd6c50c4
search box scroll fix
2024-11-30 16:55:45 +01:00
Laserlicht
bb2f016f49
text fixes
2024-11-30 00:41:09 +01:00
Laserlicht
8808c9538c
use video player for spellbook animation
2024-11-29 21:58:20 +01:00
Ivan Savenko
c3494b4a73
Merge pull request #4982 from kdmcser/fix_dismiss_crash
...
crash fix: dismiss hero when pick artifact
2024-11-27 16:41:44 +02:00
kdmcser
993a4dc73d
crash fix: dismiss hero when pick artifact
2024-11-26 01:11:09 +08:00
Ivan Savenko
ebf0437f09
Merge pull request #4968 from Laserlicht/fix_window
...
fix hero window outside of screen
2024-11-25 13:45:45 +02:00
Laserlicht
6366175a3c
fix window
2024-11-23 19:19:07 +01:00
Ivan Savenko
f59834afe1
Fixes for configurable markets support
...
- string "speech" can now be translated
- removed "title" string, VCMI will now use object name instead
- moved configuration of all "markets" into a separate json file
- added schema for validation of market objects
- removed serialization of translated strings from University
2024-11-20 15:45:13 +00:00
Ivan Savenko
251155d913
More robust management of body/shadow/overlay split
2024-11-17 17:54:55 +00:00
Ivan Savenko
c82db9d574
Fix crash on rearranging troops on non-owned hero
2024-11-17 17:38:54 +00:00
Ivan Savenko
1a038b26ed
Merge pull request #4910 from Laserlicht/picture_regression
...
fix picture (regression)
2024-11-15 19:17:52 +02:00
Ivan Savenko
df0c53af41
Merge pull request #4864 from Laserlicht/creature_window_rework
...
Creature window rework
2024-11-15 19:13:58 +02:00
Laserlicht
ac12574f61
fix picture (regression)
2024-11-15 03:25:16 +01:00
Laserlicht
e73cb7f45b
Update client/windows/CCreatureWindow.cpp
...
Co-authored-by: Ivan Savenko <saven.ivan@gmail.com>
2024-11-13 20:03:20 +01:00
Ivan Savenko
46e492be01
Merge pull request #4891 from kdmcser/fix_research_spell_crash
...
fix spell research crash when no more spells can be researched
2024-11-13 20:50:24 +02:00
Ivan Savenko
1d0fdb1c0e
Merge pull request #4867 from Laserlicht/notFocusedClick
...
notFocusedClick refactoring
2024-11-13 20:49:31 +02:00
kdmcser
51e742f475
Merge branch 'develop' into fix_research_spell_crash
2024-11-10 23:32:33 +08:00
kdmcser
2621d4f5bf
fix spell research crash when no more spells can be researched due to map limit
2024-11-10 23:02:36 +08:00
Ivan Savenko
da8fe13632
Merge pull request #4870 from SoundSSGood/secSkillPlace-fix
...
CHeroOverview secondary skill icons fixed
2024-11-06 22:02:28 +02:00
Ivan Savenko
92fc66d1c2
Merge pull request #4875 from Laserlicht/patch-3
...
8th creature fix
2024-11-06 22:02:06 +02:00
Ivan Savenko
e7bea6c3b8
Merge pull request #4852 from IvanSavenko/remove_vlc_entities_serialization
...
Remove remaining pointers to VLC entities from serializer
2024-11-06 22:01:11 +02:00
SoundSSGood
fa9201831b
QuickBackpack window position on shift+click slot fixed
2024-11-04 14:16:06 +02:00
Laserlicht
7a52d1d533
8th creature fix
2024-11-03 22:51:48 +01:00
SoundSSGood
f60813d86f
CHeroOverview secondary skill icons fixed
2024-11-03 17:29:27 +02:00
Laserlicht
ca037aae33
notFocusedClick refactoring
2024-11-03 01:13:14 +01:00
Laserlicht
988d36bd13
sorted
2024-11-02 15:46:20 +01:00
Laserlicht
74b4fbfceb
small fix
2024-11-02 15:19:39 +01:00
Laserlicht
0ab4b66026
better approach for scrollbar
2024-11-02 15:16:38 +01:00
Laserlicht
9009dffebd
add "other" for bonus display
2024-11-02 14:51:33 +01:00
Laserlicht
17ee363d8d
changed bonus source text pos
2024-11-02 14:37:21 +01:00
Laserlicht
5a72a65b31
add labels
2024-11-02 13:59:09 +01:00
Laserlicht
440e9a6575
assign colors for bonuses
2024-11-02 13:05:10 +01:00
Laserlicht
3038e5140a
add color frames; remove scrollbar
2024-11-01 19:02:51 +01:00
kodobi
2678665f67
Resolve merge conflict
2024-10-30 18:48:09 +01:00
kodobi
44f479be89
Merge branch 'vcmi:develop' into bugfix/fix-ballista-damage-range-display
2024-10-30 18:41:29 +01:00
kodobi
0a0692061d
Merge branch 'bugfix/fix-ballista-damage-range-display' of https://github.com/kodobi/vcmi into bugfix/fix-ballista-damage-range-display
2024-10-30 18:39:11 +01:00
kodobi
b82444ba43
Fix ballista damage range display
...
- Adjusted the displayed damage range of ballista to reflect the changes in hero/es attack skill like in OH3.
- Added checks to ensure the battle interface and relevant heroes are valid before calculating damage.
2024-10-30 18:35:35 +01:00
Ivan Savenko
d3af9f1c67
Removed pointer to VLC entity from CStackBasicDescriptor
2024-10-30 16:47:02 +00:00
Ivan Savenko
c98ac01e7a
Replaced public artType member of ArtifactInstance with getter
2024-10-30 16:47:01 +00:00
Ivan Savenko
08fbcd5239
TerrainTile now uses identifiers instead of pointers to VLC
2024-10-30 16:22:11 +00:00
Ivan Savenko
f8b1f40abb
Merge pull request #4348 from MichalZr6/hill_fort_changes
...
Hill Fort unavailable upgrade and status bar new messages
2024-10-30 14:00:35 +02:00
Ivan Savenko
f12119f86c
Merge pull request #4812 from SoundSSGood/secSkillPlace
...
[Hota] SeafaringAcademy. Initial PR
2024-10-30 13:33:39 +02:00
kodobi
389f8b678b
Fix ballista damage range display
...
- Adjusted the displayed damage range of ballista to reflect the changes in hero/es attack skill like in OH3.
- Added checks to ensure the battle interface and relevant heroes are valid before calculating damage.
- Correctly retrieve the ballista status from the hero's war machine slot.
2024-10-29 20:44:31 +01:00
