games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2024-11-28 08:48:48 +02:00
Code Issues Releases Activity
13,570 Commits 21 Branches 61 Tags 104 MiB
0232ae5327
Commit Graph

13570 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Alexander Wilms
0232ae5327 AI/BattleAI/BattleEvaluator.cpp: Convert this integer literal to a bool literal. 
Integer literals should not be cast to bool
 2023-10-29 13:34:19 +00:00
Alexander Wilms
bfddc90ff4 AI/BattleAI.cpp: Use "std::array" or "std::vector" instead of a C-style array. 
Variables of array type should not be declared cpp:M23_356
 2023-10-29 13:34:19 +00:00
Alexander Wilms
466cdb9d2b client/widgetsImages.{h,cpp}: implicit conversion loses integer precision: 'int' to 'uint8_t' (aka 'unsigned char') 2023-10-29 13:34:19 +00:00
Alexander Wilms
f1bb6b999c client/widgets/Buttons.{h,cpp}: Pass expensive to copy object "callback" by reference to const. 2023-10-29 13:33:57 +00:00
Alexander Wilms
e4db6f2af8 CClient::removeGUI(): This function should be declared 'const' 2023-10-28 23:05:05 +00:00
Alexander Wilms
9e1629fb40 launcher/modManager/cmodlist.cpp: Member functions that don't mutate their objects should be declared "const" 2023-10-28 16:44:58 +00:00
Alexander Wilms
d686d40bb4 launcher/firstLaunch/firstlaunch_moc.cpp: "static" members should be accessed statically 2023-10-28 15:44:17 +00:00
Alexander Wilms
a6db82f6f1 mapeditor/inspector/inspector.cpp: Directly assign to the "std::optional", without dereferencing it. 
Assigning to an optional should directly target the optiona
 2023-10-28 10:16:33 +00:00
Alexander Wilms
3d8dd35d43 lib/NetPacksLib.cpp: Directly assign to the "std::optional", without dereferencing it. 
Assigning to an optional should directly target the optional
 2023-10-28 10:15:50 +00:00
Alexander Wilms
703ab677ba lib/mapObjects/IMarket.cpp: Show error message about failed dynamic_cast() even if cast object is nullptr 2023-10-27 23:43:39 +00:00
Alexander Wilms
bb04ca46b5 client/NetPacksClient.cpp: Combine null pointer checks 
Co-authored-by: Nordsoft91 <nordsoft@yahoo.com>
 2023-10-27 23:43:39 +00:00
Alexander Wilms
92bab6dd08 client/NetPacksClient.cpp: Combine null pointer checks 
Co-authored-by: Nordsoft91 <nordsoft@yahoo.com>
 2023-10-27 23:43:39 +00:00
Alexander Wilms
d2c03773cd client/NetpacksClient.cpp: Called C++ object pointer is null 
Null pointers should not be dereferenced
 2023-10-27 23:43:39 +00:00
Alexander Wilms
03835236fb lib/mapObjects/CGPandoraBox.cpp: Identical sub-expressions on both sides of operator "||". 
Identical expressions should not be used on both sides of a binary operator
 2023-10-27 23:40:55 +00:00
Alexander Wilms
cc8cc11da3 server/battles/BattleFlowProcessor.cpp: Called C++ object pointer is null 
Null pointers should not be dereferenced
 2023-10-27 23:40:55 +00:00
Alexander Wilms
860f6150aa lib/mapObjects/IMarket.cpp: Forming reference to null pointer 
Null pointers should not be dereferenced
 2023-10-27 23:34:11 +00:00
Alexander Wilms
0a6c82c639 AI/Nullkiller/Behaviors/DefenceBehavior.{h,cpp}: treat -> threat 2023-10-27 23:34:11 +00:00
Alexander Wilms
457e73ed12 AI/BattleAI/BattleExchangeVariant.cpp: Do not assign data members in a constructor. Initialize members in an initialization list. 
Member data should be initialized in-class or in a constructor initialization list
 2023-10-27 23:34:11 +00:00
Alexander Wilms
ead1140b9b client/icons/generate_icns.py: Replace print statement by built-in function. 
The "print" statement should not be used
 2023-10-27 23:34:11 +00:00
Alexander Wilms
b10b1a5444 AI/BattleAI/BattleExchangeVariant.cpp: This function should be declared "const". 
Member functions that don't mutate their objects should be declared "const"
 2023-10-27 23:34:11 +00:00
Alexander Wilms
af330ff038 AI/BattleAI/BattleEvaluator.cpp: Remove this redundant cast. 
Redundant casts should not be used
 2023-10-27 18:19:17 +00:00
Alexander Wilms
10ad5b6789 client/windows/CCastleInterface.cpp: Identical sub-expressions on both sides of operator "&&". 
Identical expressions should not be used on both sides of a binary operator
 2023-10-27 18:19:17 +00:00
Alexander Wilms
f01ec55d21 Use the "nullptr" literal. 
"nullptr" should be used to denote the null pointer
 2023-10-27 18:18:59 +00:00
Alexander Wilms
70acf987b4 lib/BasicTypes.cpp: Remove the unary minus operator or change the expression's underlying type. 
Unary minus should not be applied to an unsigned expression
 2023-10-27 14:47:09 +00:00
Alexander Wilms
2b21001743 lib/rmg/RoadPlacer.cpp: Remove "e" from this "throw" statement to rethrow the original exception. 
The original exception object should be rethrown
 2023-10-27 14:35:03 +00:00
Alexander Wilms
3616235bb5 FramerateManager.cpp: Merge this "if" statement with the enclosing one. 
Collapsible "if" statements should be merged
 2023-10-27 14:30:04 +00:00
Alexander Wilms
bcaa2e5966 AI/VCAI/VCAI.cpp: Remove "e" from "throw" statement to rethrow the original exception. 
The original exception object should be rethrown
 2023-10-27 14:29:44 +00:00
Alexander Wilms
e4aaeef5da AUTHORS.h: Global variables should be const. 
Non-const global variables should not be used
 2023-10-27 14:29:34 +00:00
Alexander Wilms
04b3dca773 github.yml: Remove duplicate -prune in line endings stage 2023-10-27 14:28:58 +00:00
Alexander Wilms
1d206253e0 CI/linux-qt6/validate_json.py: Use sys.exit(1) instead of throwing Exception 2023-10-27 14:28:19 +00:00
Alexander Wilms
6516ecbedd Format CI/linux-qt6/validate_json.py with 'black -l999 .' 2023-10-27 14:28:05 +00:00
Nordsoft91
def927f8be
Merge pull request #3106 from Nordsoft91/editor-improvements-1.4 
Fixes for map editor
 2023-10-26 23:23:02 +02:00
Nordsoft91
8824835c09
Merge pull request #3096 from Alexander-Wilms/develop 
Add CI stage to ensure LF line endings
 2023-10-26 23:19:40 +02:00
Nordsoft91
8f2b50a5e2
Merge pull request #3095 from Laserlicht/team_alignment 
fix team alignments
 2023-10-26 23:19:18 +02:00
nordsoft
b6b75beb29 Fixes for map editor 
1) fix owner serialization for hero placeholder
2) fix roads/rivers layout
3) fix lasso
 2023-10-24 23:58:26 +02:00
Laserlicht
e28d14d16d
not needed anymore 2023-10-24 18:56:30 +02:00
Laserlicht
abb279f5b4
use config 2023-10-24 18:51:58 +02:00
krs
ab7caa0777 Removed space after Torosar hero name 2023-10-23 23:57:37 +02:00
Ivan Savenko
9fc3d822bb
Merge pull request #3103 from IvanSavenko/spell_shool_fix 
Fix crash on accessing "any" spellschool via bonus system
 2023-10-23 23:58:36 +03:00
Ivan Savenko
77780e0de5 Fix crash on accessing "any" spellschool via bonus system 2023-10-23 22:28:36 +03:00
Alexander Wilms
941181b8b9 Convert XML files in android/ from CRLF to LF, exclude .bat files from CI check 2023-10-23 13:33:09 +00:00
Alexander Wilms
f63c2ac5db
CI step "Ensure LF line endings": No need to ignore Android files 
Co-authored-by: Ivan Savenko <saven.ivan@gmail.com>
 2023-10-23 14:55:09 +02:00
Alexander Wilms
7e9a3ea042 CI step "Ensure LF line endings": Don't create subshell for grouped commands 2023-10-22 17:50:16 +00:00
Alexander Wilms
0ff423ff0e Change remaining CRLF line endings to LF 
find . -type f -name "*.JSON" -exec dos2unix {} \+;
 2023-10-22 16:41:09 +00:00
Alexander Wilms
9e84ddc0aa Add CI stage to ensure LF line endings 
Based on @josch's command:
https://github.com/vcmi/vcmi/pull/3078#issuecomment-1772150744
 2023-10-22 16:12:16 +00:00
Ivan Savenko
3880ea58b9 Merge branch 'josch/dos2unix' into develop 2023-10-22 18:39:03 +03:00
Ivan Savenko
3867e512f7
Merge pull request #3064 from IvanSavenko/bonus_metaidentifier 
Type-safe bonus system
 2023-10-22 18:34:12 +03:00
Ivan Savenko
b0a67a66e4
Merge pull request #3092 from IvanSavenko/compatibility_mods 
Better support for compatibility mods
 2023-10-22 18:02:45 +03:00
Ivan Savenko
85f902fa26 Update docs 2023-10-22 17:12:34 +03:00
Ivan Savenko
8df39c43a0 Fix game loading 2023-10-22 17:04:14 +03:00