Alexander Wilms
|
457e73ed12
|
AI/BattleAI/BattleExchangeVariant.cpp: Do not assign data members in a constructor. Initialize members in an initialization list.
Member data should be initialized in-class or in a constructor initialization list
|
2023-10-27 23:34:11 +00:00 |
|
Alexander Wilms
|
ead1140b9b
|
client/icons/generate_icns.py: Replace print statement by built-in function.
The "print" statement should not be used
|
2023-10-27 23:34:11 +00:00 |
|
Alexander Wilms
|
b10b1a5444
|
AI/BattleAI/BattleExchangeVariant.cpp: This function should be declared "const".
Member functions that don't mutate their objects should be declared "const"
|
2023-10-27 23:34:11 +00:00 |
|
Alexander Wilms
|
af330ff038
|
AI/BattleAI/BattleEvaluator.cpp: Remove this redundant cast.
Redundant casts should not be used
|
2023-10-27 18:19:17 +00:00 |
|
Alexander Wilms
|
10ad5b6789
|
client/windows/CCastleInterface.cpp: Identical sub-expressions on both sides of operator "&&".
Identical expressions should not be used on both sides of a binary operator
|
2023-10-27 18:19:17 +00:00 |
|
Alexander Wilms
|
f01ec55d21
|
Use the "nullptr" literal.
"nullptr" should be used to denote the null pointer
|
2023-10-27 18:18:59 +00:00 |
|
Alexander Wilms
|
70acf987b4
|
lib/BasicTypes.cpp: Remove the unary minus operator or change the expression's underlying type.
Unary minus should not be applied to an unsigned expression
|
2023-10-27 14:47:09 +00:00 |
|
Alexander Wilms
|
2b21001743
|
lib/rmg/RoadPlacer.cpp: Remove "e" from this "throw" statement to rethrow the original exception.
The original exception object should be rethrown
|
2023-10-27 14:35:03 +00:00 |
|
Alexander Wilms
|
3616235bb5
|
FramerateManager.cpp: Merge this "if" statement with the enclosing one.
Collapsible "if" statements should be merged
|
2023-10-27 14:30:04 +00:00 |
|
Alexander Wilms
|
bcaa2e5966
|
AI/VCAI/VCAI.cpp: Remove "e" from "throw" statement to rethrow the original exception.
The original exception object should be rethrown
|
2023-10-27 14:29:44 +00:00 |
|
Alexander Wilms
|
e4aaeef5da
|
AUTHORS.h: Global variables should be const.
Non-const global variables should not be used
|
2023-10-27 14:29:34 +00:00 |
|
Alexander Wilms
|
04b3dca773
|
github.yml: Remove duplicate -prune in line endings stage
|
2023-10-27 14:28:58 +00:00 |
|
Alexander Wilms
|
1d206253e0
|
CI/linux-qt6/validate_json.py: Use sys.exit(1) instead of throwing Exception
|
2023-10-27 14:28:19 +00:00 |
|
Alexander Wilms
|
6516ecbedd
|
Format CI/linux-qt6/validate_json.py with 'black -l999 .'
|
2023-10-27 14:28:05 +00:00 |
|
Nordsoft91
|
def927f8be
|
Merge pull request #3106 from Nordsoft91/editor-improvements-1.4
Fixes for map editor
|
2023-10-26 23:23:02 +02:00 |
|
Nordsoft91
|
8824835c09
|
Merge pull request #3096 from Alexander-Wilms/develop
Add CI stage to ensure LF line endings
|
2023-10-26 23:19:40 +02:00 |
|
Nordsoft91
|
8f2b50a5e2
|
Merge pull request #3095 from Laserlicht/team_alignment
fix team alignments
|
2023-10-26 23:19:18 +02:00 |
|
nordsoft
|
b6b75beb29
|
Fixes for map editor
1) fix owner serialization for hero placeholder
2) fix roads/rivers layout
3) fix lasso
|
2023-10-24 23:58:26 +02:00 |
|
Laserlicht
|
e28d14d16d
|
not needed anymore
|
2023-10-24 18:56:30 +02:00 |
|
Laserlicht
|
abb279f5b4
|
use config
|
2023-10-24 18:51:58 +02:00 |
|
krs
|
ab7caa0777
|
Removed space after Torosar hero name
|
2023-10-23 23:57:37 +02:00 |
|
Ivan Savenko
|
9fc3d822bb
|
Merge pull request #3103 from IvanSavenko/spell_shool_fix
Fix crash on accessing "any" spellschool via bonus system
|
2023-10-23 23:58:36 +03:00 |
|
Ivan Savenko
|
77780e0de5
|
Fix crash on accessing "any" spellschool via bonus system
|
2023-10-23 22:28:36 +03:00 |
|
Alexander Wilms
|
941181b8b9
|
Convert XML files in android/ from CRLF to LF, exclude .bat files from CI check
|
2023-10-23 13:33:09 +00:00 |
|
Alexander Wilms
|
f63c2ac5db
|
CI step "Ensure LF line endings": No need to ignore Android files
Co-authored-by: Ivan Savenko <saven.ivan@gmail.com>
|
2023-10-23 14:55:09 +02:00 |
|
Alexander Wilms
|
7e9a3ea042
|
CI step "Ensure LF line endings": Don't create subshell for grouped commands
|
2023-10-22 17:50:16 +00:00 |
|
Alexander Wilms
|
0ff423ff0e
|
Change remaining CRLF line endings to LF
find . -type f -name "*.JSON" -exec dos2unix {} \+;
|
2023-10-22 16:41:09 +00:00 |
|
Alexander Wilms
|
9e84ddc0aa
|
Add CI stage to ensure LF line endings
Based on @josch's command:
https://github.com/vcmi/vcmi/pull/3078#issuecomment-1772150744
|
2023-10-22 16:12:16 +00:00 |
|
Ivan Savenko
|
3880ea58b9
|
Merge branch 'josch/dos2unix' into develop
|
2023-10-22 18:39:03 +03:00 |
|
Ivan Savenko
|
3867e512f7
|
Merge pull request #3064 from IvanSavenko/bonus_metaidentifier
Type-safe bonus system
|
2023-10-22 18:34:12 +03:00 |
|
Ivan Savenko
|
b0a67a66e4
|
Merge pull request #3092 from IvanSavenko/compatibility_mods
Better support for compatibility mods
|
2023-10-22 18:02:45 +03:00 |
|
Ivan Savenko
|
85f902fa26
|
Update docs
|
2023-10-22 17:12:34 +03:00 |
|
Ivan Savenko
|
8df39c43a0
|
Fix game loading
|
2023-10-22 17:04:14 +03:00 |
|
Ivan Savenko
|
a5f0429691
|
Merge pull request #3083 from Nordsoft91/editor-improvements-1.4
Redesign map editor rendering
|
2023-10-22 16:56:39 +03:00 |
|
Ivan Savenko
|
a70ad7202f
|
Merge pull request #3088 from Laserlicht/non_squared
Minimap keep aspect ratio (Letterboxing)
|
2023-10-22 16:55:58 +03:00 |
|
Ivan Savenko
|
4f47555977
|
Split OBJECT bonus source into OBJECT_TYPE and OBJECT_INSTANCE
|
2023-10-22 16:55:19 +03:00 |
|
Ivan Savenko
|
ac925bb786
|
Renamed new types for consistency with code style
|
2023-10-22 16:55:19 +03:00 |
|
Ivan Savenko
|
31cf3442af
|
Update docs
|
2023-10-22 16:55:19 +03:00 |
|
Ivan Savenko
|
36a1d6c415
|
Removed remaining integer bonus subtypes from configs
|
2023-10-22 16:55:19 +03:00 |
|
Ivan Savenko
|
e54ba7b977
|
Implement loading of bonus source type
|
2023-10-22 16:55:19 +03:00 |
|
Ivan Savenko
|
3b010d9596
|
Renamed MetaIdentifier to VariantIdentifier
|
2023-10-22 16:55:19 +03:00 |
|
Ivan Savenko
|
80e6485965
|
MetaIdentifier now uses std::variant internally
|
2023-10-22 16:55:19 +03:00 |
|
Ivan Savenko
|
b394158dc9
|
Bonus Source ID now uses metaidentifier
|
2023-10-22 16:55:18 +03:00 |
|
Ivan Savenko
|
77facf9387
|
Implement missing functions, fixes linking errors
|
2023-10-22 16:54:56 +03:00 |
|
Ivan Savenko
|
910ad50417
|
Fix client & server compilation
|
2023-10-22 16:54:48 +03:00 |
|
Ivan Savenko
|
0a10fc30b8
|
(lib) Bonus subtype is now stored as metaidentifier that can store any
other identifier inside it
|
2023-10-22 16:54:43 +03:00 |
|
Ivan Savenko
|
7e034814c1
|
Partially revert "Translation" type changes to avoid breaking mods
|
2023-10-22 16:51:08 +03:00 |
|
Ivan Savenko
|
454ba44ac5
|
Merge pull request #2988 from IvanSavenko/configurable_extensions
Extension of configurable object functionality
|
2023-10-22 16:24:47 +03:00 |
|
Laserlicht
|
b67548e7cf
|
format
|
2023-10-22 15:06:12 +02:00 |
|
Laserlicht
|
7b370d1967
|
fix team alignments
|
2023-10-22 15:00:04 +02:00 |
|