1
0
mirror of https://github.com/google/comprehensive-rust.git synced 2024-12-15 14:27:50 +02:00
Commit Graph

979 Commits

Author SHA1 Message Date
Martin Geisler
bd98a829c6
Fix typo in try-operator.md (#916) 2023-07-06 15:25:37 +01:00
Martin Geisler
02359573a4
Fix unclear wording in default.md (#915) 2023-07-06 15:25:16 +01:00
Martin Geisler
b573caad05
zh-TW: translate control-flow (#863)
Part of #684.
2023-07-06 13:08:19 +00:00
Martin Geisler
e199aee30d
Rephrase awkward sentence in rc.md (#906) 2023-07-06 15:03:06 +02:00
Makarevich
0c408f139c
ru: day 2, afternoon; first part (#897)
* modified:   po/ru.po: day 2, afternoon, part 1

* Apply other reviewers suggestions from code review

Co-authored-by: Dima <26358380+dyeroshenko@users.noreply.github.com>

* Apply other reviewers suggestions from code review

Co-authored-by: Yauheni Baltukha <evgenii.boltuho@gmail.com>
Co-authored-by: Dima <26358380+dyeroshenko@users.noreply.github.com>

* Apply suggestions from other code reviewers

Co-authored-by: Yauheni Baltukha <evgenii.boltuho@gmail.com>

* Apply suggestions from code review

Co-authored-by: Yauheni Baltukha <evgenii.boltuho@gmail.com>
Co-authored-by: zvonden <zdv@yahoo.com>

* Removed an extra EOLN to fix the build errors.

---------

Co-authored-by: zvonden <zdv@yahoo.com>
Co-authored-by: Dima <26358380+dyeroshenko@users.noreply.github.com>
Co-authored-by: Yauheni Baltukha <evgenii.boltuho@gmail.com>
2023-07-06 15:00:10 +02:00
Frances Wingerter
9567f16d75
Fix some typos and wording in welcome.md (#639) 2023-07-06 09:38:43 +00:00
Frances Wingerter
7f03a67a6a
Rename 'designing a library' example (#911)
rename 'designing a library' example

library design in Rust is its own topic that this course does not cover; to avoid confusion, let's stick to describing things in terms of books
2023-07-06 08:40:47 +00:00
Frances Wingerter
8df1d74e73
Fix some minor typos (#910)
* aspect-ratio-helper.py: fix typo

* basic syntax: make 'bits' plural in all occurrences
2023-07-06 08:39:47 +00:00
Frances Wingerter
a290a18065
Mention generic data structures as well as algorithms (#908)
generics: mention generic data structures as well as algorithms
2023-07-06 08:39:28 +00:00
Wojtek Marczenko
4413b6a28f
Update C manual memory management example (#902)
In C (as opposed to C++) the explicit cast from void* to int* is not required. It is also not idiomatic to do so in C code.

Actual C codebase would use `malloc()` without the cast, and a C++ one (when not using abstractions) a `new int[n]` - both a bit cleaner and less verbose than this example.
2023-07-05 09:37:07 -04:00
Martin Geisler
d27daceda2
Small improvement to wording in box-recursive.md (#905)
The "it" was not clear to our Localization team so I tried to make the sentence a little clearer.
2023-07-05 09:36:07 -04:00
AdrienBaudemont
72a87de08e
fr: update the translation on the Welcome page. (#891) 2023-07-05 14:14:20 +02:00
Martin Geisler
9a23ff820b
zh-TW: translate running-the-course (#864)
* zh-TW: translate running-the-course

Part of #684.

* Apply suggestions from code review

Co-authored-by: Ming-Ying Chung <mych@chromium.org>

---------

Co-authored-by: Ming-Ying Chung <mych@chromium.org>
2023-07-05 08:47:08 +00:00
Martin Geisler
e345044f6d
zh-TW: translate credits (#873)
Part of #684.
2023-07-05 10:42:45 +02:00
Yauheni Baltukha
56b741ce22
ru: Update po/ru.po with new messages (#899)
Update po/ru.po with new messages
2023-07-04 23:02:46 +02:00
Martin Geisler
d0223ad98b
Mention panics vs wrap-around for integer overflows (#901)
Fixes #894
2023-07-04 11:31:16 +01:00
zvonden
f4f0e7a1f3
ru: Fixed some ru terms, minor rephrasing. (#820)
Fixed some ru terms, minor rephrasing.
2023-07-04 09:25:46 +01:00
Victor Costan
6df4ba24dd
Clarify that each philosopher should think/eat 100 times (#900)
Clarify that each philosopher should think/eat 100 times.

Folks who have hazy memories of the philosopher dining problem may
interpret the original instructions as "make each philosopher think and
eat once". This interpretation loses a critical detail, because the
resulting code is highly unlikely to deadlock in practice, even without
breaking the symmetry.
2023-07-04 06:41:54 +00:00
Martin Geisler
fe8c374d3b
zh-CN: translate memory-management (#862)
* zh-CN: translate memory-management

Part of #324.

* Apply suggestions from code review

Co-authored-by: wnghl <wnghilin@gmail.com>

---------

Co-authored-by: wnghl <wnghilin@gmail.com>
2023-07-03 17:46:48 +08:00
Dima
2bffe39d53
Add @dyeroshenko as a reviewer for PL & RU (#892) 2023-07-03 08:38:09 +02:00
Yohann Coppel
7fadb45ece
Add missing binaries in TRANSLATIONS.md instructions. (#884)
* Add missing binaries in TRANSLATIONS.md instructions.

With these instructions, I can start from a clean fork, and get running
quickly.

* Update TRANSLATIONS.md: Add Debian

Co-authored-by: Martin Geisler <martin@geisler.net>

* Update TRANSLATIONS.md, format.

* Remove duplicate info between README and TRANSLATIONS.

---------

Co-authored-by: Martin Geisler <martin@geisler.net>
2023-07-03 08:37:06 +02:00
Matt Schulte
76ee72f8e0
Suggest to run day 3 afternoon exercise locally (#882)
* Suggest to run day 3 afternoon exercise locally

Based on feedback from running the class, students found developing
the day 3 afternoon exercise locally was a better experience than
using Playground.

* Update src/exercises/day-3/afternoon.md

---------

Co-authored-by: Martin Geisler <martin@geisler.net>
2023-07-03 06:36:38 +00:00
Mauve
9fc92c5d66
Tweak speaker note about move closures and FnOnce (#859)
* Tweak speaker note about move closures and FnOnce

* Expand closure example, explain move

* Explicitly state traits of example closures
2023-07-03 08:35:03 +02:00
Henri Fontana
3150163f95
pt-BR: Updates/completes translations for ch 1-6 (#886)
* Completing and improving pt-BR translation for
chapter 1.

* Small typo fix.

* Some other fixes.

* pt-BR: Updates/completes translations for ch 1-6

* Fix missing '\n'
2023-07-01 09:34:02 +01:00
João Victor Mendes
0326a45816
Update CODEOWNERS (#890) 2023-06-30 12:59:24 +00:00
João Victor Mendes
f1dd836f4f
pt-BR: update some fuzzy translations (#787)
Co-authored-by: Hugo Drumond Jacob <74555956+hugojacob@users.noreply.github.com>
2023-06-30 09:57:40 -03:00
Victor Costan
0c867c952f
"Strings and Iterators" solution that uses let-else (#833)
Add "Strings and Iterators" solution that uses let-else.
2023-06-29 08:52:58 +02:00
Martin Geisler
b83dd9a1f9
zh-CN: translate ownership (#868)
Part of #324.
2023-06-28 09:11:39 +00:00
Martin Geisler
fe40ef54e5
zh-CN: translate cargo (#870)
* zh-CN: translate cargo

Part of #324.

* Apply suggestions from code review

Co-authored-by: Abner Chou <zhcjtht@hotmail.com>

---------

Co-authored-by: Abner Chou <zhcjtht@hotmail.com>
2023-06-28 09:01:28 +00:00
Martin Geisler
03b1c0d06b
zh-TW: translate cargo (#871)
* zh-TW: translate cargo

Part of #684.

* Apply suggestions from code review

Co-authored-by: Jonathan Hao <phao@chromium.org>

* Use 建構 for build instead of 建立

---------

Co-authored-by: Jonathan Hao <phao@chromium.org>
Co-authored-by: Jonathan Hao <phao@google.com>
2023-06-28 09:56:13 +02:00
Martin Geisler
b14aaf768d
zh-TW: translate ownership (#860)
* zh-TW: translate ownership

Part of #684.

* Apply suggestions from code review

Co-authored-by: Jonathan Hao <phao@chromium.org>

* Replace "擁有權" with "所有權"

* Remove "__"

---------

Co-authored-by: Jonathan Hao <phao@chromium.org>
Co-authored-by: Jonathan Hao <phao@google.com>
2023-06-28 09:20:34 +02:00
Henri Fontana
cb8acfe2da
Update CODEOWNERS - add pt-BR reviewer (#880)
Adding myself (native Brazilian) as a pt-BR reviewer.
2023-06-28 09:19:33 +02:00
Martin Geisler
a2ff653d84
zh-CN: translate credits (#867)
Part of #324.
2023-06-28 09:17:53 +02:00
Martin Geisler
86a4bb4f89
zh-CN: translate enums (#869)
Part of #324.
2023-06-28 09:17:36 +02:00
Martin Geisler
3e26c0feed
zh-CN: translate control-flow (#866)
Part of #324.
2023-06-28 09:15:18 +02:00
Zhang Rui
f7d969787b
zh-CN: translate src/basic-syntax/variables.md, src/basic-syntax/type-inference.md (#796) (#841)
* zh-CN: translate src/basic-syntax/variables.md, src/basic-syntax/type-inference.md and some words in SUMMARY.md (#796)

* zh-CN: translate src/basic-syntax/variables.md, src/basic-syntax/type-inference.md and some words in SUMMARY.md

* Use "类型推导" for "Type Inference"

* Update translation in src/basic-syntax/type-inference.md

Co-authored-by: whd <7058128+superwhd@users.noreply.github.com>

* Update translation in src/basic-syntax/variables.md

Co-authored-by: whd <7058128+superwhd@users.noreply.github.com>

* Update translation in src/basic-syntax/type-inference.md

* Add newlines inside translation at src/basic-syntax/type-inference.md:28

* Revert "Update translation in src/basic-syntax/type-inference.md"

This reverts commit 5119474c1c.

* zh-CN: use `#, fuzzy` instead of FIXME comment in basic-syntax/type-inference.md

---------

Co-authored-by: Zhang Rui <me@zhrichard.me>
Co-authored-by: whd <7058128+superwhd@users.noreply.github.com>
2023-06-27 12:55:35 -04:00
wnghl
933abb6596
zh-CN: translate src/pattern-matching/destructuring-arrays.md (#834) 2023-06-27 17:49:34 +08:00
Chiin
753e53ad17
Correct print statement in library exercise (#876)
* fix(day 1): correct print statement logic for library emptiness status

* chore: add explicit method print

* chore: change `:` for `->`
2023-06-27 08:22:50 +00:00
HangDu
d5e460fddd
zh-CN: Translation for src/exercises/day-2/afternoon.md (#875)
Co-authored-by: Hang Du <hhangdu@google.com>
2023-06-25 09:58:13 +08:00
AdrienBaudemont
c4236cf718
fr: Update the translation for "Running the Course". (#874) 2023-06-24 00:37:41 +02:00
Victor Costan
0b4891fb1f
Unified FFI setup for for readdir() on macOS (#857)
Unified FFI setup for for readdir() on macOS.
2023-06-23 15:48:18 +02:00
CoinEZ
525ed90084
ja: Translate chapter 5 (#825)
* ja: Ch5.0 #652

・not confident about the translation "access to low-level hardware"

* ja: Ch.5.1 #652

* ja: Ch.5.2 #652

・"integer overflow is defined" -> 「整数オーバーフローの挙動が定義されている」 not confident here

* ja: Ch.5.3 #652

・a tad nit-picky, but believe the "The reasoning behind this..." should be on a line of its own, adding a "\n" between any of the three bullet points can fix this, BUT it will add a line between them. I personally prefer adding the "\n", but left as is

* ja: Ch.5 #652

fixes suggested by @keiichiw
2023-06-23 21:30:14 +09:00
Martin Geisler
eb6850a1d0
Clarify what "it" is in rust.md (#855) 2023-06-22 14:28:14 +00:00
Martin Geisler
d1d29283ba
Remove ineffective LICENSE link (#850)
Just like the Markdown files in #846, we cannot generate a redirect
for the LICENSE file this way. The broken link was fixed in #813, so
we should be fine here.
2023-06-22 16:27:56 +02:00
Martin Geisler
b7469f779e
Update if-let-expressions.md (#854)
The use of "interesting" here made the sentence unclear to our Localization team.
2023-06-22 16:27:34 +02:00
Martin Geisler
aba7fd7f56
Simplify error handling pages (#851)
This makes the `use` statements more consistent and shortens some
variable names.
2023-06-22 16:27:06 +02:00
Martin Geisler
ccde0db38c
Exclude book/ directory from auto-formatting (#852)
The directory contains generated files and should be ignored when
reformatting.
2023-06-22 10:13:53 -04:00
Martin Geisler
5d71f8a326
Open GitHub edit links in new tabs (#856)
I find this nicer since you don't lose your location in the book then.
2023-06-22 09:50:20 -04:00
Martin Geisler
5e42cc3548
Clarify wording in lifetimes.md (#853) 2023-06-22 13:47:27 +01:00
Martin Geisler
186d333227
Run builds on both Mac OS and Linux (#830)
* Run builds on both Mac OS and Linux

This would have helped us catch #570.

* Fix MacOS CI (#848)

* Revert unnecessary changes

The changes might be good, but I want to keep this PR small and
focused. If we end up with the extra `cfg` statements, we should
include a comment to let students know what they do: we’re targeting
people new to Rust, so we need to be careful with explanations.

---------

Co-authored-by: Dominik Maier <domenukk@gmail.com>
2023-06-22 10:38:41 +02:00