Alexander Wilms 678cacbd25 Remove more redundant virtual specifiers ...

`grep -nr "virtual " | grep -v googletest | grep " override" | grep -v overriden > ../redundant_virtual.txt`

```python
import os

with open("../redundant_virtual.txt") as f:
    for line in f:
        print()
        line: str = line.strip()
        print(line)
        tmp = line.split(":",2)
        file = tmp[0].strip()
        code = tmp[-1].strip()
        print(file)
        print(code)
        new_code = code.replace("virtual ", "", 1)
        # https://superuser.com/a/802490/578501
        command = f"export FIND='{code}' && export REPLACE='{new_code}' && ruby -p -i -e \"gsub(ENV['FIND'], ENV['REPLACE'])\" {file}"
        os.system(command)
```

2024-02-13 15:21:30 +01:00

..

battle

Make some non-const static variables const or constexpr

2024-02-12 13:22:54 +02:00

bonuses

Remove more redundant virtual specifiers

2024-02-13 15:21:30 +01:00

campaign

Added text container with map translations to campaign state

2024-01-31 20:01:24 +02:00

constants

Added range checks to values read from h3m.

2024-02-05 21:27:55 +02:00

events

Replace redundant types with auto for the lvalues of template factory functions for smart pointers

2024-01-17 12:50:00 +00:00

filesystem

Fixed decompression of slayer.h3c from french version from gog.com

2024-01-31 16:41:42 +02:00

gameState

Replaced some usages of void * with more clear CPack *

2024-02-12 12:53:10 +02:00

logging

…

mapObjectConstructors

Merge pull request #3574 from SoundSSGood/altar-fixes

2024-02-01 22:27:41 +02:00

mapObjects

Remove redundant virtual specifiers

2024-02-10 20:46:13 +01:00

mapping

Fix save compatiblity with 1.4

2024-02-11 17:31:30 +02:00

minizip

…

modding

Refactoring of serialization versioning handling

2024-01-20 20:34:51 +02:00

network

Fixed handling of match server crash

2024-02-04 19:58:09 +02:00

networkPacks

Fix potentially uninitialized values

2024-02-12 12:31:27 +02:00

pathfinder

Remove more redundant virtual specifiers

2024-02-13 15:21:30 +01:00

registerTypes

Workaround for broken save compatibility

2024-02-05 18:46:48 +02:00

rewardable

Added RandomGeneratorUtil::nextItemWeighted convenience method

2024-01-31 00:17:40 +02:00

rmg

Remove more redundant virtual specifiers

2024-02-13 15:21:30 +01:00

serializer

Clarified some (im)possible null dereferences

2024-02-12 13:05:30 +02:00

spells

Added RandomGeneratorUtil::nextItemWeighted convenience method

2024-01-31 00:17:40 +02:00

vstd

code review

2023-12-16 21:10:27 +01:00

AI_Base.h

…

ArtifactUtils.cpp

arts altar - arts holder

2024-01-27 15:28:21 +02:00

ArtifactUtils.h

Remove most of non-const access to VLC entities

2024-01-19 13:54:49 +02:00

BasicTypes.cpp

Renamed speed -> getMovementRange, remove misleading default parameter

2024-01-14 17:14:36 +02:00

BattleFieldHandler.cpp

Merge remote-tracking branch 'vcmi/master' into develop

2024-01-19 13:49:54 +02:00

BattleFieldHandler.h

Remove more redundant virtual specifiers

2024-02-13 15:21:30 +01:00

CAndroidVMHelper.cpp

…

CAndroidVMHelper.h

…

CArtHandler.cpp

sacrifice routine

2024-01-27 23:01:57 +02:00

CArtHandler.h

Remove redundant virtual specifiers

2024-02-10 20:46:13 +01:00

CArtifactInstance.cpp

split getBonusLocalFirst into two distinct method:

2024-01-19 13:56:06 +02:00

CArtifactInstance.h

Refactoring of serialization versioning handling

2024-01-20 20:34:51 +02:00

CBonusTypeHandler.cpp

Fix possible crash on invalid spell

2024-01-24 13:43:35 +02:00

CBonusTypeHandler.h

Refactoring of serialization versioning handling

2024-01-20 20:34:51 +02:00

CBuildingHandler.cpp

…

CBuildingHandler.h

…

CConfigHandler.cpp

…

CConfigHandler.h

…

CConsoleHandler.cpp

…

CConsoleHandler.h

…

CCreatureHandler.cpp

Added RandomGeneratorUtil::nextItemWeighted convenience method

2024-01-31 00:17:40 +02:00

CCreatureHandler.h

Remove redundant virtual specifiers

2024-02-10 20:46:13 +01:00

CCreatureSet.cpp

Merge pull request #3473 from IvanSavenko/const_lib

2024-01-20 19:22:46 +02:00

CCreatureSet.h

Remove more redundant virtual specifiers

2024-02-13 15:21:30 +01:00

CGameInfoCallback.cpp

Merge pull request #3574 from SoundSSGood/altar-fixes

2024-02-01 22:27:41 +02:00

CGameInfoCallback.h

Remove more redundant virtual specifiers

2024-02-13 15:21:30 +01:00

CGameInterface.cpp

Refactoring of serialization versioning handling

2024-01-20 20:34:51 +02:00

CGameInterface.h

Remove more redundant virtual specifiers

2024-02-13 15:21:30 +01:00

CGeneralTextHandler.cpp

Make some non-const static variables const or constexpr

2024-02-12 13:22:54 +02:00

CGeneralTextHandler.h

Added text container with map translations to campaign state

2024-01-31 20:01:24 +02:00

CHeroHandler.cpp

Added workaround for references to old 'torosar ' ID

2024-02-05 21:56:06 +02:00

CHeroHandler.h

Added range checks to values read from h3m.

2024-02-05 21:27:55 +02:00

CMakeLists.txt

…

Color.h

Refactoring of serialization versioning handling

2024-01-20 20:34:51 +02:00

CondSh.h

…

ConstTransitivePtr.h

Refactoring of serialization versioning handling

2024-01-20 20:34:51 +02:00

CPlayerState.cpp

Slight simplification of bonus system node class

2024-01-19 13:54:49 +02:00

CPlayerState.h

Implemented tracking of objects destroyed by players

2024-01-31 01:37:33 +02:00

CRandomGenerator.cpp

Add assertions to detect invalid calls

2024-01-16 21:12:57 +02:00

CRandomGenerator.h

Refactoring of serialization versioning handling

2024-01-20 20:34:51 +02:00

CScriptingModule.cpp

…

CScriptingModule.h

…

CSkillHandler.cpp

Remove duplicate semicolons

2024-01-16 19:02:39 +00:00

CSkillHandler.h

…

CSoundBase.h

…

CStack.cpp

Attempt to make constant bonus system nodes (CCreature / CArtifact)

2024-01-19 13:54:49 +02:00

CStack.h

Refactoring of serialization versioning handling

2024-01-20 20:34:51 +02:00

CStopWatch.h

Define each identifier in a dedicated statement

2024-01-10 00:22:23 +00:00

CThreadHelper.cpp

Add OpenBSD defines

2023-12-14 10:29:42 +03:00

CThreadHelper.h

Define each identifier in a dedicated statement

2024-01-10 00:22:23 +00:00

CTownHandler.cpp

Removed most of non-const static fields in lib. Reduced header includes.

2024-01-19 13:55:22 +02:00

CTownHandler.h

Removed most of non-const static fields in lib. Reduced header includes.

2024-01-19 13:55:22 +02:00

ExtraOptionsInfo.cpp

moved to gameconfig

2024-01-20 17:54:15 +01:00

ExtraOptionsInfo.h

Refactoring of serialization versioning handling

2024-01-20 20:34:51 +02:00

FunctionList.h

…

GameCallbackHolder.h

Stabilization

2024-01-19 13:55:22 +02:00

GameConstants.h

…

GameSettings.cpp

Working SoD version of fly

2024-02-07 19:27:02 +01:00

GameSettings.h

Working SoD version of fly

2024-02-07 19:27:02 +01:00

IBonusTypeHandler.h

…

IGameCallback.cpp

Merge remote-tracking branch 'vcmi/develop' into lobby

2024-02-03 21:11:34 +02:00

IGameCallback.h

Merge pull request #3574 from SoundSSGood/altar-fixes

2024-02-01 22:27:41 +02:00

IGameEventsReceiver.h

…

IHandlerBase.cpp

…

IHandlerBase.h

Removed most of non-const static fields in lib. Reduced header includes.

2024-01-19 13:55:22 +02:00

int3.h

Fix "identical expressions on both sides of comparison"

2024-02-12 12:32:35 +02:00

JsonDetail.cpp

Make some non-const static variables const or constexpr

2024-02-12 13:22:54 +02:00

JsonDetail.h

…

JsonNode.cpp

Use std::byte in serializer

2024-02-02 13:09:12 +02:00

JsonNode.h

Use std::byte in serializer

2024-02-02 13:09:12 +02:00

JsonRandom.cpp

Merge branch 'master' into 'develop'

2024-01-25 16:23:13 +02:00

JsonRandom.h

Code cleanup

2024-01-19 23:02:00 +02:00

Languages.h

fix russia

2023-12-16 19:26:41 +01:00

LoadProgress.cpp

Fix issues introduced by automated replacement of redundant types

2024-01-17 20:12:57 +00:00

LoadProgress.h

Define each identifier in a dedicated statement

2024-01-10 00:22:23 +00:00

LogicalExpression.cpp

…

LogicalExpression.h

Refactoring of serialization versioning handling

2024-01-20 20:34:51 +02:00

MetaString.cpp

Fix Grail digging success message

2024-02-01 18:22:11 +02:00

MetaString.h

Fix Grail digging success message

2024-02-01 18:22:11 +02:00

ObstacleHandler.cpp

…

ObstacleHandler.h

Define each identifier in a dedicated statement

2024-01-10 00:22:23 +00:00

Point.h

Refactoring of serialization versioning handling

2024-01-20 20:34:51 +02:00

Rect.cpp

…

Rect.h

Refactoring of serialization versioning handling

2024-01-20 20:34:51 +02:00

ResourceSet.cpp

Fixes compilation error "ResourceSet.h:33:21: error: function 'ResourceSet::ResourceSet()' definition is marked dllimport" when building with g++ 12.1.0

2023-12-30 00:29:31 +01:00

ResourceSet.h

Refactoring of serialization versioning handling

2024-01-20 20:34:51 +02:00

RiverHandler.cpp

Remove most of non-const access to VLC entities

2024-01-19 13:54:49 +02:00

RiverHandler.h

Remove more redundant virtual specifiers

2024-02-13 15:21:30 +01:00

RoadHandler.cpp

Remove most of non-const access to VLC entities

2024-01-19 13:54:49 +02:00

RoadHandler.h

Remove more redundant virtual specifiers

2024-02-13 15:21:30 +01:00

ScopeGuard.h

Fix undefined behavior

2024-02-12 12:33:09 +02:00

ScriptHandler.cpp

Replace redundant types with auto for the lvalues of template factory functions for smart pointers

2024-01-17 12:50:00 +00:00

ScriptHandler.h

Refactoring of serialization versioning handling

2024-01-20 20:34:51 +02:00

StartInfo.cpp

Added list of active accounts and rooms to UI. Added room creation logic

2024-01-26 16:32:36 +02:00

StartInfo.h

Merge remote-tracking branch 'vcmi/develop' into lobby

2024-01-26 16:52:23 +02:00

StdInc.cpp

…

StdInc.h

…

TerrainHandler.cpp

…

TerrainHandler.h

Remove more redundant virtual specifiers

2024-02-13 15:21:30 +01:00

TextOperations.cpp

Client-side update, adapted and fixed login and chat

2024-01-19 23:49:59 +02:00

TextOperations.h

Client-side update, adapted and fixed login and chat

2024-01-19 23:49:59 +02:00

TurnTimerInfo.cpp

Reworked timer widget to show timers for all players

2023-12-22 18:40:28 +02:00

TurnTimerInfo.h

Refactoring of serialization versioning handling

2024-01-20 20:34:51 +02:00

UnlockGuard.h

…

vcmi_endian.h

…

VCMI_lib.cbp

…

VCMI_Lib.cpp

Fix build

2024-01-19 13:56:05 +02:00

VCMI_Lib.h

Fix build

2024-01-19 13:56:05 +02:00

VCMI_lib.vcxproj

…

VCMI_lib.vcxproj.filters

…

VCMIDirs.cpp

…

VCMIDirs.h

…