games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2024-12-18 17:40:48 +02:00
Code Issues Releases Activity
fca9bcdd7f
vcmi/lib
History
Toney Sui dca5d86e7a
Fix bug: LandMine is not exploding to enemies. (#630) 
* The reason is,

the mine has attribute hidden=true;
when enemy unit moves, the code in BattleInfo.cpp MoveUnit() (line 817) will update the revealed to true;
then in the CGameHandler.cpp handleDamageFromObstacle() (line 4846) is checking , and the condition battleIsObstacleVisibleForSide() will return true, so the effect will not be triggerred.

Resolution:
1. Remove the "revealed=true" in moveUnit(), and in handleDamageFromObstacle, remove the "const" restrict for obstacle, and then update revealed to true;
2. After the takeDamage function, add a pack "BattleObstaclesChanged" to update the obstacle to be "revealed=true".
2020-02-12 20:12:12 +03:00
..
battle Fix bug: LandMine is not exploding to enemies. (#630) 2020-02-12 20:12:12 +03:00
filesystem Simplify statements 2019-03-31 09:43:14 +03:00
logging Warnings fixes (#538) 2019-01-19 13:52:02 +03:00
mapObjects Fix quest handling 2020-01-31 00:48:01 +02:00
mapping Do not build pseudo-buildings explicitly with events 2019-06-04 22:29:07 +02:00
minizip Update VS files to 2019, partially fix test project 2019-06-09 17:28:55 +02:00
registerTypes Exposed more of existing limiters for modders (#449) 2018-04-17 19:59:30 +07:00
rmg Simplify statements 2019-03-31 09:43:14 +03:00
serializer Fix build with Boost versioni >= 1.70 (#615) 2020-01-21 11:55:28 +03:00
spells Initialize the change: 2020-01-25 01:21:26 -08:00
vstd Settings: savefrequency is now configurable in launcher 2018-04-08 17:12:29 +07:00
AI_Base.h Code style: move or add licensing information on top of every file 2017-07-14 01:26:03 +03:00
CAndroidVMHelper.cpp apply review comments for CAndroidVMHelper 2018-05-26 14:50:49 +03:00
CAndroidVMHelper.h apply review comments for CAndroidVMHelper 2018-05-26 14:50:49 +03:00
CArtHandler.cpp Spelling fixes: privilaged -> privileged, retreive -> retrieve 2018-02-10 21:52:23 +03:00
CArtHandler.h Spelling fixes: privilaged -> privileged, retreive -> retrieve 2018-02-10 21:52:23 +03:00
CBonusTypeHandler.cpp Finished conversion to new logging API 2017-08-11 23:06:27 +03:00
CBonusTypeHandler.h Tweaked CBonusTypeHandler 2017-08-09 12:18:49 +03:00
CBuildingHandler.cpp Code style: move or add licensing information on top of every file 2017-07-14 01:26:03 +03:00
CBuildingHandler.h Code style: move or add licensing information on top of every file 2017-07-14 01:26:03 +03:00
CConfigHandler.cpp Revert only launcher saving to settings.json from PR441 2018-07-16 22:05:42 +02:00
CConfigHandler.h Revert only launcher saving to settings.json from PR441 2018-07-16 22:05:42 +02:00
CConsoleHandler.cpp fixes 2017-08-12 14:36:37 +03:00
CConsoleHandler.h Code style: remove senseless comments 2017-07-18 00:04:00 +03:00
CCreatureHandler.cpp Spells configuration version 2 (effect-based) 2018-02-08 11:37:21 +03:00
CCreatureHandler.h Spells configuration version 2 (effect-based) 2018-02-08 11:37:21 +03:00
CCreatureSet.cpp Style fixes 2019-02-12 19:47:19 +01:00
CCreatureSet.h Do not use CCreature in CSimpleArmy 2018-03-17 13:24:12 +08:00
CGameInfoCallback.cpp Warnings fixes (#538) 2019-01-19 13:52:02 +03:00
CGameInfoCallback.h AI pathfinding: rename and add const to functions 2018-10-07 14:51:27 +03:00
CGameInterface.cpp Spells configuration version 2 (effect-based) 2018-02-08 11:37:21 +03:00
CGameInterface.h Gui cleanup3 - UI refactoring to use smart pointers (#440) 2018-04-07 18:34:11 +07:00
CGameState.cpp Check other players startinfo for random hero pick (#580) 2019-04-29 08:45:30 +03:00
CGameState.h AI pathfinding: rename and add const to functions 2018-10-07 14:51:27 +03:00
CGameStateFwd.h Code style: serialize everything on own lines for easier debugging (#357) 2017-07-31 16:35:42 +03:00
CGeneralTextHandler.cpp Catch exceptions by const-ref, not by value 2018-10-29 16:41:54 +01:00
CGeneralTextHandler.h skill names and descriptions are fully managed by CSkillHandler 2017-08-30 22:35:23 +12:00
CHeroHandler.cpp Add description for bonuses from hero specialty 2018-10-29 21:33:13 +01:00
CHeroHandler.h Warnings fixes (#538) 2019-01-19 13:52:02 +03:00
CMakeLists.txt CMake more transitive 2019-03-28 16:56:51 +03:00
CModHandler.cpp CModHandler: remove hardcoded wog mod integrity check 2020-01-15 18:20:51 +00:00
CModHandler.h Hardcoded feature: no random week/month effects 2019-03-17 18:27:05 +01:00
CondSh.h Code style: move or add licensing information on top of every file 2017-07-14 01:26:03 +03:00
ConstTransitivePtr.h Code style: move or add licensing information on top of every file 2017-07-14 01:26:03 +03:00
CPathfinder.cpp Fix attack cursor on guarded visitable object 2019-07-14 13:25:06 +03:00
CPathfinder.h Use the same cost value in Pathfinder and fuzzy evaluations. 2019-01-17 10:54:41 +03:00
CPlayerState.h Code style: serialize everything on own lines for easier debugging (#357) 2017-07-31 16:35:42 +03:00
CRandomGenerator.cpp Spells configuration version 2 (effect-based) 2018-02-08 11:37:21 +03:00
CRandomGenerator.h Spells configuration version 2 (effect-based) 2018-02-08 11:37:21 +03:00
CScriptingModule.h Spelling fixes: privilaged -> privileged, retreive -> retrieve 2018-02-10 21:52:23 +03:00
CSkillHandler.cpp Change skill bonuses description to use name instead of identifier 2018-10-29 20:53:13 +01:00
CSkillHandler.h Enabled new secondary skills to be created (#438) 2018-03-31 12:56:40 +07:00
CSoundBase.h Implement configurable object sounds: ambient, visit and removal 2018-01-02 09:49:03 +01:00
CStack.cpp Simplify statements 2019-03-31 09:43:14 +03:00
CStack.h Exposed more of existing limiters for modders (#449) 2018-04-17 19:59:30 +07:00
CStopWatch.h Code style: move or add licensing information on top of every file 2017-07-14 01:26:03 +03:00
CThreadHelper.cpp Spells configuration version 2 (effect-based) 2018-02-08 11:37:21 +03:00
CThreadHelper.h Code style: move or add licensing information on top of every file 2017-07-14 01:26:03 +03:00
CTownHandler.cpp Warnings fixes (#538) 2019-01-19 13:52:02 +03:00
CTownHandler.h Setup town`s war machine in finalization step 2018-07-16 15:16:55 +03:00
FunctionList.h Code style: move or add licensing information on top of every file 2017-07-14 01:26:03 +03:00
GameConstants.cpp Spells configuration version 2 (effect-based) 2018-02-08 11:37:21 +03:00
GameConstants.h Full rework of pre-game interface and networking 2018-04-04 14:24:26 +07:00
HeroBonus.cpp Initialize the change. 2020-01-19 04:12:59 +00:00
HeroBonus.h Fix one space issue. 2020-01-19 04:12:59 +00:00
IBonusTypeHandler.h Warnings fixes (#538) 2019-01-19 13:52:02 +03:00
IGameCallback.cpp Full rework of pre-game interface and networking 2018-04-04 14:24:26 +07:00
IGameCallback.h CGameHandler: rename CPackForClient argument and add network logging 2018-04-04 14:24:32 +07:00
IGameEventsReceiver.h Gui cleanup3 - UI refactoring to use smart pointers (#440) 2018-04-07 18:34:11 +07:00
IHandlerBase.cpp
IHandlerBase.h Enabled new secondary skills to be created (#438) 2018-03-31 12:56:40 +07:00
int3.h Warnings fixes (#538) 2019-01-19 13:52:02 +03:00
Interprocess.h Code style: move or add licensing information on top of every file 2017-07-14 01:26:03 +03:00
JsonDetail.cpp Configure JSON merge behaviour via #override flag (#423) 2018-03-05 11:30:10 +08:00
JsonDetail.h print json in compact format 2018-02-18 19:27:24 +13:00
JsonNode.cpp allow json schema references to use relative file path 2018-10-30 22:30:56 +01:00
JsonNode.h Enable Limiter nesting with AllOf, AnyOf, NoneOf (#439) 2018-04-01 18:17:34 +07:00
LogicalExpression.cpp Code style: move or add licensing information on top of every file 2017-07-14 01:26:03 +03:00
LogicalExpression.h Code style: move or add licensing information on top of every file 2017-07-14 01:26:03 +03:00
NetPacks.h Full rework of pre-game interface and networking 2018-04-04 14:24:26 +07:00
NetPacksBase.h Rename typo in NetPacksServer.cpp 2018-11-17 21:58:54 +02:00
NetPacksLib.cpp Fix bug: LandMine is not exploding to enemies. (#630) 2020-02-12 20:12:12 +03:00
NetPacksLobby.h Full rework of pre-game interface and networking 2018-04-04 14:24:26 +07:00
PathfinderUtil.h VCAI performance improvements 2019-01-17 10:50:56 +03:00
ResourceSet.cpp I have no idea what I'm doing 2018-07-26 12:14:29 +02:00
ResourceSet.h I have no idea what I'm doing 2018-07-26 12:14:29 +02:00
ScopeGuard.h
StartInfo.cpp Full rework of pre-game interface and networking 2018-04-04 14:24:26 +07:00
StartInfo.h Warnings fixes (#538) 2019-01-19 13:52:02 +03:00
StdInc.cpp
StdInc.h Moved boost:format log proxy to CLoggerBase 2016-08-13 16:57:18 +03:00
StringConstants.h Code style: move or add licensing information on top of every file 2017-07-14 01:26:03 +03:00
UnlockGuard.h Code style: move or add licensing information on top of every file 2017-07-14 01:26:03 +03:00
vcmi_endian.h Code style: move or add licensing information on top of every file 2017-07-14 01:26:03 +03:00
VCMI_lib.cbp [C::B] Switched to boost shared linkage 2019-05-30 20:55:40 +03:00
VCMI_Lib.cpp Spells configuration version 2 (effect-based) 2018-02-08 11:37:21 +03:00
VCMI_Lib.h Spells configuration version 2 (effect-based) 2018-02-08 11:37:21 +03:00
VCMI_lib.vcxproj Update VS files to 2019, partially fix test project 2019-06-09 17:28:55 +02:00
VCMI_lib.vcxproj.filters Update visual studio project files 2018-08-22 17:31:48 +03:00
VCMIDirs.cpp VCMIDirs: improvements for development on Mac and Linux 2017-08-25 08:43:27 +03:00
VCMIDirs.h Code style: move or add licensing information on top of every file 2017-07-14 01:26:03 +03:00